Koha-clms/Koha
Colin Campbell fb2c1f177e Bug 18267: Refactored Edifact Price Calculations
Refactored the price calculations for Quotes and Invoices
This takes in to account various combinations used by different
vendors. Makes the extraction of basic price, quantity and tax
information more reliable. Tests are in Edifact.t and EdiInvoice.t

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 36d46c6510)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

(cherry picked from commit a939f9ab17)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
2020-12-09 21:24:47 +01:00
..
Account Bug 23805: (RM follow-up) Add credit_type relation to Koha::Account::Line 2019-11-20 11:56:41 +00:00
Acquisition Bug 23927: Do not copy invoiceid for a new duplicated order 2019-11-27 09:18:27 +00:00
ArticleRequest Bug 14610 - Add and update modules 2016-10-26 12:15:13 +00:00
Authority Bug 14769: (QA follow-up) Remove global var $cached_indicators 2018-04-12 10:50:36 -03:00
Biblio Bug 24827: Standardise on 'UTF-8' as the encoding name 2020-04-03 18:13:57 +00:00
BiblioUtils Bug 24827: Specify UTF-8 as encoding in new_from_xml() 2020-04-03 18:14:07 +00:00
Cache Bug 16088: Introduce Koha::Cache::Memory::Lite to cache the language 2016-06-04 07:43:22 +00:00
Cash Bug 23321: Allow setting of branch default 2019-09-23 11:39:22 +01:00
Charges Bug 24259: Handle non existing default circ rule in Charges::Fees 2020-01-03 22:23:32 +00:00
Checkouts Bug 14697: Introduce Koha::Checkouts::ReturnClaim(s) 2019-10-31 12:03:33 +00:00
Club Bug 19809: Re-allow to call Koha::Objects::find in list context 2020-02-11 19:27:34 +00:00
Config Bug 15494: (follow-up) Move yaml syspref code to its own sub in SySpref object 2018-11-07 21:39:39 +00:00
Edifact Bug 18267: Refactored Edifact Price Calculations 2020-12-09 21:24:47 +01:00
Exceptions Bug 14697: Introduce Koha::Checkouts::ReturnClaim(s) 2019-10-31 12:03:33 +00:00
Exporter Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls 2019-07-15 11:28:08 +01:00
ExternalContent Bug 21082: Update OverDrive authentication method 2018-10-09 11:04:23 +00:00
Filter/MARC Bug 25019: Make the ViewPolicy filter initialization standard 2020-05-01 17:37:54 +00:00
Illrequest Bug 23712: Silence warns from Koha/Illrequest/Logger.pm 2019-10-21 09:43:17 +01:00
Indexer Revert Bug 11081 - Port Koha::Contrib::Tamil indexer into Koha code base 2016-03-01 16:56:35 +00:00
Item Bug 18072: Add Koha objects for Branch Transfer Limit 2018-07-18 17:29:03 +00:00
Library Bug 21910: Does not deal with call context, ->search does already 2018-12-11 19:11:34 +00:00
List Bug 19524: Share patron lists between staff 2018-07-18 16:49:29 +00:00
MetadataRecord Bug 21872: Remove duplicate modulo condition in authorities iterator 2019-05-10 12:31:49 +00:00
Middleware Bug 25950: Remove <client> in X-Forwarded-For from proxy tests 2020-07-31 01:26:38 +12:00
Misc Bug 16011: $VERSION - Remove use vars qw(); 2016-03-24 17:20:39 +00:00
Notice Bug 17959 - Add the Koha::Notice::Message[s] packages (message_queue table) 2017-02-17 11:48:44 +00:00
Number Bug 18736: (follow-up) Fix missing rounding and bad formatting 2019-03-21 16:29:06 +00:00
OAI/Server Bug 24809: (QA follow-up) Add prefix to prevent disambiguity 2020-03-31 22:08:53 +00:00
Object Bug 15774: Remove unecessary returned value for ->delete 2019-03-07 20:37:06 +00:00
Objects Bug 23599: Avoid exploding in search_with_library_limits when no library is passed 2019-09-12 16:00:41 +01:00
Old Bug 21432: (bug 20899 follow-up) Fix patron's name display for deleted patrons 2018-10-03 17:18:44 +00:00
Patron Bug 24840: [19.11.x] Replace DateTime->now with dt_from_string 2020-05-07 17:17:12 +00:00
Patrons Bug 24379: Fix failing tests 2020-08-05 12:09:11 +12:00
Plugins Bug 26434: Fix plugin dirs addition to @INC 2020-10-20 14:08:32 +13:00
QueryParser/Driver Bug 20078: (QA follow-up) Correct attribute in PQF.pm 2018-11-06 12:22:54 +00:00
REST Bug 26322: [19.11.x] Permissions not checked correctly for plugins 2020-09-22 10:15:23 +12:00
RecordProcessor Bug 16011: $VERSION - Remove the $VERSION init 2016-03-24 17:20:28 +00:00
SMS Bug 15548 [QA Followup] - More new uses of Koha::Borrower 2016-03-03 14:39:00 -07:00
Schema Bug 18050: Add relation alias to schema 2020-11-17 17:52:00 +13:00
SearchEngine Bug 25273: (follow-up) Don't die on unknown authtype 2020-10-20 13:54:37 +13:00
Serial Bug 7677: QA followup 2016-09-12 09:13:57 +00:00
Sitemapper Bug 24840: [19.11.x] Replace DateTime->now with dt_from_string 2020-05-07 17:17:12 +00:00
Subscription Bug 17047: add a dedicated page for Mana setup 2019-01-23 14:39:26 +00:00
SuggestionEngine Bug 14457: (QA follow-up) Fix POD 2019-04-16 13:17:34 +00:00
Tags Bug 21846: Add Koha::Tags::Approval(s) and Koha::Tags::Index(es) 2019-03-15 12:27:44 +00:00
Template/Plugin Bug 24068: (RM follow-up) Enhance the POD 2019-11-22 14:57:46 +00:00
Util Bug 23324: (QA follow-up) Typo and remove unneeded use statement 2019-08-16 12:27:01 +01:00
XSLT Bug 23290: [RMaint version] Mitigate XML/XSLT vulnerabilities 2020-02-20 23:37:20 +00:00
Z3950Responder Bug 25277: Don't specify a field in query if none passed 2020-05-19 22:57:25 +00:00
pdfformat Bug 25507: Fix table in basket group PDF German 2-pages 2020-06-19 15:45:28 +12:00
Account.pm Bug 24542: (bug 23049 follow-up) Add missing use statement in Koha::Account 2020-02-10 23:17:17 +00:00
ActionLog.pm Bug 22363: (follow-up) Fix pod 2019-03-11 11:22:01 +00:00
ActionLogs.pm Bug 22363: (follow-up) Fix pod 2019-03-11 11:22:01 +00:00
AdditionalField.pm Bug 15774: Add POD and license notices 2019-03-07 20:37:05 +00:00
AdditionalFieldValue.pm Bug 22934: Add missing use statement 2019-05-23 14:43:16 +00:00
AdditionalFieldValues.pm Bug 15774: (follow-up) Address QA issues 2019-03-07 20:37:05 +00:00
AdditionalFields.pm Bug 15774: Add POD and license notices 2019-03-07 20:37:05 +00:00
ApiKey.pm Bug 20568: (QA follow-up) Remove unused vars 2018-05-09 12:56:00 -03:00
ApiKeys.pm Bug 20568: Add mandatory description field for api keys 2018-05-09 12:55:58 -03:00
ArticleRequest.pm Bug 23384: Fix use statement order for ArticleRequest::Status 2020-04-02 16:22:10 +00:00
ArticleRequests.pm Bug 23384: Fix use statement order for ArticleRequest::Status 2020-04-02 16:22:10 +00:00
AudioAlert.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
AudioAlerts.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
AuthUtils.pm Bug 20370: Misleading comment for bcrypt - #encrypt it; Instead it should be #hash it 2020-05-05 20:41:34 +00:00
AuthorisedValue.pm Bug 23272: Make Koha::AuthorisedValue use Koha::Object::Limit::Library 2019-09-13 08:04:05 +01:00
AuthorisedValueCategories.pm Bug 17216: Add Koha::AuthorisedValueCategory|ies classes 2016-10-11 07:30:30 +00:00
AuthorisedValueCategory.pm Bug 17216: Add Koha::AuthorisedValueCategory|ies classes 2016-10-11 07:30:30 +00:00
AuthorisedValues.pm Bug 17642: Do not explode if no authorised value exist 2016-11-18 15:52:01 +00:00
Authorities.pm Bug 9988: Add get_usage_count and linked_biblionumbers to Koha::Authority 2017-04-13 08:53:46 -04:00
Authority.pm Bug 14769: (Follow-up) Reduce number of preference parses 2018-04-12 10:50:35 -03:00
Biblio.pm Bug 25913: Prevent get_coins to crash if record does not have title 2020-10-27 17:35:41 +13:00
BiblioFramework.pm Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
BiblioFrameworks.pm Bug 14889: Fix typo in Koha/BiblioFrameworks.pm 2016-03-03 20:32:47 +00:00
BiblioUtils.pm Bug 21872: Remove duplicate modulo condition in authorities iterator 2019-05-10 12:31:49 +00:00
Biblioitem.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Biblioitems.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Biblios.pm Bug 14610 - Add and update modules 2016-10-26 12:15:13 +00:00
Cache.pm Bug 13193: Make Memcached usage fork safe 2020-03-05 23:49:57 +00:00
Caches.pm Bug 17935: Adjust some POD lines, fix a few typos 2017-02-14 14:12:50 +00:00
Calendar.pm Bug 26000: Make exception_holidays cache with branch in key 2020-08-19 17:32:57 +12:00
Checkout.pm Bug 24840: [19.11.x] Replace DateTime->now with dt_from_string 2020-05-07 17:17:12 +00:00
Checkouts.pm Bug 24840: [19.11.x] Replace DateTime->now with dt_from_string 2020-05-07 17:17:12 +00:00
CirculationRule.pm Bug 18887: Fix POD c/p issues 2018-10-03 17:58:16 +00:00
CirculationRules.pm Bug 22679: Delete related CirculationRules when Removing IssuingRule 2019-04-24 10:35:38 +00:00
Cities.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
City.pm Bug 23770: Add to_api_mapping method to Koha::City 2019-10-21 10:03:53 +01:00
ClassSortRule.pm Bug 19929: Add Koha objects for class sources and sorters 2018-03-23 11:45:38 -03:00
ClassSortRules.pm Bug 19929: (QA follow-up) Fix POD 2018-03-23 11:45:38 -03:00
ClassSource.pm Bug 19929: (QA follow-up) Fix POD 2018-03-23 11:45:38 -03:00
ClassSources.pm Bug 19929: (QA follow-up) Fix POD 2018-03-23 11:45:38 -03:00
ClassSplitRule.pm Bug 15836: Handle non-existent regexs 2018-11-13 15:18:22 +00:00
ClassSplitRules.pm Bug 15836: Add the ability to defined custom methods to split call number in labels 2018-11-13 15:18:22 +00:00
Club.pm Bug 19809: Re-allow to call Koha::Objects::find in list context 2020-02-11 19:27:34 +00:00
Clubs.pm Bug 18557 [QA Followup] - Use dt_from_string 2017-05-12 08:53:21 -04:00
Config.pm Bug 19760: Die if koha-conf is not accessible 2017-12-22 13:15:35 -03:00
CsvProfile.pm Bug 15451: Add the 2 new modules Koha::CsvProfile[s] 2016-07-22 17:18:34 +00:00
CsvProfiles.pm Bug 15451: Add the 2 new modules Koha::CsvProfile[s] 2016-07-22 17:18:34 +00:00
Database.pm Bug 26639: Add auto_savepoint to DBIC connection 2020-11-17 18:17:32 +13:00
DateUtils.pm Bug 25617: (bug 25133 follow-up) 12 PM is not 24 but 0 2020-06-12 04:01:58 +00:00
EDI.pm Bug 18267: Refactored Edifact Price Calculations 2020-12-09 21:24:47 +01:00
Edifact.pm Bug 7736: Support Ordering via Edifact EDI messages 2016-04-01 20:03:17 +00:00
Email.pm Bug 24826: Remove warnings from Sendmail 2020-05-01 17:40:24 +00:00
Exceptions.pm Bug 20590: Improve Koha::Exceptions in string context 2018-04-19 12:46:04 -03:00
ExternalContent.pm Bug 17602: Koha::ExternalContent->koha_patron() will retutn undef rather than die if user not logged in 2018-10-01 13:56:38 +00:00
FrameworkPlugin.pm Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls 2019-07-15 11:28:08 +01:00
Hold.pm Bug 25535: Hold API mapping maps cancellationdate to cancelation_date, but it should be cancellation_date 2020-05-20 21:27:17 +00:00
Holds.pm Bug 16187: Add a script to cancel unfilled holds after a specified number of days 2017-10-20 16:51:20 -03:00
I18N.pm Bug 25517: Look in all possible places for MO files 2020-06-12 01:23:06 +00:00
Illcomment.pm Bug 18591: (follow-up) Add more POD 2018-10-27 13:15:59 +00:00
Illcomments.pm Bug 18591: Fix pluralization of type 2018-10-27 15:53:34 +00:00
Illrequest.pm Bug 24840: [19.11.x] Replace DateTime->now with dt_from_string 2020-05-07 17:17:12 +00:00
Illrequestattribute.pm Bug 7317: Handle backend absense more gracefuly 2017-11-09 11:42:14 -03:00
Illrequestattributes.pm Bug 7317: QA followup 2017-11-09 11:42:14 -03:00
Illrequests.pm Bug 7317: QA followup 2017-11-09 11:42:14 -03:00
IssuingRule.pm Bug 18928: (bug 22679 follow-up) Do not remove all rules along with the issuing rule 2019-07-01 14:58:13 +01:00
IssuingRules.pm Bug 17530: (QA follow-up) Fix caching error 2018-09-07 13:16:10 +00:00
Item.pm Bug 25006: Make Koha::Item->as_marc_field skip undefined subfields 2020-04-28 20:29:28 +00:00
ItemType.pm Bug 15497: Limit itemtypes by branch in additem.pl 2019-09-12 16:31:06 +01:00
ItemTypes.pm Bug 15497: (QA follow-up) Fix call in search_with_localization 2019-09-12 16:31:06 +01:00
Items.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
KeyboardShortcut.pm Bug 21411: Advanced cataloging editor - rancor - Allow configuration of Keyboard 2019-05-10 18:59:39 +00:00
KeyboardShortcuts.pm Bug 21411: Address QA concerns 2019-05-10 18:59:39 +00:00
Libraries.pm Bug 7614: (QA follow-up) Remove unused variable 2019-01-25 16:07:07 +00:00
Library.pm Bug 23843: Add mapping to Koha::Library 2019-10-23 18:03:11 +01:00
Linktracker.pm Bug 8917 : [ Sign followup ] Track clicks to links external to Koha 2013-03-07 11:14:25 -05:00
Localization.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Localizations.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Logger.pm Bug 13937: Add a Z39.50 daemon that can inject item status MARC subfields 2019-10-08 14:39:30 +01:00
Manual.pm Bug 25576: Add link to the manual for the ILL module 2020-06-22 16:09:20 +12:00
MarcSubfieldStructure.pm Bug 17249: Remove GetKohaAuthorisedValuesFromField - Add classes MarcSubfieldStructure[s] 2016-10-21 15:13:55 +00:00
MarcSubfieldStructures.pm Bug 17249: Remove GetKohaAuthorisedValuesFromField - Add classes MarcSubfieldStructure[s] 2016-10-21 15:13:55 +00:00
MetaSearcher.pm Bug 18051: Set UTF8 Flag for record searches/imports from rancor 2020-11-17 18:12:32 +13:00
MetadataIterator.pm Bug 12478 - authorities can now be stored in ES 2016-04-26 20:20:03 +00:00
MetadataRecord.pm Bug 19096: Make Default authoritative in core modules 2017-12-07 14:44:15 -03:00
MoreUtils.pm Bug 19069: (follow-up) Remove perlcritic error 2017-10-27 14:58:16 -03:00
News.pm Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices 2016-07-08 13:47:42 +00:00
NewsItem.pm Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices 2016-07-08 13:47:42 +00:00
OAuth.pm Bug 20612: (QA follow-up) Fix typo in method POD 2018-05-09 12:56:01 -03:00
OAuthAccessToken.pm Bug 20402: Add missing POD 2018-05-08 15:55:43 -03:00
OAuthAccessTokens.pm Bug 20402: Add missing POD 2018-05-08 15:55:43 -03:00
Object.pm Bug 24788: Remove autoloaded column accessors in Koha::Object->store 2020-04-02 16:18:17 +00:00
Objects.pm Bug 19809: Re-allow to call Koha::Objects::find in list context 2020-02-11 19:27:34 +00:00
Patron.pm Bug 23634: Add is_superlibrarian method to Koha::Patron 2020-08-25 15:29:37 +12:00
Patrons.pm Bug 25683: (follow-up) Use COALESCE instead of IFNULL 2020-08-17 10:36:46 +12:00
Plugins.pm Bug 25549: Add error reporting to plugins-home 2020-11-17 17:12:45 +13:00
RDF.pm Bug 18586: Create module to mint RDF subject URIs 2018-08-09 12:11:16 +00:00
Rating.pm Bug 17089: Mark out the boundaries of ratings 2016-09-09 09:31:30 +00:00
Ratings.pm Bug 17089: Koha::Ratings - Remove GetRating 2016-09-09 09:31:29 +00:00
RecordProcessor.pm Bug 25008: Overload Koha::RecordProcessor->options to update filters 2020-05-05 20:39:04 +00:00
RefundLostItemFeeRules.pm Bug 18930: (RM follow-up) Restore primary key find 2019-07-16 13:53:54 +01:00
Report.pm Bug 17047: SQL reports management with Mana-KB 2019-01-23 14:39:26 +00:00
Reports.pm Bug 17047: SQL reports management with Mana-KB 2019-01-23 14:39:26 +00:00
Review.pm Bug 15839: Koha::Reviews - Remove approvereview & unapprovereview 2016-09-09 10:29:57 +00:00
Reviews.pm Bug 18403: Deal with the DB user 2018-02-12 15:41:42 -03:00
Schema.pm Bug 11891: (follow-up) remove custom storage class 2014-06-19 11:55:03 -03:00
Script.pm Bug 22600: Set 'commandline' interface appropriately 2019-04-10 19:43:11 +00:00
SearchEngine.pm Bug 12478: make things using SimpleSearch use the new version 2016-04-26 20:20:07 +00:00
SearchField.pm Bug 20589: Add field boosting and use query_string fields parameter 2019-10-02 13:28:57 +01:00
SearchFields.pm Bug 20589: Add field boosting and use query_string fields parameter 2019-10-02 13:28:57 +01:00
SearchMarcMap.pm Bug 12748: (QA followup) fix several tiny QA tools warnings 2016-04-26 20:20:13 +00:00
SearchMarcMaps.pm Bug 12748: (QA followup) fix several tiny QA tools warnings 2016-04-26 20:20:13 +00:00
Serial.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Serials.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
SharedContent.pm Bug 23075: (follow-up) Dissallow transparent redirects 2019-11-06 17:05:10 +00:00
SimpleMARC.pm Bug 22571: Handle control fields in MMT for conditionals 2019-06-21 13:12:46 +01:00
Sitemapper.pm Bug 11190: (QA followup) for tests on jenkins 2015-08-31 10:32:34 -03:00
StockRotationItem.pm Bug 24840: [19.11.x] Replace DateTime->now with dt_from_string 2020-05-07 17:17:12 +00:00
StockRotationItems.pm Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
StockRotationRota.pm Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
StockRotationRotas.pm Bug 22566: Fix some more issues 2019-06-25 17:01:11 +01:00
StockRotationStage.pm Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
StockRotationStages.pm Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
Subscription.pm Bug 19809: Re-allow to call Koha::Objects::find in list context 2020-02-11 19:27:34 +00:00
Subscriptions.pm Bug 15774: Use Koha::Object(s) for additional fields 2019-03-07 20:37:05 +00:00
Suggestion.pm Bug 13012 - suggestion.suggesteddate should be set to NOW if not defined 2017-08-10 16:25:34 -03:00
SuggestionEngine.pm Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Suggestions.pm Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices 2016-07-08 13:47:42 +00:00
Tag.pm Bug 21846: Add Koha::Tags::Approval(s) and Koha::Tags::Index(es) 2019-03-15 12:27:44 +00:00
Tags.pm Bug 21846: Add Koha::Tags::Approval(s) and Koha::Tags::Index(es) 2019-03-15 12:27:44 +00:00
Token.pm Bug 21998: Throw exception on bad pattern 2019-03-22 20:21:44 +00:00
UploadedFile.pm Bug 20727: (QA follow-up) Fix Upload.t and Plugins.t 2018-06-22 16:10:10 +00:00
UploadedFiles.pm Bug 18300: [QA Follow-up] Fix return value inconsistency 2017-04-21 00:11:40 +00:00
Uploader.pm Bug 19633: Use alphanumeric error codes in upload 2018-08-10 10:10:46 +00:00
Virtualshelf.pm Bug 18672: Fix overwriting creation date with modification date when editing list 2017-07-17 13:19:24 -03:00
Virtualshelfcontent.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Virtualshelfcontents.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Virtualshelfshare.pm Bug 11943: Prevent double accepts in Koha::Virtualshelfshare 2018-05-11 10:52:43 -03:00
Virtualshelfshares.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Virtualshelves.pm Bug 21612: Remove incorrect GROUP BY's from Koha::VirtualShelves 2018-10-26 16:31:25 +00:00
XSLT_Handler.pm Bug 23290: [RMaint version] Mitigate XML/XSLT vulnerabilities 2020-02-20 23:37:20 +00:00
Z3950Responder.pm Bug 13937: (RM follow-up) Set working directory for daemon mode. 2019-10-15 13:48:28 +01:00
Z3950Server.pm Bug 20047: Add Koha::Z3950Server Oject and use it to get server count 2018-04-20 13:34:41 -03:00
Z3950Servers.pm Bug 20047: Add Koha::Z3950Server Oject and use it to get server count 2018-04-20 13:34:41 -03:00