gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 25019: Make the ViewPolicy filter initialization standard 

This patch makes the ViewPolicy filter use the 'params' accessor instead
of relying of ->{options} which has no accessor. This will allow
interacting with the filter object be similar through all the filters in
the chain.

To test, we just need to verify no behaviour change takes place:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Filter_MARC_ViewPolicy.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests still pass!
4. Sign off :-D

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
This commit is contained in:
Tomas Cohen Arazi 2020-03-30 09:39:13 -03:00 committed by Joy Nelson
parent d1cb5f562e
commit e6c829d887
1 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Koha/Filter/MARC/ViewPolicy.pm
View File

@ -78,10 +78,12 @@ sub filter {
push @records, $precord;
}
my $params = $self->params;
my $interface = $params->{options}->{interface} // 'opac';
my $frameworkcode = $params->{options}->{frameworkcode} // q{};
foreach my $current_record (@records) {
my $result = $current_record;
my $interface = $self->{options}->{interface} // 'opac';
my $frameworkcode = $self->{options}->{frameworkcode} // q{};
my $hide = _should_hide_on_interface();
my $marcsubfieldstructure = GetMarcStructure( 0, $frameworkcode, { unsafe => 1 } );
@ -153,16 +155,6 @@ sub _filter_field {
return;
}
sub initialize {
my $self = shift;
my $param = shift;
my $options = $param->{options};
$self->{options} = $options;
$self->Koha::RecordProcessor::Base::initialize($param);
return;
}
# Copied and modified from 3.10.x help file
# marc_subfields_structure.hidden
# allows you to select from 19 possible visibility conditions, 17 of which are implemented. They are the following: