gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 23272: Make Koha::AuthorisedValue use Koha::Object::Limit::Library 

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Tomas Cohen Arazi 2019-07-05 16:23:52 -03:00 committed by Martin Renvoize
parent 55f56c09dd
commit 95ab03b73a
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
1 changed files with 16 additions and 113 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

129
Koha/AuthorisedValue.pm
View File

@ -23,7 +23,7 @@ use Carp;
use Koha::Database;
use base qw(Koha::Object);
use base qw(Koha::Object Koha::Object::Limit::Library);
=head1 NAME
@ -31,106 +31,10 @@ Koha::AuthorisedValue - Koha Authorised value Object class
=head1 API
=head2 Class Methods
=head2 Class methods
=cut
=head3 branch_limitations
my $limitations = $av->branch_limitations();
$av->branch_limitations( \@branchcodes );
=cut
sub branch_limitations {
my ( $self, $branchcodes ) = @_;
if ($branchcodes) {
return $self->replace_branch_limitations($branchcodes);
}
else {
return $self->get_branch_limitations();
}
}
=head3 get_branch_limitations
my $limitations = $av->get_branch_limitations();
=cut
sub get_branch_limitations {
my ($self) = @_;
my @branchcodes =
$self->_avb_resultset->search( { av_id => $self->id() } )
->get_column('branchcode')->all();
return \@branchcodes;
}
=head3 add_branch_limitation
$av->add_branch_limitation( $branchcode );
=cut
sub add_branch_limitation {
my ( $self, $branchcode ) = @_;
croak("No branchcode passed in!") unless $branchcode;
my $limitation = $self->_avb_resultset->update_or_create(
{ av_id => $self->id(), branchcode => $branchcode } );
return $limitation ? 1 : undef;
}
=head3 del_branch_limitation
$av->del_branch_limitation( $branchcode );
=cut
sub del_branch_limitation {
my ( $self, $branchcode ) = @_;
croak("No branchcode passed in!") unless $branchcode;
my $limitation =
$self->_avb_resultset->find(
{ av_id => $self->id(), branchcode => $branchcode } );
unless ($limitation) {
my $id = $self->id();
carp(
"No branch limit for branch $branchcode found for av_id $id to delete!"
);
return;
}
return $limitation->delete();
}
=head3 replace_branch_limitations
$av->replace_branch_limitations( \@branchcodes );
=cut
sub replace_branch_limitations {
my ( $self, $branchcodes ) = @_;
$self->_avb_resultset->search( { av_id => $self->id() } )->delete();
my @return_values =
map { $self->add_branch_limitation($_) } @$branchcodes;
return \@return_values;
}
=head3 opac_description
my $description = $av->opac_description();
@ -143,22 +47,9 @@ sub opac_description {
return $self->lib_opac() || $self->lib();
}
=head3 _avb_resultset
=head2 Internal methods
Returns the internal resultset or creates it if undefined
=cut
sub _avb_resultset {
my ($self) = @_;
$self->{_avb_resultset} ||=
Koha::Database->new()->schema()->resultset('AuthorisedValuesBranch');
$self->{_avb_resultset};
}
=head3 type
=head3 _type
=cut
@ -166,6 +57,18 @@ sub _type {
return 'AuthorisedValue';
}
=head3 _library_limits
=cut
sub _library_limits {
return {
class => 'AuthorisedValuesBranch',
id => 'av_id',
library => 'branchcode'
};
}
=head1 AUTHOR
Kyle M Hall <kyle@bywatersolutions.com>