gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/C4
History
David Cook 92ed47e182
Bug 39295: Prevent infinite loop on line wrapping 
This change checks that the string width is larger than 0 before
attempting to perform line wrapping on the line.

Test plan:
0. Apply the patch and koha-plack --restart kohadev
1. Follow instructions at end of this message[1]
2. Note that the infinite loop does not happen and that a blank
card is created
3. Export the batch using the test layout and template that come
with koha-testing-docker
4. Note that the patron card is correctly created

[1]
To reproduce:

0. Change Koha test user's firstnameto "Firstname" and surname to "Lastname"

1. Create a template:
Units: PostScript Points
Page height: 60pt
Page width: 60pt
Card height: 60pt
Card with: 60pt

Top page margin: 10pt
Left page margin: 10pt
Number of columns: 1
Number of rows: 1
Gap between columns: 10pt
Gap between rows: 10pt

2. Create a layout:
Units: US inches

Field 1:
Text: Library Name
Font: Times-Roman
Font size: 12 pt
Text alignment: Left
Lower left X coordinate: 100in
Lower left Y coordinate: 100in

Field 2:
Text: <firstname> <surname>
Font: Times-Roman
Font size: 10pt
Text alignment: Left
Lower left X coordinate: 5in
Lower left Y coordinate: 5in

3. Create a batch for borrowernumber 51 (if using "koha" test user in ktd)

4. Export using the above template and layout

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
 		2025-07-23 16:15:50 -04:00
..
AuthoritiesMarc
…
Barcodes
…
ClassSortRoutine
…
ClassSplitRoutine
…
Creators Bug 37720: Prevent XSS in label creator 2024-10-01 13:42:28 +00:00
External
…
Form Bug 30318: Don't reset messaging preferences when form is empty 2024-04-26 08:52:51 +02:00
Heading Bug 36917: (follow-up) Remove Elasticsearch warnings and tidy 2024-05-24 15:36:42 +02:00
ILSDI Bug 38233: respect OPAC visibility for ILS-DI GetRecords 2024-12-05 18:10:41 +00:00
Installer
…
Labels Bug 33339: Prevent Formula Injection (CSV Injection) in CSV files 2024-11-07 23:02:54 +00:00
Linker Bug 35125: Respect LinkerConsiderThesaurus in update_cache 2024-10-25 21:35:48 +00:00
Members Bug 33239: Add the ability to run borrowers-force-messaging-defaults.pl only on a specified message name 2023-10-11 10:31:46 -03:00
OAI
…
Output
…
Patroncards Bug 39295: Prevent infinite loop on line wrapping 2025-07-23 16:15:50 -04:00
Reports Bug 37784: [24.05] Do not show forbidden columns in reports dictionary 2025-03-21 01:41:33 +00:00
SIP Bug 38486: [24.05.x] For SIP allow noblock checkouts reguardless of normal patron checkout blocks 2025-03-20 20:27:47 +00:00
Search
…
Serials
…
Utils/DataTables Bug 34913: Fix perlcritic for VirtualShelves.pm 2024-01-29 12:24:54 +01:00
Accounts.pm
…
Acquisition.pm Bug 33339: Prevent Formula Injection (CSV Injection) in CSV files 2024-11-07 23:02:54 +00:00
Auth.pm Bug 38826: Make check_api_auth $sessionID consistent 2025-03-20 02:56:04 +00:00
Auth_cas_servers.yaml.sample
…
Auth_with_cas.pm Bug 34893: (QA follow-up) Tidy code for qa script 2024-02-02 17:31:47 +01:00
Auth_with_ldap.pm Bug 36822: LDAP - Add discard_changes 2024-11-15 16:12:30 +00:00
Auth_with_shibboleth.pm Bug 36822: Shibboleth - Add discard_changes 2024-11-15 16:12:29 +00:00
AuthoritiesMarc.pm Bug 33348: (follow-up) Fix if no 008 defined 2024-12-05 22:12:00 +00:00
Barcodes.pm Bug 37070: (QA follow-up) Fix qa script issues 2024-11-18 23:24:53 +00:00
Biblio.pm Bug 30648: Tidy 2024-12-05 16:47:04 +00:00
Breeding.pm Bug 28166: (QA follow-up) Fix and tidy tests and code 2023-10-23 11:33:50 -03:00
Budgets.pm Bug 31631: Optionally use tax-exclusive values for calculating fund values 2023-10-18 15:41:35 -03:00
Calendar.pm Bug 32048: Added clear cache routine to delete_holiday_range_repeatable 2023-09-18 15:31:50 -03:00
Charset.pm
…
Circulation.pm Bug 37505: (QA follow-up) Don't log return stat if ignore_localuse and no checkout 2024-11-19 15:59:42 +00:00
ClassSortRoutine.pm
…
ClassSource.pm
…
ClassSplitRoutine.pm
…
Context.pm Bug 36081: Use multivalue_preference 2025-02-24 20:43:45 +00:00
Contract.pm
…
CourseReserves.pm
…
Creators.pm
…
HTML5Media.pm
…
Heading.pm Bug 38483: C4::Heading::preferred_authorities is not used 2025-03-20 21:00:37 +00:00
HoldsQueue.pm Bug 38126: Skip allocated holds when filling from transport cost matrix 2024-10-25 21:27:10 +00:00
ImportBatch.pm Bug 35438: Remove skip_intermediate_commit parameter 2024-01-16 12:06:08 +01:00
ImportExportFramework.pm Bug 37606: Fix framework export module to escape double quotes 2024-11-19 15:55:13 +00:00
InstallAuth.pm Bug 36102: Fix expired session on the login page of the installer (?) 2024-03-01 11:00:35 +01:00
Installer.pm Bug 34174: (bug 33341 follow-up) Fix Ris export 2023-07-06 12:24:12 -03:00
ItemCirculationAlertPreference.pm
…
Items.pm Bug 37550: CheckItemPreSave should run barcodes through barcodedecode 2024-12-05 21:50:39 +00:00
Koha.pm Bug 36750: Use the same label for Zebra 2024-05-07 17:41:19 +02:00
Labels.pm
…
Languages.pm Bug 35582: Supress possible warning 2024-04-29 18:53:13 +02:00
Letters.pm Bug 39184: Turn off ABSOLUTE and EVAL_PERL for user-entered templates 2025-05-21 01:20:21 +00:00
Linker.pm
…
Log.pm Bug 25159: (QA follow-up) Tidy changes 2024-05-02 16:47:44 +02:00
MarcModificationTemplates.pm
…
Matcher.pm Bug 26611: Make authority record matching use required match checks 2023-05-24 11:21:31 -03:00
Members.pm Bug 26170: Add protected status for patrons 2023-11-01 17:23:06 -03:00
Message.pm
…
Output.pm Bug 34478: Remove check_csrf from pl files 2024-03-01 10:56:01 +01:00
Overdues.pm Bug 38303: Set item's replacement price to defaultreplacecost if 0.00 2024-12-05 21:18:46 +00:00
Patroncards.pm
…
Record.pm Bug 33339: Prevent Formula Injection (CSV Injection) in CSV files 2024-11-07 23:02:54 +00:00
Reports.pm
…
Reserves.pm Bug 38531: add diff when reverting hold 2025-03-20 02:13:06 +00:00
Ris.pm Bug 33431: Fix remaining cases 2024-03-18 11:03:39 +01:00
RotatingCollections.pm Bug 31735: Avoid re-fetcing objects from database by passing them directly instead of ids to various subroutines 2023-05-12 12:40:21 -03:00
SMS.pm Bug 36051: (QA follow-up): Use yaml_preference 2024-04-12 11:26:12 +02:00
Scheduler.pm
…
Scrubber.pm Bug 36328: (QA follow-up) Expand tests and reorder elements to clarify differences 2024-04-22 12:39:20 +02:00
Search.pm Bug 35138: Add the ability to manage ES facets 2024-04-30 12:00:56 +02:00
Serials.pm Bug 38829: Sanitize GetLateOrMissingIssues inputs 2025-02-03 23:20:25 +00:00
Service.pm
…
ShelfBrowser.pm
…
SocialData.pm Bug 33833: Add two FIXMEs to SocialData::get_report 2023-09-05 14:35:35 -03:00
Stats.pm Bug 33608: (QA follow-up) Remove ->insert method 2023-10-25 11:07:59 -03:00
Suggestions.pm Bug 33236: (follow-up) Remove export of NewSuggestion 2023-06-06 10:08:36 -03:00
TTParser.pm Bug 36171: Fix template toolkit tags split by HTML parser 2024-11-20 18:42:06 +00:00
Tags.pm Bug 36785: Typo unreconized and bilbio in tags code 2024-05-17 10:36:35 +02:00
Templates.pm Bug 38467: Make uri and url filters rfc3986 when using C4::Template 2025-02-10 02:50:12 +00:00
TmplToken.pm
…
TmplTokenType.pm
…
UsageStats.pm Bug 26176: (QA follow-up) Branch -> Library 2024-05-23 17:51:18 +02:00
XISBN.pm
…
XSLT.pm Bug 38100: (QA follow-up) Tidy changes in C4/XSLT.pm 2024-12-05 22:09:46 +00:00