gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 37070: (QA follow-up) Fix qa script issues 

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit bfe67da62d)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Kyle M Hall 2024-10-04 13:00:26 -04:00 committed by Lucas Gass
parent 0cc899ac3d
commit 580cf78aff
2 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
C4/Barcodes.pm
View File

@ -94,11 +94,12 @@ sub max {
return $self->db_max;
}
sub db_max {
my $self = shift;
my $query = "SELECT max(abs(CAST(barcode AS UNSIGNED))) FROM items LIMIT 1"; # Possible problem if multiple barcode types populated
my $sth = C4::Context->dbh->prepare($query);
$sth->execute();
return $sth->fetchrow_array || $self->initial;
my $self = shift;
my $query = "SELECT max(abs(CAST(barcode AS UNSIGNED))) FROM items LIMIT 1"
; # Possible problem if multiple barcode types populated
my $sth = C4::Context->dbh->prepare($query);
$sth->execute();
return $sth->fetchrow_array || $self->initial;
}
sub next_value {
my $self = shift;

6
t/db_dependent/Barcodes.t
View File

@ -141,11 +141,7 @@ subtest 'Test generation of incremental barcodes from DB values' => sub {
$builder->schema->resultset('Item')->delete_all;
my $barcodeobj;
my $item_1 = $builder->build_sample_item(
{
barcode => '1000000000000000'
}
);
my $item_1 = $builder->build_sample_item( { barcode => '1000000000000000' } );
$barcodeobj = C4::Barcodes->new('incremental');