gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 33833: Add two FIXMEs to SocialData::get_report 

Just comments, no test plan.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Marcel de Rooy 2023-05-22 08:46:31 +00:00 committed by Tomas Cohen Arazi
parent 69967feeaa
commit a6c67ada11
No known key found for this signature in database
GPG Key ID: 0A272EA1B2F3C15F
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
C4/SocialData.pm
View File

@ -120,7 +120,7 @@ sub get_report {
my $sth = $dbh->prepare( qq{
SELECT biblionumber, isbn FROM biblioitems
} );
} ); # FIXME We could better join socialdata here than call get_data for each record?
$sth->execute;
my %results;
while ( my ( $biblionumber, $isbn ) = $sth->fetchrow() ) {
@ -135,7 +135,7 @@ sub get_report {
};
next if $@;
$isbn =~ s/-//g;
my $social_datas = C4::SocialData::get_data( $isbn );
my $social_datas = C4::SocialData::get_data( $isbn ); # FIXME Why is data not included in $results ?
if ( $social_datas ) {
push @{ $results{with} }, { biblionumber => $biblionumber, isbn => $isbn, original => $original_isbn };
} else {