gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
57,898 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Kyle M Hall 94286343c7
Bug 39532: Script debar_patrons_with_fines.pl creates repeat restrictions, uses wrong restriction type 
The cronjob debar_patrons_with_fines.pl is meant to add a restriction based on a fines threshold.

The problem is that the script adds a MANUAL restriction, which makes no sense. MANUAL restrictions are meant to be manually created, never automatic as this script does.
In addition, they are repeatable, not unique. Every time this script runs, it will add an additional restriction.

There is already a restriction type meant for this type of use case: SUSPENSION
We should change this script to create SUSPENSION restrictions instead of MANUAL restrictions.

In summary, this script should use the unique restriction type SUSPENSION to prevent multiple additional restrictions from being created on each run.

Test Plan:
1) Set up a patron with fines
2) Run misc/cronjobs/debar_patrons_with_fines.pl -c -m "Test message"
3) Note the restriction is created
4) Run misc/cronjobs/debar_patrons_with_fines.pl -c -m "Test message" again
5) Note another restriction is created
6) Delete the restrictions
7) Apply this patch
8) Run misc/cronjobs/debar_patrons_with_fines.pl -c -m "Test message"
9) Note the restriction is created
10) Run misc/cronjobs/debar_patrons_with_fines.pl -c -m "Test message" again
11) Note another restriction is *not* created!

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
 		2025-05-13 18:47:02 +02:00
C4 Bug 39842: Populate current location for SIP item with holdingbranch 2025-05-09 09:12:05 +02:00
Koha Bug 39503: Collapse thesaurus if value in 008_/11 = 'z' and 040 $f 2025-05-13 18:47:00 +02:00
acqui Bug 38010: (QA follow-up) Move syspref values to config endpoint 2025-05-02 17:19:26 +02:00
admin Bug 39878: EDIFACT vendor account records sets default port incorrectly for FTP 2025-05-13 18:46:58 +02:00
api Bug 39771: Make `data` attribute nullable for jobs 2025-05-09 09:12:06 +02:00
authorities Bug 39560: For authorities hidden fields (but present in the record) will be lost when editing and saving such a record 2025-05-12 18:31:14 +02:00
basket Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
bin
…
bookings Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
catalogue Bug 39325: Manual fixes 2025-04-28 18:51:23 +02:00
cataloguing Bug 39325: Manual fixes 2025-04-28 18:51:23 +02:00
circ Bug 39604: Remember cancelreserve choice when remembering patron for session 2025-05-13 18:47:00 +02:00
clubs Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
course_reserves Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
debian Bug 38010: (QA follow-up) Add new apache redirect 2025-05-02 17:19:18 +02:00
docs Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
erm Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
errors Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
etc Bug 39303: Add audience index to SRU 2025-04-25 08:47:14 +02:00
ill Bug 30200: Add custom tabs to View ILL requests page 2025-05-08 08:49:57 +02:00
installer Bug 39618: (QA follow-up) add prefix length to index key 2025-05-12 18:31:12 +02:00
koha-tmpl Bug 39494: Announce status messaging on login page 2025-05-13 18:47:01 +02:00
labels Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
lib Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
members Bug 38532: (follow-up) Use Koha::Patron->account methods 2025-05-08 07:59:08 +02:00
misc Bug 39532: Script debar_patrons_with_fines.pl creates repeat restrictions, uses wrong restriction type 2025-05-13 18:47:02 +02:00
offline_circ Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac Bug 39148: Correct sort by publicationdate in OPAC lists 2025-05-12 18:31:23 +02:00
patron_lists Bug 37266: patron_lists/delete.pl should have CSRF protection 2025-03-06 13:54:49 +01:00
patroncards Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
plugins Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
pos Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
preservation Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
recalls Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
reports Bug 39325: Tidy 2025-04-28 18:51:27 +02:00
reserve Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
reviews Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
rotating_collections Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
serials Bug 34971: (QA follow-up) Op is now cud-reopen 2025-02-12 15:28:17 +01:00
services Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
skel
…
suggestion Bug 39325: manual - suggestion - no one => no_one 2025-04-28 18:51:25 +02:00
svc Bug 39325: Manual fixes 2025-04-28 18:51:23 +02:00
t Bug 39503: Unit tests 2025-05-13 18:46:59 +02:00
tags Bug 38969: (QA follow-up) fix tidy 2025-04-28 18:51:18 +02:00
tools Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
virtualshelves Bug 37434: Sort by publicationyear when copyrightdate is set in UNIMARC 2025-02-13 16:18:02 +01:00
xt Bug 39741: Make valid-templates.t handle dirs 2025-05-06 18:48:27 +02:00
.codespell-ignore Bug 39325: (QA follow-up) Adjust some issues 2025-04-28 18:51:30 +02:00
.editorconfig
…
.git-blame-ignore-revs Bug 39096: Add 'tidy all' commits to a git blame ignore file 2025-02-17 13:10:25 +01:00
.gitignore Bug 30200: Add custom tabs to View ILL requests page 2025-05-08 08:49:57 +02:00
.htaccess
…
.mailmap Bug 39447: Update mailmap to reflect PTFS-Europes rename 2025-03-26 12:28:44 +01:00
.perlcriticrc
…
.perltidyrc Bug 30002: Adjust perltidy 2023-06-08 08:32:42 -03:00
.prettierrc.js Bug 38664: Treat .vue files like other JS files 2025-02-11 14:58:25 +01:00
.proverc.dist
…
.stylelintrc.json Bug 31528: (follow-up) A few additional rules 2022-10-03 08:23:15 -03:00
INSTALL
…
Koha.pm Bug 39452: DBRev 24.12.00.042 2025-05-09 09:12:13 +02:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 39623: Remove "install" target's dependency on "all" target 2025-05-09 09:12:12 +02:00
README
…
README.md
…
README.robots
…
about.pl Bug 39154: Add sip.log test in about 2025-03-07 18:02:58 +01:00
app.psgi Bug 36149: Add userenv middleware to app.psgi 2024-05-14 15:04:37 -03:00
build-resources.PL Bug 32609: Use the current yarn.lock to generate node_modules 2023-02-10 11:07:57 -03:00
changelanguage.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
cpanfile Bug 39367: Add new dependency 2025-04-23 09:35:16 +02:00
cypress.config.ts Bug 38770: Remove @vue/cli-service and babel 2025-01-16 15:56:15 +01:00
eslint.config.mjs Bug 38524: Enable ESLint for .ts and .vue files 2025-01-16 15:56:17 +01:00
fix-perl-path.PL Bug 39325: (QA follow-up) Adjust some issues 2025-04-28 18:51:30 +02:00
gulpfile.js Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
help.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
kohaversion.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
mainpage.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
package.json Bug 37911: (follow-up) Reintroduce @koha-community/prettier-plugin-template-toolkit 2025-04-28 11:13:45 +02:00
rewrite-config.PL Bug 39149: Tidy .PL files 2025-02-18 15:35:53 +01:00
rspack.config.js Bug 38010: (QA follow-up) Rebase on main 2025-05-02 17:19:15 +02:00
tsconfig.json Bug 32030: Move cypress to t - fix build_js/watch_js 2022-11-08 09:44:52 -03:00
yarn.lock Bug 37911: Update yarn.lock 2025-04-28 11:13:46 +02:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo