gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 39325: Manual fixes 

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Jonathan Druart 2025-03-19 16:28:58 +01:00 committed by Katrin Fischer
parent 1d844a7d2f
commit 69b8341a8c
No known key found for this signature in database
GPG Key ID: 0EF6E2C03357A834
73 changed files with 183 additions and 183 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
C4/Auth.pm
View File

@ -1032,7 +1032,7 @@ sub checkauth {
if ($logout) {
# voluntary logout the user
# check FIXME CODESPELL (wether ==> weather, whether) the user was using their shibboleth session or a local one
# check whether the user was using their shibboleth session or a local one
my $shibSuccess = C4::Context->userenv ? C4::Context->userenv->{'shibboleth'} : undef;
if ($session) {
$session->delete();

2
C4/Biblio.pm
View File

@ -2303,7 +2303,7 @@ sub TransformHtmlToMarc {
$newfield = 0;
my $j = $i + 2;
if ( $tag < 10 ) { # no code for FIXME CODESPELL (theses ==> these, thesis) fields
if ( $tag < 10 ) { # no code for this field
# in MARC editor, 000 contains the leader.
next if $tag == $biblionumbertagfield;
my $fval = $cgi->param( $params[ $j + 1 ] );

6
C4/Circulation.pm
View File

@ -1574,8 +1574,8 @@ AddIssue does the following things :
- fill recall if recall to this patron
- cancel recall or not
- revert recall's waiting status or not
* FIXME CODESPELL (TRANSFERT ==> TRANSFER, TRANSFERRED) PENDING ?
- complete the FIXME CODESPELL (transfert ==> transfer, transferred)
* TRANSFER PENDING ?
- complete the transfer
* ISSUE THE BOOK
=back
@ -1704,7 +1704,7 @@ sub AddIssue {
C4::Reserves::MoveReserve( $item_object->itemnumber, $patron->borrowernumber, $cancelreserve );
# Starting process for transfer job (checking FIXME CODESPELL (transfert ==> transfer, transferred) and validate it if we have one)
# Starting process for transfer job (checking transfer and validate it if we have one)
if ( my $transfer = $item_object->get_transfer ) {
# updating line of branchtranfert to finish it, and changing the to branch value, implement a comment for visibility of this case (maybe for stats ....)

2
C4/Form/MessagingPreferences.pm
View File

@ -156,7 +156,7 @@ PREF: foreach my $option (@$messaging_options) {
=item Handle when form input is invalid
=item Generalize into a system of form handler FIXME CODESPELL (clases ==> classes, clashes, cases)
=item Generalize into a system of form handler classes
=back

2
C4/Record.pm
View File

@ -264,7 +264,7 @@ sub marc2dcxml {
my ( $marcxml, $record, $output );
# set the default path for intranet xslts
# FIXME CODESPELL (differents ==> different, difference) xslts to process (OAIDC, SRWDC and RDFDC)
# different xslts to process (OAIDC, SRWDC and RDFDC)
my $xsl =
C4::Context->config('intrahtdocs')
. '/prog/en/xslt/'

4
C4/Reports/Guided.pm
View File

@ -307,8 +307,8 @@ sub _build_query {
my @definitions = split( ',', $definition );
my $deftext;
foreach my $def (@definitions) {
my $define = get_from_dictionary( '', $def );
$deftext .= " " . $defin->[0]->{'saved_sql'};
my $report = get_from_dictionary( '', $def );
$deftext .= " " . $report->[0]->{'saved_sql'};
}
if ( $query =~ /WHERE/i ) {
$query .= $deftext;

2
C4/Reserves.pm
View File

@ -59,7 +59,7 @@ C4::Reserves - Koha functions for dealing with reservation.
=head1 DESCRIPTION
This modules provides FIXME CODESPELL (somes ==> some, sums) functions to deal with reservations.
This modules provides some functions to deal with reservations.
Reserves are stored in reserves table.
The following columns contains important values :

12
C4/SIP/SIPServer.pm
View File

@ -55,13 +55,13 @@ my %transports = (
# Read configuration
#
my $config = C4::SIP::Sip::Configuration->new( $ARGV[0] );
my @FIXME CODESPELL (parms ==> params, prams);
my @params;
#
# Ports to bind
#
foreach my $svc ( keys %{ $config->{listeners} } ) {
push @FIXME CODESPELL (parms ==> params, prams), "port=" . $svc;
push @params, "port=" . $svc;
}
#
@ -81,17 +81,17 @@ foreach my $svc ( keys %{ $config->{listeners} } ) {
#
if ( defined( $config->{'server-params'} ) ) {
while ( my ( $key, $val ) = each %{ $config->{'server-params'} } ) {
push @FIXME CODESPELL (parms ==> params, prams), $key . '=' . $val;
push @params, $key . '=' . $val;
}
}
# Add user and group to prevent warn from Net::Server.
push @FIXME CODESPELL (parms ==> params, prams), 'user=' . $>;
push @FIXME CODESPELL (parms ==> params, prams), 'group=' . $>;
push @params, 'user=' . $>;
push @params, 'group=' . $>;
#
# This is the main event.
__PACKAGE__->run(@FIXME CODESPELL (parms ==> params, prams));
__PACKAGE__->run(@params);
#
# Server

2
Koha/Biblio.pm
View File

@ -520,7 +520,7 @@ sub pickup_locations {
my $bool = $biblio->hidden_in_opac({ [ rules => $rules ] })
Returns true if the biblio matches the FIXME CODESPELL (hidding ==> hiding, hidden) criteria defined in $rules.
Returns true if the biblio matches the hiding criteria defined in $rules.
Returns false otherwise. It involves the I<OpacHiddenItems> and
I<OpacHiddenItemsHidesRecord> system preferences.

2
Koha/Edifact/Line.pm
View File

@ -778,7 +778,7 @@ sub pri_price {
return;
}
# unit price that will be FIXME CODESPELL (chaged ==> changed, charged) excl tax
# unit price that will be charged excl tax
sub price_net {
my $self = shift;

2
Koha/Edifact/Order.pm
View File

@ -776,7 +776,7 @@ Make handling of GIR segments more customizable
pass the string 'new'.
In practice we encode 1 message per transmission so there is only one message
referenced. were we to encode multiple messages a new reference would be
FIXME CODESPELL (neaded ==> needed, kneaded, headed) for each
needed for each
=head2 message_header

6
Koha/Filter/MARC/ViewPolicy.pm
View File

@ -232,9 +232,9 @@ nothing is passed. Valid values include 'opac' or 'intranet'.
=cut
sub should_hide_marc {
my ( $self, $FIXME CODESPELL (parms ==> params, prams) ) = @_;
my $frameworkcode = $parms->{frameworkcode} // q{};
my $interface = $parms->{interface} // 'opac';
my ( $self, $params ) = @_;
my $frameworkcode = $params->{frameworkcode} // q{};
my $interface = $params->{interface} // 'opac';
my $hide = _should_hide_on_interface();
my %shouldhidemarc;

2
Koha/Item.pm
View File

@ -935,7 +935,7 @@ sub can_article_request {
my $bool = $item->hidden_in_opac({ [ rules => $rules ] })
Returns true if item fields match the FIXME CODESPELL (hidding ==> hiding, hidden) criteria defined in $rules.
Returns true if item fields match the hiding criteria defined in $rules.
Returns false otherwise.
Takes HASHref that can have the following parameters:

6
Koha/Misc/Files.pm
View File

@ -52,7 +52,7 @@ from this table. However, this method does accept an arbitrary
string as 'tabletag', and an arbitrary integer as 'recordid'.
Particular Koha::Misc::Files object can have one or more file records
(FIXME CODESPELL (actuall ==> actually, actual) file contents + various file metadata) associated with it.
(actual file contents + various file metadata) associated with it.
In case of an error (wrong parameter format) it returns undef.
@ -150,7 +150,7 @@ my $file = $mf->GetFile( id => $file_id );
For an individual, specific file ID this method returns a hashref
containing all metadata (file_id, table_tag, record_id, file_name,
file_type, file_description, file_content, date_uploaded), plus
an FIXME CODESPELL (actuall ==> actually, actual) contents of a file (in 'file_content'). In typical usage
an actually contents of a file (in 'file_content'). In typical usage
scenarios, for a given $mf object, specific file IDs have to be
obtained first by GetFilesInfo() call.
@ -218,7 +218,7 @@ sub DelAllFiles {
$mf->MergeFileRecIds(@ids_to_be_merged);
This method re-associates all FIXME CODESPELL (individuall ==> individually, individual) file records associated with
This method re-associates all individual file records associated with
some "parent" records IDs (provided in @ids_to_be_merged) with the given
single $mf object (which would be treated as a "parent" destination).

4
Koha/Patrons/Import.pm
View File

@ -768,9 +768,9 @@ sub format_dates {
my ( $self, $params ) = @_;
foreach my $date_type (qw(dateofbirth dateenrolled dateexpiry date_renewed)) {
my $template = $params->{borrower}->{$date_type} or next();
my $tmp_date = $params->{borrower}->{$date_type} or next();
my $formatted_date =
eval { output_pref( { dt => dt_from_string($template), dateonly => 1, dateformat => 'iso' } ); };
eval { output_pref( { dt => dt_from_string($tmp_date), dateonly => 1, dateformat => 'iso' } ); };
if ($formatted_date) {
$params->{borrower}->{$date_type} = $formatted_date;

2
Koha/Plugins/Base.pm
View File

@ -359,7 +359,7 @@ sub _version_compare {
=head2 is_enabled
Method that returns FIXME CODESPELL (wether ==> weather, whether) the plugin is enabled or not
Method that returns whether the plugin is enabled or not
$plugin->enable

2
Koha/Schema/Result/ClubHold.pm
View File

@ -51,7 +51,7 @@ id for the bibliographic record the hold has been placed against
is_foreign_key: 1
is_nullable: 1
If item-level, the id for the item the hold has been placed FIXME CODESPELL (agains ==> against, again)
If item-level, the id for the item the hold has been placed against
=head2 date_created

2
Koha/Schema/Result/Deleteditem.pm
View File

@ -383,7 +383,7 @@ inventory number (MARC21 952$i)
is_nullable: 1
size: 32
'new' value, you can put whatever free-text information. This field is FIXME CODESPELL (intented ==> intended, indented) to be managed by the automatic_item_modification_by_age cronjob.
'new' value, you can put whatever free-text information. This field is intended to be managed by the automatic_item_modification_by_age cronjob.
=head2 exclude_from_local_holds_priority

2
Koha/Schema/Result/Item.pm
View File

@ -387,7 +387,7 @@ inventory number (MARC21 952$i)
is_nullable: 1
size: 32
'new' value, you can put whatever free-text information. This field is FIXME CODESPELL (intented ==> intended, indented) to be managed by the automatic_item_modification_by_age cronjob.
'new' value, you can put whatever free-text information. This field is intended to be managed by the automatic_item_modification_by_age cronjob.
=head2 exclude_from_local_holds_priority

2
Koha/SearchEngine/Elasticsearch/Indexer.pm
View File

@ -255,7 +255,7 @@ sub index_status {
Generate Elasticsearch mappings from mappings stored in database and
perform a request to update Elasticsearch index mappings. Will throw an
error and set index status to C<INDEX_STATUS_RECREATE_REQUIRED> if update
fails.
failed.
=cut

2
acqui/booksellers.pl
View File

@ -28,7 +28,7 @@ booksellers.pl
=head1 DESCRIPTION
this script displays the list of suppliers & baskets like C<$supplier> given on input arg.
thus, this page brings FIXME CODESPELL (differents ==> different, difference) features like to display supplier's details,
thus, this page brings different features like to display supplier's details,
to add an order for a specific supplier or to just add a new supplier.
=head1 CGI PARAMETERS

2
acqui/check_budget_total.pl
View File

@ -26,7 +26,7 @@ use C4::Budgets qw( GetBudget );
=head1 DESCRIPTION
fetches the budget amount FIXME CODESPELL (fron ==> from, front) the DB
fetches the budget amount from the DB
=cut

2
admin/aqbudgets.pl
View File

@ -254,7 +254,7 @@ if ( $op eq 'list' ) {
my $period_total = 0;
my ( $period_alloc_total, $spent_total, $ordered_total, $available_total ) = ( 0, 0, 0, 0 );
#This Looks WEIRD to me : should budgets be filtered in such a way ppl who FIXME CODESPELL (donot ==> do not, donut) own it would not see the amount spent on the budget by others ?
#This Looks WEIRD to me : should budgets be filtered in such a way ppl who do not own it would not see the amount spent on the budget by others ?
my @budgets_to_display;
foreach my $budget (@budgets) {

2
admin/check_budget_parent.pl
View File

@ -26,7 +26,7 @@ use C4::Budgets qw( CheckBudgetParent GetBudget );
=head1 DESCRIPTION
fetches the budget amount FIXME CODESPELL (fron ==> from, front) the DB,
fetches the budget amount from the DB,
called by aqbudgets.pl and neworderempty.pl
=cut

2
authorities/authorities.pl
View File

@ -438,7 +438,7 @@ sub build_tabs {
fixedfield => ( $tag < 10 ) ? (1) : (0),
random => CreateKey,
);
if ( $tag >= 10 ) { # no indicator for FIXME CODESPELL (theses ==> these, thesis) tag
if ( $tag >= 10 ) { # no indicator for this tag
$tag_data{indicator1} = format_indicator( $field->indicator(1) ),
$tag_data{indicator2} = format_indicator( $field->indicator(2) ),;
}

2
catalogue/MARCdetail.pl
View File

@ -251,7 +251,7 @@ for ( my $tabloop = 0 ; $tabloop <= 10 ; $tabloop++ ) {
# now, build item tab !
# the main difference is that datas are in lines and not in columns : thus, we build the <th> first, then the values...
# loop through each tag
# warning : we may have FIXME CODESPELL (differents ==> different, difference) number of columns in each row. Thus, we first build a hash, complete it if necessary
# warning : we may have different number of columns in each row. Thus, we first build a hash, complete it if necessary
# then construct template.
my @fields = $record->fields();
my %witness; #---- stores the list of subfields used at least once, with the "meaning" of the code

2
cataloguing/addbooks.pl
View File

@ -83,7 +83,7 @@ if ($query) {
}
# format output
# SimpleSearch() give the results per page we want, so 0 FIXME CODESPELL (offet ==> offset, offer) here
# SimpleSearch() give the results per page we want, so 0 offset here
my $total = @{$marcresults};
my @newresults =
searchResults( { 'interface' => 'intranet' }, $query, $total, $results_per_page, 0, 0, $marcresults );

2
circ/returns.pl
View File

@ -534,7 +534,7 @@ if ( $messages->{'Wrongbranch'} ) {
);
}
# case of wrong FIXME CODESPELL (transfert ==> transfer, transferred), if the document wasn't transferred to the right library (according to branchtransfer (tobranch) BDD)
# case of wrong transfer, if the document wasn't transferred to the right library (according to branchtransfer (tobranch) BDD)
if ( $messages->{'WrongTransfer'} and not $messages->{'WasTransfered'} ) {

4
koha-tmpl/intranet-tmpl/prog/en/includes/subtype_limits.inc
View File

@ -197,9 +197,9 @@
<option value="ctype:l">Legislation</option>
[% END %]
[% IF (limits.ctype.0 == 'm' ) %]
<option value="ctype:m" selected="selected">FIXME CODESPELL (Theses ==> These, Thesis)</option>
<option value="ctype:m" selected="selected">Thesis</option>
[% ELSE %]
<option value="ctype:m">FIXME CODESPELL (Theses ==> These, Thesis)</option>
<option value="ctype:m">Thesis</option>
[% END %]
[% IF (limits.ctype.0 == 'n' ) %]
<option value="ctype:n" selected="selected">Surveys</option>

10
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
View File

@ -272,9 +272,9 @@
[% WRAPPER tab_panel tabname= "perl" bt_active = 1 %]
<table style="cursor:pointer">
<caption>Perl modules</caption>
[% FOREACH table IN tablee %]
[% FOREACH line IN table %]
<tr>
[% FOREACH ro IN table.row %]
[% FOREACH ro IN line.row %]
[% IF ( ro.require ) %]
[% SET th_font_weight = "bold" %]
[% ELSE %]
@ -313,7 +313,7 @@
[% END %]
[% END # /FOREACH ro %]
</tr>
[% END # /FOREACH table %]
[% END # /FOREACH line %]
</table>
[% END # tab=perl %]
[% END %]
@ -1246,9 +1246,9 @@
<td style="font-weight:bold;">Description</td>
</tr>
</thead>
[% FOREACH table IN tablee2 %]
[% FOREACH line IN table2 %]
<tr class="[% loop.parity | html %]">
[% FOREACH ro IN table.row2 %]
[% FOREACH ro IN line.row2 %]
<td>[% ro.date | html %]</td>
<td>[% ro.desc | html %]</td>
[% END %]

30
koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt
View File

@ -93,19 +93,19 @@
<th>Get it!</th>
<th>Other action</th>
</tr>
[% FOREACH result IN resultt %]
[% FOREACH line IN result %]
<tr>
<td>
[% IF result.html %]
[% result.html | $raw %]
[% IF line.html %]
[% line.html | $raw %]
[% ELSE %]
[% PROCESS authresulttt summary=resultt.summary authid=resultt.authid auth_preview=1 %]
[% PROCESS authresult summary=line.summary authid=line.authid auth_preview=1 %]
[% END %]
</td>
<td>[% result.summary.label | html %]</td>
<td>[% line.summary.label | html %]</td>
<td>
[% IF result.used > 0 %]
<a href="/cgi-bin/koha/catalogue/search.pl?type=intranet&amp;op=do_search&amp;idx=an,phr&amp;q=[% resultt.authid | uri %]" class="button">[% resultt.used | html %] times</a>
[% IF line.used > 0 %]
<a href="/cgi-bin/koha/catalogue/search.pl?type=intranet&amp;op=do_search&amp;idx=an,phr&amp;q=[% line.authid | uri %]" class="button">[% line.used | html %] times</a>
[% ELSE %]
0 times
[% END %]
@ -113,23 +113,23 @@
[% IF Koha.Preference('ShowHeadingUse') %]
<td class="heading_use"
><ul class="usefor">
<li>[% IF result.main %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Main/Added Entry</li>
<li>[% IF result.subject %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Subject</li>
<li>[% IF result.series %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Series Title</li>
<li>[% IF line.main %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Main/Added Entry</li>
<li>[% IF line.subject %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Subject</li>
<li>[% IF line.series %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Series Title</li>
</ul></td
>
[% END %]
<td>
[% IF resulttt.summary && resulttt.summary.authorized && resulttt.summary.authorized.size > 1 %]
[% FOREACH authorized IN result.summary.authorized %]
<a href="javascript:doauth('[% result.authid | uri %]', '[% index | uri %]', '[% loop.count | uri %]')" title="[% authorized.heading | html %]">[% loop.count | html %]</a>
[% IF line.summary && line.summary.authorized && line.summary.authorized.size > 1 %]
[% FOREACH authorized IN line.summary.authorized %]
<a href="javascript:doauth('[% line.authid | uri %]', '[% index | uri %]', '[% loop.count | uri %]')" title="[% authorized.heading | html %]">[% loop.count | html %]</a>
[% END %]
[% ELSE %]
<a class="btn btn-xs btn-default" href="javascript:doauth('[% result.authid | html %]', '[% index | html %]', '')"><i class="fa fa-plus"></i> Choose</a>
<a class="btn btn-xs btn-default" href="javascript:doauth('[% line.authid | html %]', '[% index | html %]', '')"><i class="fa fa-plus"></i> Choose</a>
[% END %]
</td>
<td
><a class="btn btn-xs btn-default" href="authorities.pl?authid=[% result.authid | html %]"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit authority</a></td
><a class="btn btn-xs btn-default" href="authorities.pl?authid=[% line.authid | html %]"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit authority</a></td
>
</tr>
[% END %]

30
koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt
View File

@ -73,20 +73,20 @@
<th>&nbsp;</th>
[% END %]
</tr>
[% FOREACH result IN resultt %]
[% FOREACH line IN result %]
<tr data-authid="[% result.authid | html %]">
<td>
[% IF result.html %]
[% result.html | $raw %]
[% ELSE %]
[% PROCESS authresulttt summary=resultt.summary authid=resultt.authid %]
[% PROCESS authresult summary=line.summary authid=line.authid %]
[% END %]
</td>
<td>[% result.authtype | html %]</td>
[% UNLESS ( result.isEDITORS ) %]
<td>[% line.authtype | html %]</td>
[% UNLESS ( line.isEDITORS ) %]
<td>
[% IF result.used > 0 %]
<a href="/cgi-bin/koha/catalogue/search.pl?type=intranet&amp;op=do_search&amp;idx=an,phr&amp;q=[% resultt.authid | uri %]" class="button">[% resultt.used | html %] record(s)</a>
[% IF line.used > 0 %]
<a href="/cgi-bin/koha/catalogue/search.pl?type=intranet&amp;op=do_search&amp;idx=an,phr&amp;q=[% line.authid | uri %]" class="button">[% line.used | html %] record(s)</a>
[% ELSE %]
0 records
[% END %]
@ -95,29 +95,29 @@
[% IF Koha.Preference('ShowHeadingUse') %]
<td class="heading_use"
><ul class="usefor">
<li>[% IF result.main %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Main/Added Entry</li>
<li>[% IF result.subject %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Subject</li>
<li>[% IF result.series %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Series Title</li>
<li>[% IF line.main %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Main/Added Entry</li>
<li>[% IF line.subject %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Subject</li>
<li>[% IF line.series %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Series Title</li>
</ul></td
>
[% END %]
[% IF ( CAN_user_editauthorities ) %]
<td>
<div class="btn-group dropup">
<a class="btn btn-default btn-xs dropdown-toggle" id="authactions[% result.authid | html %]" role="button" data-bs-toggle="dropdown" href="#"> Actions</a>
<ul class="dropdown-menu dropdown-menu-end" role="menu" aria-labelledby="authactions[% result.authid | html %]">
<a class="btn btn-default btn-xs dropdown-toggle" id="authactions[% line.authid | html %]" role="button" data-bs-toggle="dropdown" href="#"> Actions</a>
<ul class="dropdown-menu dropdown-menu-end" role="menu" aria-labelledby="authactions[% line.authid | html %]">
<li
><a class="dropdown-item" href="/cgi-bin/koha/authorities/authorities.pl?authid=[% result.authid | uri %]"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit</a></li
><a class="dropdown-item" href="/cgi-bin/koha/authorities/authorities.pl?authid=[% line.authid | uri %]"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit</a></li
>
<li
><a class="merge_auth dropdown-item" href="#merge"><i class="fa fa-compress"></i> Merge</a></li
>
[% UNLESS ( result.used ) %]
[% UNLESS ( line.used ) %]
<li
><form class="form_delete" method="post" action="/cgi-bin/koha/authorities/authorities-home.pl">
[% INCLUDE 'csrf-token.inc' %]
<input type="hidden" name="op" value="cud-delete" />
<input type="hidden" name="authid" value="[% result.authid | html %]" />
<input type="hidden" name="authid" value="[% line.authid | html %]" />
<input type="hidden" name="type" value="intranet" />
<input type="hidden" name="authtypecode" value="[% authtypecode | html %]" />
<input type="hidden" name="marclist" value="[% marclist | html %]" />
@ -133,7 +133,7 @@
>
[% END %]
<li class="authority_preview">
<a class="dropdown-item" data-authid="[% resultt.authid | html %]" href="/cgi-bin/koha/authorities/detail.pl?authid=[% resultt.authid | uri %]"><i class="fa-solid fa-eye"></i> MARC preview</a>
<a class="dropdown-item" data-authid="[% line.authid | html %]" href="/cgi-bin/koha/authorities/detail.pl?authid=[% line.authid | uri %]"><i class="fa-solid fa-eye"></i> MARC preview</a>
</li>
</ul>
</div>

28
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt
View File

@ -84,33 +84,33 @@
<th>Concise description</th>
<th>&nbsp;</th>
</tr>
[% FOREACH result IN resultt %]
[% IF ( result.title ) %]
[% FOREACH line IN result %]
[% IF ( line.title ) %]
<tr>
[% SET td_class = '' %]
[% IF ( result.even ) %]
[% IF ( line.even ) %]
[% td_class = 'hilighted' %]
[% END %]
<td class="[% td_class | html %]">
[% IF ( result.MARC_ON ) %]
<a class="transparent resultttlist" href="/cgi-bin/koha/MARCdetail.pl?biblionumber=[% resultt.biblionumber |url %]">[% resultt.title | html %]</a>
[% IF ( line.MARC_ON ) %]
<a class="transparent resultlist" href="/cgi-bin/koha/MARCdetail.pl?biblionumber=[% line.biblionumber |url %]">[% line.title | html %]</a>
[% ELSE %]
<a class="transparent resultttlist" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% resultt.biblionumber |url %]">[% resultt.title | html %]</a>
<a class="transparent resultlist" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% line.biblionumber |url %]">[% line.title | html %]</a>
[% END %]
<p
>[% result.author | html %]
[% IF ( resultt.publishercode ) %]- [% resultt.publishercode | html %][% END %]
[% IF ( resultt.place ) %]; [% resultt.place | html %][% END %]
[% IF ( resultt.pages ) %]- [% resultt.pages | html %][% END %]
[% IF ( resultt.notes ) %]: [% resultt.notes | html %][% END %]
[% IF ( resultt.size ) %]; [% resultt.size | html %][% END %]
>[% line.author | html %]
[% IF ( line.publishercode ) %]- [% line.publishercode | html %][% END %]
[% IF ( line.place ) %]; [% line.place | html %][% END %]
[% IF ( line.pages ) %]- [% line.pages | html %][% END %]
[% IF ( line.notes ) %]: [% line.notes | html %][% END %]
[% IF ( line.size ) %]; [% line.size | html %][% END %]
</p>
</td>
<td>
[% IF ( result.biblionumber ) %]
[% IF ( line.biblionumber ) %]
<a
href="javascript:jumpfull('/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=marc21_linking_section.pl&amp;index=[% index | uri %]&amp;biblionumber=[% result.biblionumber | uri %]&amp;type=intranet&amp;op=fillinput')"
href="javascript:jumpfull('/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=marc21_linking_section.pl&amp;index=[% index | uri %]&amp;biblionumber=[% line.biblionumber | uri %]&amp;type=intranet&amp;op=fillinput')"
>Choose</a
>
[% ELSE %]

12
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_210c.tt
View File

@ -68,15 +68,15 @@
<th>Used</th>
<th>Get it!</th>
</tr>
[% FOREACH result IN resultt %]
[% FOREACH line IN result %]
<tr>
<td>[% PROCESS authresulttt summary=resultt.summary authid=resultt.authid %]</td>
<td>[% result.summary.label | html %]</td>
<td>[% result.used | html %] times</td>
<td>[% PROCESS authresult summary=line.summary authid=line.authid %]</td>
<td>[% line.summary.label | html %]</td>
<td>[% line.used | html %] times</td>
<td>
[% IF ( result.to_report ) %]
[% IF ( line.to_report ) %]
<button class="choosebt">Choose</button>
<p class="toreport" style="display:none">[% result.to_report |replace('\n', '\\n') |replace('\r', '\\r') |html %]</p>
<p class="toreport" style="display:none">[% line.to_report |replace('\n', '\\n') |replace('\r', '\\r') |html %]</p>
[% END %]
</td>
</tr>

32
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt
View File

@ -89,36 +89,36 @@
<th>Location</th>
<th>&nbsp;</th>
</tr>
[% FOREACH result IN resultt %]
[% IF ( result.title ) %]
[% FOREACH line IN result %]
[% IF ( line.title ) %]
<tr>
[% SET td_class = '' %]
[% IF ( result.even ) %]
[% IF ( line.even ) %]
[% td_class = 'hilighted' %]
[% END %]
<td class="[% td_class | html %]">
[% IF ( result.MARC_ON ) %]
<a class="transparent resultttlist" href="/cgi-bin/koha/MARCdetail.pl?biblionumber=[% resultt.biblionumber |url %]">[% resultt.title | html %]</a>
[% IF ( line.MARC_ON ) %]
<a class="transparent resultlist" href="/cgi-bin/koha/MARCdetail.pl?biblionumber=[% line.biblionumber |url %]">[% line.title | html %]</a>
[% ELSE %]
<a class="transparent resultttlist" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% resultt.biblionumber |url %]">[% resultt.fulltitle | html %]</a>
<a class="transparent resultlist" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% line.biblionumber |url %]">[% line.fulltitle | html %]</a>
[% END %]
<p
>[% result.author | html %]
[% IF ( resultt.publishercode ) %]- [% resultt.publishercode | html %][% END %]
[% IF ( resultt.place ) %]; [% resultt.place | html %][% END %]
[% IF ( resultt.pages ) %]- [% resultt.pages | html %][% END %]
[% IF ( resultt.notes ) %]: [% resultt.notes | html %][% END %]
[% IF ( resultt.item('size') ) %]; [% resultt.item('size') | html %][% END %]
>[% line.author | html %]
[% IF ( line.publishercode ) %]- [% line.publishercode | html %][% END %]
[% IF ( line.place ) %]; [% line.place | html %][% END %]
[% IF ( line.pages ) %]- [% line.pages | html %][% END %]
[% IF ( line.notes ) %]: [% line.notes | html %][% END %]
[% IF ( line.item('size') ) %]; [% line.item('size') | html %][% END %]
</p>
</td>
<td align="center" class="[% td_class | html %]"> [% result.totitem | html %] </td>
<td class="[% td_class | html %]"> [% result.CN | html %] </td>
<td align="center" class="[% td_class | html %]"> [% line.totitem | html %] </td>
<td class="[% td_class | html %]"> [% line.CN | html %] </td>
<td>
[% IF ( result.biblionumber ) %]
[% IF ( line.biblionumber ) %]
<a
href="#"
class="btn btn-default btn-xs redirect_link"
data-url="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&amp;index=[% index | html %]&amp;biblionumber=[% result.biblionumber | html %]&amp;type=intranet&amp;op=fillinput"
data-url="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&amp;index=[% index | html %]&amp;biblionumber=[% line.biblionumber | html %]&amp;type=intranet&amp;op=fillinput"
>Choose</a
>
[% ELSE %]

2
koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt
View File

@ -320,7 +320,7 @@
} else if (mode == 'batch') {
return GB_showCenter(_("Export labels"), "/cgi-bin/koha/labels/label-print.pl?batch_id=[% batch_id | html %]", 400, 800);
} else {
// some pass-thru error trapping just in case...
// some pass-through error trapping just in case...
}
}

2
koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt
View File

@ -269,7 +269,7 @@
} else if (mode == 'batch') {
return GB_showCenter(_("Export patron cards"), "/cgi-bin/koha/patroncards/print.pl?batch_id=[% batch_id | html %]", 400, 800);
} else {
// some pass-thru error trapping just in case...
// some pass-through error trapping just in case...
}
};
function selected_layout() {

8
koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt
View File

@ -82,11 +82,11 @@
<fieldset class="brief">
<div class="hint"> Select one or more images to delete. </div>
<table>
[% FOREACH TABLE IN TABLEE %]
[% FOREACH line IN TABLE %]
[% IF ( TABLE.header_fields ) %]
[% IF ( line.header_fields ) %]
<tr>
[% FOREACH header_field IN TABLE.header_fields %]
[% FOREACH header_field IN line.header_fields %]
[% SWITCH header_field.field_label -%]
[% CASE "ID" %]
<th>Image ID</th>
@ -101,7 +101,7 @@
</tr>
[% ELSE %]
<tr>
[% FOREACH text_field IN TABLE.text_fields %]
[% FOREACH text_field IN line.text_fields %]
[% IF ( text_field.select_field ) %]
<td>
<a

4
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
View File

@ -1734,9 +1734,9 @@
$("#always_show_holds").change(function(){
if( $(this).prop('checked') ){
document.cookie = 'always_show_holds=DO';
document.cookie = "always_show_holds=DO";
} else {
document.cookie = 'always_show_holds=DONT';
document.cookie = "always_show_holds=DONT";
}
});
$("input.needsoverride").click(function() { // This must be before the radio button/checkbox switch logic

16
koha-tmpl/intranet-tmpl/prog/js/ill-batch-modal.js
View File

@ -140,7 +140,7 @@
// The element that potentially holds the ID of the batch
// we're working with
var idle = document.getElementById("ill-batch-details");
var elId = document.getElementById("ill-batch-details");
var batchId = null;
var backend = null;
@ -157,8 +157,8 @@
$("#ill-batch-modal").on("hidden.bs.modal", function () {
// Reset our state when we close the modal
// TODO: need to also reset progress bar and already processed identifiers
delete idle.dataset.batchId;
delete idle.dataset.backend;
delete elId.dataset.batchId;
delete elId.dataset.backend;
batchId = null;
tableEl.style.display = "none";
tableContent.data = [];
@ -176,8 +176,8 @@
}
function init() {
batchId = idle.dataset.batchId;
backend = idle.dataset.backend;
batchId = elId.dataset.batchId;
backend = elId.dataset.backend;
emptyBatch.backend = backend;
progressTotals.data = {
total: 0,
@ -714,9 +714,9 @@
var tabIdentifiers = tableContent.data.map(function (tabId) {
return tabId.value;
});
var notInTable = deaduped.filter(function (dead) {
if (!tabIdentifiers.includes(dead.value)) {
return dead;
var notInTable = deduped.filter(function (d) {
if (!tabIdentifiers.includes(d.value)) {
return d;
}
});
if (notInTable.length > 0) {

6
koha-tmpl/intranet-tmpl/prog/js/ill-batch.js
View File

@ -3,10 +3,10 @@
// If we're working with an existing batch, set the ID so the
// modal can access it
window.openBatchModal = function (id, backend) {
var idle = document.getElementById("ill-batch-details");
idle.dataset.backend = backend;
var elId = document.getElementById("ill-batch-details");
elId.dataset.backend = backend;
if (id) {
idle.dataset.batchId = id;
elId.dataset.batchId = id;
}
$("#ill-batch-modal").modal("show");
};

2
koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc
View File

@ -44,7 +44,7 @@
[% IF ( HOLD.is_at_destination ) %]
[% tr_class = 'reserved' %]
[% ELSIF HOLD.is_in_transit %]
[% tr_class = 'transfered' %]
[% tr_class = 'transferred' %]
[% END %]
<tr class="[% tr_class | html %]">
<td class="title">

2
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
View File

@ -454,7 +454,7 @@
<option value="ctype:j">Patent document</option>
<option value="ctype:k">Discographies</option>
<option value="ctype:l">Legislation</option>
<option value="ctype:m">FIXME CODESPELL (Theses ==> These, Thesis)</option>
<option value="ctype:m">Thesis</option>
<option value="ctype:n">Surveys</option>
<option value="ctype:o">Reviews</option>
<option value="ctype:p">Programmed texts</option>

16
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt
View File

@ -76,20 +76,20 @@
</tr>
</thead>
<tbody>
[% FOREACH result IN resultt %]
[% FOREACH line IN result %]
<tr>
<td>
[% IF result.html %]
[% result.html | $raw %]
[% IF line.html %]
[% line.html | $raw %]
[% ELSE %]
[% PROCESS authresulttt summary=resultt.summary authid=resultt.authid %]
[% PROCESS authresult summary=line.summary authid=line.authid %]
[% END %]
</td>
<td><a href="/cgi-bin/koha/opac-authoritiesdetail.pl?authid=[% resultt.authid | uri %]">Details</a> </td><td>[% resultt.authtype | html %]</td>
[% UNLESS ( result.isEDITORS ) %]
<td><a href="/cgi-bin/koha/opac-authoritiesdetail.pl?authid=[% line.authid | uri %]">Details</a> </td><td>[% line.authtype | html %]</td>
[% UNLESS ( line.isEDITORS ) %]
<td>
[% IF result.used > 0 %]
<a href="/cgi-bin/koha/opac-search.pl?type=opac&amp;op=do_search&amp;q=an,phr:[% resulttt.authid | uri %]">[% resulttt.used | html %] [% tn('record', 'records', resulttt.used ) | html %]</a>
[% IF line.used > 0 %]
<a href="/cgi-bin/koha/opac-search.pl?type=opac&amp;op=do_search&amp;q=an,phr:[% line.authid | uri %]">[% line.used | html %] [% tn('record', 'records', line.used ) | html %]</a>
[% ELSE %]
0 records
[% END %]

2
members/housebound.pl
View File

@ -122,7 +122,7 @@ if ( $op eq 'cud-updateconfirm' and $houseboundprofile ) {
$houseboundvisit = $visit;
} elsif ( $op eq 'cud-visit_delete' and $visit ) {
# We want ot delete a specific visit.
# We want to delete a specific visit.
my $success = eval { return $visit->delete };
push @messages, { type => 'error', code => 'error_on_visit_delete' }
if ( $@ or !$success );

2
misc/cronjobs/advance_notices.pl
View File

@ -141,7 +141,7 @@ program. They may be redirected to a file if desired.
=head2 Templates
Templates can contain variables enclosed in double angle brackets like
E<lt>E<lt>FIXME CODESPELL (thisE ==> these, this)<gt>E<gt>. Those variables will be replaced with values
<<this>>. Those variables will be replaced with values
specific to the overdue items or relevant patron. Available variables
are:

2
misc/cronjobs/holds/holds_reminder.pl
View File

@ -202,7 +202,7 @@ unless ( defined $days ) {
$days = 0;
}
# Unless one ore more branchcodes are passed we use all the branches
# Unless one or more branchcodes are passed we use all the branches
if ( scalar @branchcodes > 0 ) {
my $branchcodes_word = scalar @branchcodes > 1 ? 'branches' : 'branch';
$verbose and warn "$branchcodes_word @branchcodes passed on parameter\n";

2
misc/cronjobs/membership_expiry.pl
View File

@ -142,7 +142,7 @@ not the borrower has an email address. This can be useful for libraries that
prefer to deal with print notices.
Notices can contain variables enclosed in double angle brackets like
E<lt>E<lt>FIXME CODESPELL (thisE ==> these, this)<gt>E<gt>. Those variables will be replaced with values
<<this>>. Those variables will be replaced with values
specific to the soon expiring members.
Available variables are:

2
misc/cronjobs/overdue_notices.pl
View File

@ -227,7 +227,7 @@ program. They may be redirected to a file if desired.
=head2 Templates
Templates can contain variables enclosed in double angle brackets like
E<lt>E<lt>FIXME CODESPELL (thisE ==> these, this)<gt>E<gt>. Those variables will be replaced with values
<<this>>. Those variables will be replaced with values
specific to the overdue items or relevant patron. Available variables
are:

4
misc/cronjobs/update_patrons_category.pl
View File

@ -109,11 +109,11 @@ Supply a number and only account with fines under this number will be updated.
=item B<--regbefore=date | -rb=date>
Enter a date in ISO format YYYY-MM-DD and only patrons registered before this date FIXME CODESPELL (wil ==> will, well) be updated.
Enter a date in ISO format YYYY-MM-DD and only patrons registered before this date will be updated.
=item B<--regafter=date | -ra=date>
Enter a date in ISO format YYYY-MM-DD and only patrons registered after this date FIXME CODESPELL (wil ==> will, well) be updated.
Enter a date in ISO format YYYY-MM-DD and only patrons registered after this date will be updated.
=item B<--field column=value | -d column=value>

8
misc/maintenance/UNIMARC_sync_date_created_with_marc_biblio.pl
View File

@ -48,9 +48,9 @@ $verbose and print "================================\n";
$date_created_marc = '099c' unless $date_created_marc;
my ( $c_field, $c_subfield ) = _read_marc_code($date_created_marc);
die "date-created-marc '$date_created_marc' is not correct." unless $c_field;
die "date-created-marc field is FIXME CODESPELL (greated ==> greater, grated, graded) that 009, it should have a subfield."
die "date-created-marc field is greater than 009, it should have a subfield."
if ( $c_field > 9 && !defined $c_subfield );
die "date-created-marc field is lower that 010, it should not have a subfield."
die "date-created-marc field is lower than 010, it should not have a subfield."
if ( $c_field < 10 && defined $c_subfield );
if ($verbose) {
print "Date created on $c_field";
@ -62,9 +62,9 @@ if ($verbose) {
$date_modified_marc = '099d' unless $date_modified_marc;
my ( $m_field, $m_subfield ) = _read_marc_code($date_modified_marc);
die "date-modified-marc '$date_modified_marc' is not correct." unless $m_field;
die "date-modified-marc field is FIXME CODESPELL (greated ==> greater, grated, graded) that 009, it should have a subfield."
die "date-modified-marc field is greater than 009, it should have a subfield."
if ( $m_field > 9 && !defined $m_subfield );
die "date-modified-marc field is lower that 010, it should not have a subfield."
die "date-modified-marc field is lower than 010, it should not have a subfield."
if ( $m_field < 10 && defined $m_subfield );
die "When date-created-marc and date-modified-marc are on same field, they should have distinct subfields"
if ( $c_field eq $m_field )

2
misc/migration_tools/22_to_30/move_marc_to_authheader.pl
View File

@ -51,7 +51,7 @@ while ( my ( $authid, $authtypecode ) = $sth->fetchrow ) {
$record->insert_fields_ordered( MARC::Field->new( '001', $authid ) );
}
#Force UTF-8 in record FIXME CODESPELL (leaded ==> led, lead)
#Force UTF-8 in record
$record->encoding('UTF-8');
# warn "REC : ".$record->as_formatted;

2
misc/migration_tools/build_oai_sets.pl
View File

@ -180,7 +180,7 @@ sub print_usage {
print "build_oai_sets.pl: Build OAI-PMH sets, according to mappings defined in Koha\n";
print "Usage: build_oai_sets.pl [-h] [-v] [-i] [-l LENGTH [-o OFFSET]]\n\n";
print "\t-h\t\tPrint this help and exit\n";
print "\t-v\t\the verbose\n";
print "\t-v\t\t" . " Be verbose\n";
print "\t-i\t\tEmbed items information, mandatory if you defined mappings on item fields\n";
print "\t-l LENGTH\tProcess LENGTH biblios\n";
print "\t-o OFFSET\tIf LENGTH is defined, start processing from OFFSET\n\n";

2
opac/opac-MARCdetail.pl
View File

@ -297,7 +297,7 @@ for ( my $tabloop = 0 ; $tabloop <= 9 ; $tabloop++ ) {
# now, build item tab !
# the main difference is that datas are in lines and not in columns : thus, we build the <th> first, then the values...
# loop through each tag
# warning : we may have FIXME CODESPELL (differents ==> different, difference) number of columns in each row. Thus, we first build a hash, complete it if necessary
# warning : we may have different number of columns in each row. Thus, we first build a hash, complete it if necessary
# then construct template.
# $record has already had all the item fields filtered above.
my @fields = $record->fields();

2
opac/opac-suggestions.pl
View File

@ -186,7 +186,7 @@ if ( $op eq "cud-add_confirm" ) {
push @messages, { type => 'error', code => 'too_many' };
} elsif ( $suggestions->count >= 1 ) {
#some suggestion are answering the request FIXME CODESPELL (Donot ==> Do not, Donut) Add
#some suggestion are answering the request, do not add
while ( my $suggestion = $suggestions->next ) {
push @messages,
{

2
opac/opac-tags.pl
View File

@ -344,7 +344,7 @@ if ($add_op) {
# Bug 36785: Do not pass biblionumber: get_approval_rows does not 'recognize' biblionumber
$results = get_approval_rows($arghash);
stratify_tags( 10, $results ); # work out the FIXME CODESPELL (differents ==> different, difference) sizes for things
stratify_tags( 10, $results ); # work out the different sizes for things
my $count = scalar @$results;
$template->param( TAGLOOP_COUNT => $count, mine => $mine );
}

2
suggestion/suggestion.pl
View File

@ -257,7 +257,7 @@ if ( $op =~ /cud-save/ ) {
my $suggestions = Koha::Suggestions->search_limited($suggestion_only);
if ( $suggestions->count ) {
#some suggestion are answering the request FIXME CODESPELL (Donot ==> Do not, Donut) Add
#some suggestion are answering the request, do not add
my @messages;
while ( my $suggestion = $suggestions->next ) {
push @messages, { type => 'error', code => 'already_exists', id => $suggestion->suggestionid };

2
svc/holds
View File

@ -125,7 +125,7 @@ while ( my $h = $holds_rs->next() ) {
};
$hold->{transferred} = 0;
$hold->{not_transfered} = 0;
$hold->{not_transferred} = 0;
if ($item) {
$hold->{itemnumber} = $item->itemnumber();

2
t/cypress/support/e2e.js
View File

@ -1298,7 +1298,7 @@ cy.get_title = () => {
num_last_vol_online: "num last vol",
online_identifier: "online identifier",
parent_publication_title_id: "parent id",
preceding_publication_title_id: "FIXME CODESPELL (preceeding ==> preceding, proceeding) id",
preceding_publication_title_id: "preceding id",
print_identifier: "print identifier",
publication_title: "publication title",
publication_type: "journal",

4
t/db_dependent/Acquisition/GetBasketAsCSV.t
View File

@ -116,11 +116,11 @@ is(
try {
my $basket_csv4 = C4::Acquisition::GetBasketAsCSV( $basketno, $query, 'non_existant_profile_id' );
fail("It is not possible to export basket using non-existant profile");
fail("It is not possible to export basket using non-existent profile");
} catch {
ok(
$_->isa("Koha::Exceptions::ObjectNotFound"),
"Using non-existant profile should throw ObjectNotFound exception"
"Using non-existent profile should throw ObjectNotFound exception"
);
};

2
t/db_dependent/Biblio_holdsqueue.t
View File

@ -83,7 +83,7 @@ subtest 'ModBiblio() + holds_queue update tests' => sub {
$biblio->frameworkcode, { skip_holds_queue => 0 }
);
# this call FIXME CODESPELL (shoul ==> should, shoal, shawl) not trigger the mocked 'enqueue'
# this call should not trigger the mocked 'enqueue'
C4::Biblio::ModBiblio(
$biblio->metadata->record, $biblio->id,
$biblio->frameworkcode, { skip_holds_queue => 1 }

6
t/db_dependent/Breeding.t
View File

@ -132,12 +132,12 @@ sub test_build_translate_query {
is( $queries[0] =~ /$str/, 1, 'First Z39.50 query contains ISBN' );
#SRU query should contain translation for ISBN
my $server = { sru_fields => 'isbn=ie-es-bee-en,srchany=overal' };
my $server = { sru_fields => 'isbn=ie-es-bee-en,srchany=overall' };
my $squery = C4::Breeding::_translate_query( $server, $queries[1] );
is( $squery =~ /ie-es-bee-en/, 1, 'SRU query has translated ISBN index' );
#Another try with fallback to any
$server = { sru_fields => 'srchany=overal' };
$server = { sru_fields => 'srchany=overall' };
$squery = C4::Breeding::_translate_query( $server, $queries[1] );
is( $squery =~ /overall/, 1, 'SRU query fallback to translated any' );
@ -170,7 +170,7 @@ sub test_build_translate_query {
);
#SRU revisited
$server = { sru_fields => 'isbn=nb,title=dc.title,srchany=overal' };
$server = { sru_fields => 'isbn=nb,title=dc.title,srchany=overall' };
$squery = C4::Breeding::_translate_query( $server, $queries[1] );
is( $squery =~ /dc.title/ && $squery =~ / and / && $squery =~ /nb=/, 1, 'SRU query with two parameters' );

2
t/db_dependent/Circulation.t
View File

@ -2059,7 +2059,7 @@ subtest "Bug 13841 - Do not create new 0 amount fines" => sub {
);
my $count = $hr->{count};
is( $count, 0, "Calling UpdateFine on non-existant fine with an amount of 0 does not result in an empty fine" );
is( $count, 0, "Calling UpdateFine on non-existent fine with an amount of 0 does not result in an empty fine" );
};
subtest "AllowRenewalIfOtherItemsAvailable tests" => sub {

4
t/db_dependent/Circulation/transferbook.t
View File

@ -32,12 +32,12 @@ my $schema = Koha::Database->new->schema;
$schema->storage->txn_begin;
subtest 'transfer a non-existant item' => sub {
subtest 'transfer a non-existent item' => sub {
plan tests => 2;
my $library = $builder->build( { source => 'Branch' } );
#FIXME CODESPELL (Transfert ==> Transfer, Transferred) on unknown barcode
#Transfer on unknown barcode
my $item = $builder->build_sample_item();
my $badbc = $item->barcode;
$item->delete;

2
t/db_dependent/HoldsQueue.t
View File

@ -400,7 +400,7 @@ C4::Calendar->new( branchcode => $branchcodes[0] )->insert_single_holiday(
description => "$today",
);
# If the test below is removed, FIXME CODESPELL (aother ==> another, other, mother) tests using the holiday will fail. For some reason if we call is_holiday now
# If the test below is removed, another tests using the holiday will fail. For some reason if we call is_holiday now
# the holiday will get set in cache correctly, but not if we let C4::HoldsQueue call is_holiday instead.
is(
Koha::Calendar->new( branchcode => $branchcodes[0] )->is_holiday($today), 1,

2
t/db_dependent/LDAP/test_ldap_add.pl
View File

@ -66,7 +66,7 @@ sub ldap_search {
$query->code and die sprintf 'error (code:%s) - %s', $query->code, $query->error;
my $size = scalar( $query->entries );
my $i = 5;
print "\number of records returned from search: $size.\n";
print "\n" . "Number of records returned from search: $size." . "\n";
( $size > $i ) and print "Displaying the last $i records.\n\n";
foreach ( $query->entries ) {
( $size-- > $i ) and next;

2
t/db_dependent/Languages.t
View File

@ -27,7 +27,7 @@ my $schema = Koha::Database->new->schema;
$schema->storage->txn_begin;
my $dbh = C4::Context->dbh;
isnt( C4::Languages::_get_themes(), undef, 'testing _get_themes FIXME CODESPELL (doesnt ==> doesn't, does not) return undef' );
isnt( C4::Languages::_get_themes(), undef, 'testing _get_themes does not return undef' );
ok( C4::Languages::_get_language_dirs(), 'test getting _get_language_dirs' );

2
t/db_dependent/Letters.t
View File

@ -224,7 +224,7 @@ isnt(
$messages->[0]->{updated_on}, $messages->[0]->{time_queued},
'Time status changed differs from time queued when status changes'
);
is( dt_from_string( $messages->[0]->{time_queued} ), $yesterday, 'Time queued FIXME CODESPELL (remaines ==> remains, remained) inmutable' );
is( dt_from_string( $messages->[0]->{time_queued} ), $yesterday, 'Time queued remains inmutable' );
# ResendMessage
my $resent = C4::Letters::ResendMessage( $messages->[0]->{message_id} );

2
t/db_dependent/OAI/Sets.t
View File

@ -176,7 +176,7 @@ isa_ok( $set, 'HASH', '$set is a hash describing the set whose spec is $oai_sets
is( $set->{spec}, 'specSet2', 'spec field is "specSet2"' );
is( $set->{name}, 'nameSet2', 'name field is "nameSet2"' );
#GetOAISetBySpec does't return the description field.
#GetOAISetBySpec does not return the description field.
# ---------- Testing ModOAISet ------------------
ok( !defined(ModOAISet), 'ModOAISet without argument is undef' );

4
t/db_dependent/Search.t
View File

@ -1156,12 +1156,12 @@ sub run_unimarc_search_tests {
['mainentry'], ['and'], [''], ['contains'],
['wil'], 0, 10, '', '', 1
);
is( $count, 11, 'UNIMARC authorities: hits on mainentry contains "FIXME CODESPELL (wil ==> will, well)"' );
is( $count, 11, 'UNIMARC authorities: hits on mainentry contains the search term' );
( $auths, $count ) = SearchAuthorities(
['match'], ['and'], [''], ['contains'],
['wil'], 0, 10, '', '', 1
);
is( $count, 11, 'UNIMARC authorities: hits on match contains "FIXME CODESPELL (wil ==> will, well)"' );
is( $count, 11, 'UNIMARC authorities: hits on match contains the search term' );
( $auths, $count ) = SearchAuthorities(
['mainentry'], ['and'], [''], ['contains'],
['michel'], 0, 20, '', '', 1

2
t/db_dependent/Serials.t
View File

@ -404,7 +404,7 @@ subtest 'GetSubscriptionsFromBiblionumber' => sub {
is( C4::Serials::GetSerials(), undef, 'test getting serials when you enter nothing' );
is( C4::Serials::GetSerials2(), undef, 'test getting serials when you enter nothing' );
is( C4::Serials::GetLatestSerials(), undef, 'test getting FIXME CODESPELL (lastest ==> latest, last) serials' );
is( C4::Serials::GetLatestSerials(), undef, 'test getting latest serials' );
is( C4::Serials::GetNextSeq(), undef, 'test getting next seq when you enter nothing' );

4
t/db_dependent/Utils/Datatables_Virtualshelves.t
View File

@ -188,7 +188,7 @@ t::lib::Mocks::mock_userenv( { patron => $john_doe_patron } );
# Search private lists by title
$search_results = C4::Utils::DataTables::VirtualShelves::search(
{
shelfname => "FIXME CODESPELL (ist ==> is, it, its, it's, sit, list)",
shelfname => "list",
%dt_params,
public => 0,
}
@ -201,7 +201,7 @@ is(
is(
$search_results->{recordsFiltered}, 2,
"There should be 2 private shelves with title like '%FIXME CODESPELL (ist ==> is, it, its, it's, sit, list)%"
"There should be 2 private shelves with title like '%list%"
);
is(

4
t/db_dependent/api/v1/stockrotationstage.t
View File

@ -86,11 +86,11 @@ subtest 'move() tests' => sub {
$t->put_ok( "//$unauth_userid:$password@/api/v1/rotas/$rota_id/stages/$stage1_id/position" => json => 2 )
->status_is(403);
# Invalid attempt to move a stage on a non-existant rota
# Invalid attempt to move a stage on a non-existent rota
$t->put_ok( "//$auth_userid:$password@/api/v1/rotas/99999999/stages/$stage1_id/position" => json => 2 )
->status_is(404)->json_is( '/error' => "Rota not found" );
# Invalid attempt to move an non-existant stage
# Invalid attempt to move an non-existent stage
$t->put_ok( "//$auth_userid:$password@/api/v1/rotas/$rota_id/stages/999999999/position" => json => 2 )
->status_is(404)->json_is( '/error' => "Stage not found" );