gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/koha-tmpl/intranet-tmpl/prog/en/modules/admin
History
Jonathan Druart 18134d8343
Bug 41318: Rename AmazonLocale to AmazonLocaleTld 
To be more flexible we could allow the top-level domain instead of
having a predefined list.
However this patch still list the different available options (and adds
Brazilian) for easy selection.

Note that this system preference is not used to retrieve the image but
only to link to from the image. Contrary to what the reporter of the bug
report thought. And actually what I thought as well until I finished to
write the patch and started testing it!
Anyway now the patch is written, there should not be any changes in
behaviour. Most of the time the links are actually broken when not using
.com. So I think we either broke the whole feature at some point, or it
never really worked. On a separate bug we could eventually have a look
at fetching from the locale tld.

Test plan:
Turn on OPACAmazonCoverImages and AmazonCoverImages
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=5
http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=5
=> You see the PBP cover
click on it, it opens the lightbox, click "(see the original image)" at
the bottom
=> This is where the syspref AmazonLocale/AmazonLocaleTld acts

Modify the syspref's value and confirm that the link is modified and
point to the correct domain (leading to 404 or broken pages most of the time,
at least in my tests).

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
 		2026-09-10 14:25:34 +00:00
..
preferences Bug 41318: Rename AmazonLocale to AmazonLocaleTld 2026-09-10 14:25:34 +00:00
searchengine/elasticsearch Bug 22639: Add export mappings button to mappings page 2026-04-15 11:37:18 -06:00
additional-fields.tt Bug 42111: Update various admin pages to use grid layout for forms - Part 1 2026-08-21 15:58:23 +00:00
admin-home.tt Bug 10190: (QA follow-up): fix: permissions 2026-09-10 14:25:25 +00:00
adveditorshortcuts.tt Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
aqbudgetperiods.tt Bug 42280: Tidy all script tags - admin 2026-07-20 09:15:56 +00:00
aqbudgets.tt Bug 42330: Tidy 2026-09-04 11:23:17 +00:00
aqcontract.tt Bug 41823: Update acquisitions admin pages to use grid layout for forms 2026-04-29 09:09:17 -06:00
aqplan.tt Bug 42330: Tidy 2026-09-04 11:23:17 +00:00
audio_alerts.tt Bug 42111: Update various admin pages to use grid layout for forms - Part 1 2026-08-21 15:58:23 +00:00
auth_subfields_structure.tt Bug 42280: Tidy all script tags - admin 2026-07-20 09:15:56 +00:00
auth_tag_structure.tt Bug 41827: Update authority types pages to use grid layout for forms 2026-04-29 09:09:18 -06:00
authorised_values.tt Bug 42128: Remove event attribute from admin-icon-selection.inc 2026-06-19 12:00:22 +00:00
authtypes.tt Bug 42564: Upgrade Font Awesome in the staff interface to 7.2 2026-06-19 12:00:10 +00:00
background_jobs.tt Bug 42280: Tidy all script tags - admin 2026-07-20 09:15:56 +00:00
biblio_framework.tt Bug 42280: Tidy all script tags - admin 2026-07-20 09:15:56 +00:00
branch_transfer_limits.tt Bug 42280: Tidy all script tags - admin 2026-07-20 09:15:56 +00:00
branches.tt Bug 42280: Tidy all script tags - admin 2026-07-20 09:15:56 +00:00
cash_registers.tt Bug 40113: Update accounting admin pages to use grid layout for forms 2026-04-29 09:09:17 -06:00
categories.tt Bug 42280: (RM follow-up) Tidy categories.tt 2026-07-20 09:16:04 +00:00
checkmarc.tt Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
circulation_triggers.tt Bug 10190: (follow-up) Add missing CSP nonce to inline script tag 2026-09-10 14:25:08 +00:00
cities.tt Bug 42111: Update various admin pages to use grid layout for forms - Part 1 2026-08-21 15:58:23 +00:00
classsources.tt Bug 42111: Update various admin pages to use grid layout for forms - Part 1 2026-08-21 15:58:23 +00:00
clone-rules.tt Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
columns_settings.tt Bug 42280: Tidy all script tags - admin 2026-07-20 09:15:56 +00:00
credit_types.tt Bug 40113: Update accounting admin pages to use grid layout for forms 2026-04-29 09:09:17 -06:00
curbside_pickup.tt Bug 42280: (QA follow-up) Split JS in curbside_pickup to TT and non TT block. Auto tidy 2026-07-20 09:15:58 +00:00
currency.tt Bug 42280: Tidy all script tags - admin 2026-07-20 09:15:56 +00:00
debit_types.tt Bug 40113: Update accounting admin pages to use grid layout for forms 2026-04-29 09:09:17 -06:00
desks.tt Bug 40113: Update accounting admin pages to use grid layout for forms 2026-04-29 09:09:17 -06:00
didyoumean.tt Bug 38365: Add CSP nonces to all inline script and style tags 2026-03-16 11:57:42 +01:00
edi_accounts.tt Bug 42280: Tidy all script tags - admin 2026-07-20 09:15:56 +00:00
edi_ean_accounts.tt Bug 42564: Upgrade Font Awesome in the staff interface to 7.2 2026-06-19 12:00:10 +00:00
file_transports.tt Bug 42656: Improve file transport test display 2026-08-06 16:05:19 +00:00
float_limits.tt Bug 42330: Tidy 2026-09-04 11:23:17 +00:00
identity_provider_domains.tt Bug 42280: Tidy all script tags - admin 2026-07-20 09:15:56 +00:00
identity_providers.tt Bug 38365: Add CSP nonces to all inline script and style tags 2026-03-16 11:57:42 +01:00
ill_batch_statuses.tt Bug 39567: Remove form-submit includes from tt files 2025-05-15 08:34:01 +02:00
item_circulation_alerts.tt Bug 42280: Tidy all script tags - admin 2026-07-20 09:15:56 +00:00
items_search_field.tt Bug 42118: Update various admin pages to use grid layout for forms - Part 2 2026-07-28 14:33:03 +00:00
items_search_fields.tt Bug 39685: Typo: authorised value in item search fields 2025-05-07 14:29:54 +02:00
itemtypes.tt Bug 41649: Add option to set magnetic flag for item itemtypes 2026-08-06 16:07:33 +00:00
koha2marclinks.tt Bug 38365: Add CSP nonces to all inline script and style tags 2026-03-16 11:57:42 +01:00
library_groups.tt Bug 43319: Remove event attribute from library_groups.tt 2026-09-09 15:49:56 +00:00
localization.tt Bug 42280: Tidy all script tags - admin 2026-07-20 09:15:56 +00:00
marc-overlay-rules.tt Bug 42975: (bug 35380 follow-up) Fix patron category filtering on Record overlay rules 2026-09-03 10:56:50 +00:00
marc_order_accounts.tt Bug 42568: Match maxlength attributes to marc_order_accounts column sizes 2026-07-16 10:54:16 +00:00
marc_subfields_structure.tt Bug 42280: Tidy all script tags - admin 2026-07-20 09:15:56 +00:00
marctagstructure.tt Bug 38365: Add CSP nonces to all inline script and style tags 2026-03-16 11:57:42 +01:00
matching-rules.tt Bug 42280: (QA follow-up) Split JS in matching-rules to TT and non TT block. Auto tidy 2026-07-20 09:15:59 +00:00
oai_servers.tt Bug 42118: Update various admin pages to use grid layout for forms - Part 2 2026-07-28 14:33:03 +00:00
oai_set_mappings.tt Bug 42118: Update various admin pages to use grid layout for forms - Part 2 2026-07-28 14:33:03 +00:00
oai_sets.tt Bug 42118: Update various admin pages to use grid layout for forms - Part 2 2026-07-28 14:33:03 +00:00
overdrive.tt Bug 38365: Add CSP nonces to all inline script and style tags 2026-03-16 11:57:42 +01:00
patron-attr-types.tt Bug 42641: JavaScript errors on patron attribute types admin page 2026-06-19 12:00:09 +00:00
preferences.tt Bug 42280: (QA follow-up) Split JS in preferences to TT and non TT block. Auto tidy 2026-07-20 09:16:00 +00:00
record_sources.tt Bug 41367: Add AdminMenu island and integrate into Record sources 2026-03-20 11:54:31 +00:00
restrictions.tt Bug 42280: (QA follow-up) Split JS in restrictions to TT and non TT block. Auto tidy 2026-07-20 09:16:01 +00:00
search_filters.tt Bug 42104: The term ID should be capitalized 2026-04-29 09:09:30 -06:00
share_content.tt Bug 38365: Add CSP nonces to all inline script and style tags 2026-03-16 11:57:42 +01:00
smart-rules.tt Bug 43072: Show Yes when no rule exists for fill_other_biblio_holds_policy 2026-09-01 15:42:09 +00:00
sms_providers.tt Bug 42118: Update various admin pages to use grid layout for forms - Part 2 2026-07-28 14:33:03 +00:00
smtp_servers.tt Bug 42118: Update various admin pages to use grid layout for forms - Part 2 2026-07-28 14:33:03 +00:00
sru_modmapping.tt Bug 42330: Tidy 2026-09-04 11:23:17 +00:00
sru_modmapping_auth.tt Bug 42330: Tidy 2026-09-04 11:23:17 +00:00
systempreferences.tt Bug 42564: Upgrade Font Awesome in the staff interface to 7.2 2026-06-19 12:00:10 +00:00
transfer_limits.tt Bug 42280: (QA follow-up) Split JS in transfer_limits to TT and non TT block. Auto tidy 2026-07-20 09:16:02 +00:00
transport-cost-matrix.tt Bug 38365: Add CSP nonces to all inline script and style tags 2026-03-16 11:57:42 +01:00
usage_statistics.tt Bug 42280: (QA follow-up) Split JS in uage_statistics to TT and non TT block. Auto tidy 2026-07-20 09:16:03 +00:00
z3950servers.tt Bug 42280: Tidy all script tags - admin 2026-07-20 09:15:56 +00:00