Koha-clms/misc
Thomas Klausner 01d36c5e8b
Bug 37020: (follow-up) Fix txn handling, loop label and record_number counter
So, I reviewed the code, which has a bunch of issues:

* there's a call to `next RECORD`, but no `RECORD` loop label.
* $record_number is incremented twice
* and the calls to txn_begin is moved from the outside the loop into each record, starting one transaction per record. Not sure how mysql handles this, but postgres would not like it.

This patch fixes those issues:

After I fixed the first two issues, I ran the patched script on a file containing 75 authorities (from GND), and not one was added to the DB, presuambly because nested transactions don't work in mysql?

So I also moved the BEGIN transaction outside of the main loop and started a new one after each commit, and added a final commit after to loop.

Signed-off-by: Jan Kissig <bibliothek@th-wildau.de>
Signed-off-by: Thomas Klausner <domm@plix.at>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-12 18:31:11 +02:00
..
admin Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
bin Bug 39325: (QA follow-up) Adjust some issues 2025-04-28 18:51:30 +02:00
cronjobs Bug 39325: Manual fixes 2025-04-28 18:51:23 +02:00
devel Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
interface_customization Bug 23148: Replace Bridge icons with transparent PNG files 2020-07-20 16:16:37 +02:00
maintenance Bug 39325: Manual fixes 2025-04-28 18:51:23 +02:00
migration_tools Bug 37020: (follow-up) Fix txn handling, loop label and record_number counter 2025-05-12 18:31:11 +02:00
release_notes 24.11.00: Add missing manual contributors to release notes 2024-12-03 14:36:23 +01:00
search_tools Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
translator Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
workers Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
add_date_fields_to_marc_records.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
add_statistics_borrowers_categorycode.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
batchCompareMARCvsFrameworks.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
batchDeleteUnusedSubfields.pl Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
batchImportMARCWithBiblionumbers.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
batchRebuildBiblioTables.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
batchRebuildItemsTables.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
batchRepairMissingBiblionumbers.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
batchdeletebiblios.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
check_sysprefs.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
commit_file.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
export_borrowers.pl Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
export_records.pl Bug 36770: (QA follow-up) Tidy export_records.pl 2024-08-09 18:44:54 +02:00
import_patrons.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
koha-install-log Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-17 10:07:36 +02:00
link_bibs_to_authorities.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
load_yaml.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
mod_zebraqueue.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
process_ill_updates.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
recreateIssueStatistics.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
sax_parser_print.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
sax_parser_test.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
sip_cli_emulator.pl Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
stage_file.pl Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
z3950_responder.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00