gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 41201: Removed definite article from hold and cart 

This patch removes the definite article from some labels, so that their
visual and hidden labels are in sync.

== TO TEST ==
a)  (optionally) read the patch code to understand what locations have change
b)  inspect the code on the results and details pages
c)  note that some visual and hidden labels differ
    *)  specifically, the add to cart and place hold labels
== APPLY PATCH ==
d)  repeat step b)
e)  notice now that the visual and hidden labels match
== SIGN OFF ==

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Jake Deery 2025-10-02 12:21:48 +00:00 committed by Lucas Gass
parent a9c1583675
commit f40387ed12
No known key found for this signature in database
GPG Key ID: 60B447398B0D36CA
3 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
View File

@ -27,7 +27,7 @@
>[% FILTER collapse %]
[% UNLESS ( multi_hold ) %]
[% title_in_title = INCLUDE 'biblio-title-head.inc' %]
[% tx("Place a hold on {title}", { title = title_in_title }) | html %]
[% tx("Place hold on {title}", { title = title_in_title }) | html %]
&rsaquo;
[% ELSE %]
[% t("Confirm holds") | html %]
@ -286,7 +286,7 @@
[% END %]
[% UNLESS ( multi_hold ) %]
<h2>Place a hold on [% INCLUDE 'biblio-title.inc' link = 1 %] [% IF biblio.author %]by [% biblio.author | html %][% END %]</h2>
<h2>Place hold on [% INCLUDE 'biblio-title.inc' link = 1 %] [% IF biblio.author %]by [% biblio.author | html %][% END %]</h2>
[% ELSE %]
<h2>
[% IF ( patron ) %]

8
koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc
View File

@ -4,14 +4,14 @@
[% IF ( shelf AND op == 'view' ) # Lists view has more granular checking of hold availability %]
[% IF ( items.allow_onshelf_holds ) %]
<span class="actions"
><a class="btn btn-link btn-sm" aria-label="Place a hold on [% items.title | html %]" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]"
><a class="btn btn-link btn-sm" aria-label="Place hold on [% items.title | html %]" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]"
><i class="fa fa-fw fa-bookmark" aria-hidden="true"></i> Place hold</a
></span
>
[% ELSE %]
[% IF ( items.itemsissued ) %]
<span class="actions"
><a class="btn btn-link btn-sm" aria-label="Place a hold on [% items.title | html %]" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]"
><a class="btn btn-link btn-sm" aria-label="Place hold on [% items.title | html %]" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]"
><i class="fa fa-fw fa-bookmark" aria-hidden="true"></i> Place hold</a
></span
>
@ -19,7 +19,7 @@
[% END %]
[% ELSE %]
<span class="actions"
><a class="btn btn-link btn-sm" aria-label="Place a hold on [% items.title | html %]" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]"
><a class="btn btn-link btn-sm" aria-label="Place hold on [% items.title | html %]" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]"
><i class="fa fa-fw fa-bookmark" aria-hidden="true"></i> Place hold</a
></span
>
@ -87,7 +87,7 @@
>
[% ELSE %]
<span class="actions cart-actions"
><a aria-label="Add [% items.title | html %] to the cart" data-biblionumber="[% items.biblionumber | html %]" class="btn btn-link btn-sm addtocart cart cart[% items.biblionumber | html %]" href="#"
><a aria-label="Add [% items.title | html %] to cart" data-biblionumber="[% items.biblionumber | html %]" class="btn btn-link btn-sm addtocart cart cart[% items.biblionumber | html %]" href="#"
><i class="fa fa-fw fa-shopping-cart" aria-hidden="true"></i> Add to cart</a
>
<a style="display:none;" data-biblionumber="[% items.biblionumber | html %]" class="btn btn-link btn-sm remove cartRemove cartR[% items.biblionumber | html %]" href="#">(remove)</a></span

6
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
View File

@ -169,7 +169,7 @@
id="single_[% bibitemloo.biblionumber | html %]"
value="any"
/>
<label class="confirm_label" for="single_[% bibitemloo.biblionumber | html %]">Place a hold on </label>
<label class="confirm_label" for="single_[% bibitemloo.biblionumber | html %]">Place hold on </label>
</span>
[% END # / bibitemloo.holdable %]
@ -598,13 +598,13 @@
$(".confirmjs_hold").each(function(){
var bib = $(this).attr("title");
var html = "<label><input type =\"checkbox\" class=\"confirmjs\" checked=\"checked\"";
html += "value=\"" + bib + "\" id=\"" + bib + "\" /> " + _("Place a hold on") + " </label> ";
html += "value=\"" + bib + "\" id=\"" + bib + "\" /> " + _("Place hold on") + " </label> ";
$(this).html(html);
});
$(".confirmjs_nohold").each(function(){
var bib = $(this).attr("title");
var html = "<label><input type =\"checkbox\" class=\"confirmjs\" disabled=\"disabled\"";
html += "value=\"" + bib + "\" id=\"" + bib + "\" />" + _("Place a hold on: ") + "</label>";
html += "value=\"" + bib + "\" id=\"" + bib + "\" />" + _("Place hold on: ") + "</label>";
$(this).html(html);
});