gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 40061: (follow-up) Delete last image using checkbox 

This followup corrects a problem in image deletion which isn't really
the same issue (it's not CSRF related) but is another problem with
deletion. The JS for grabbing all the checkboxes by name wasn't working
when there is only one checkbox.

To test, apply the patch and delete all but one image from the patron
card creator image manager.

- Check the checkbox for the last image and click the "Delete selected"
  button.
- The image should be deleted successfully.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Owen Leonard 2025-06-04 18:16:44 +00:00 committed by Lucas Gass
parent 3f3bfcfa66
commit 727b9d2dde
No known key found for this signature in database
GPG Key ID: 60B447398B0D36CA
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt
View File

@ -175,10 +175,11 @@
function selected_images() {
var image_ids = new Array();
if (document.delete_images.image_id.length) {
for (i = 0; i < document.delete_images.image_id.length; i++) {
if (document.delete_images.image_id[i].checked) {
image_ids.push(document.delete_images.image_id[i].value);
let checkboxes = document.getElementsByName("image_id");
if (checkboxes.length) {
for (i = 0; i < checkboxes.length; i++) {
if (checkboxes[i].checked) {
image_ids.push(checkboxes[i].value);
}
}
}