From 727b9d2dde7fd76013fd2d69bcd055ee5c8521a7 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 4 Jun 2025 18:16:44 +0000 Subject: [PATCH] Bug 40061: (follow-up) Delete last image using checkbox This followup corrects a problem in image deletion which isn't really the same issue (it's not CSRF related) but is another problem with deletion. The JS for grabbing all the checkboxes by name wasn't working when there is only one checkbox. To test, apply the patch and delete all but one image from the patron card creator image manager. - Check the checkbox for the last image and click the "Delete selected" button. - The image should be deleted successfully. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass --- .../prog/en/modules/patroncards/image-manage.tt | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt index c7b9d207e3..077eaadc19 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt @@ -175,10 +175,11 @@ function selected_images() { var image_ids = new Array(); - if (document.delete_images.image_id.length) { - for (i = 0; i < document.delete_images.image_id.length; i++) { - if (document.delete_images.image_id[i].checked) { - image_ids.push(document.delete_images.image_id[i].value); + let checkboxes = document.getElementsByName("image_id"); + if (checkboxes.length) { + for (i = 0; i < checkboxes.length; i++) { + if (checkboxes[i].checked) { + image_ids.push(checkboxes[i].value); } } }