gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/admin
History
Lucas Gass 7bee48e482
Bug 41882: Enforce pickup location rules 
To test:
1- Set ReservesControlBranch to 'item's home library'
2- Set Main library's 'Holds and bookings policies by item type' so that PASS items can only be picked up at Main
3- Place a hold on a bib whose only item is a PASS belonging to Main
4- Use the Batch hold modification tool to identify the hold you just placed
5- Update the pickup location to North. Note that the update is successful, and there's no indication that the pickup location is now a problem.
6- Check in Main's PASS, and note that the hold doesn't trigger to fill
7- APPLY PATCH, restart_all
8- Try again, this time the hold should fail to update at all.
9- You should see a new table with the 'Failed hold' in it, it should also include a 'Result' column which explains why the hold failed (New pickup location is invalid).
10- Try modifying a hold to an invalid pickup location, but also attempt to modify something else on the hold at the same time, like expiration date.
11- The hold should not modify anything. If the pickup location is invalid all other modifications should NOT happen on that hold.
12 - Play with the Table settings for the holds_modified tables, ensuring you can hide/show all the columns.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit cc3b7cebf5)
Signed-off-by: Jacob O'Mara <Jacob.omara@openfifth.co.uk>
 		2026-05-24 13:42:23 +01:00
..
searchengine/elasticsearch Bug 42156: Add a stdno index for authid 2026-05-24 13:42:20 +01:00
additional-fields.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
admin-home.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
adveditorshortcuts.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
aqbudgetperiods.pl Bug 41561: Remove 'tab' from admin/aqbudgetperiods 2026-03-14 12:21:05 +00:00
aqbudgets.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
aqcontract.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
aqplan.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
audio_alerts.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
auth_subfields_structure.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
auth_tag_structure.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
authorised_values.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
authtypes.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
background_jobs.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
biblio_framework.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
branch_transfer_limits.pl Bug 41131: Don't allow limiting transfers from/to a single branch 2026-04-13 08:50:10 +01:00
branches.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
cash_registers.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
categories.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
check_budget_parent.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
check_parent_total.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
checkmarc.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
cities.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
classsources.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
clone-rules.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
columns_settings.pl Bug 40680: Fix admin/columns_settings.pl 2025-12-01 08:33:58 -07:00
columns_settings.yml Bug 41882: Enforce pickup location rules 2026-05-24 13:42:23 +01:00
credit_types.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
curbside_pickup.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
currency.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
debit_types.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
desks.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
didyoumean.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
edi_accounts.pl Bug 20253: Optionally use buyer's purchase order number from EDIFACT quote as basket name 2025-11-03 14:13:37 -07:00
edi_ean_accounts.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
file_transports.pl Bug 41798: Fix FTP passive mode not saving and add display indicator 2026-03-23 11:55:08 +00:00
identity_providers.pl Bug 37711: Domains CRUD update 2025-11-05 07:12:32 -07:00
ill_batch_statuses.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
import_export_authtype.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
import_export_framework.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
item_circulation_alerts.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
items_search_field.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
items_search_fields.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
itemtypes.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
koha2marclinks.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
library_groups.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
localization.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
marc-overlay-rules.pl Bug 35380: (QA follow-up) Minor code quality fixes 2026-05-24 13:42:13 +01:00
marc_order_accounts.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
marc_subfields_structure.pl Bug 38384: (follow-up) move require Koha::Plugins to use 2026-04-10 14:18:50 +01:00
marctagstructure.pl Bug 39825: Add a direct link to items tag in MARC bibliographic framework page 2025-11-03 14:13:43 -07:00
matching-rules.pl Bug 40680: Fix admin/matching-rules.pl 2025-12-01 08:33:58 -07:00
oai_servers.pl Bug 41043: Use op 'add_form' and 'edit_form' in oai servers 2026-03-16 13:23:09 +00:00
oai_set_mappings.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
oai_sets.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
overdrive.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
patron-attr-types.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
preferences.pl Bug 41076: [25.11.x] Adjust perl tidiness for v20250105 2026-03-16 13:23:08 +00:00
record_sources.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
restrictions.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
search_filters.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
share_content.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
smart-rules.pl Bug 41267: Add fill_other_biblio_holds_policy circulation rule 2026-05-24 13:42:15 +01:00
sms_providers.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
smtp_servers.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
sru_modmapping.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
systempreferences.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
transfer_limits.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
transport-cost-matrix.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
usage_statistics.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
z3950servers.pl Bug 41043: Use op 'add_form' and 'edit_form' in z3950 servers 2026-03-16 13:23:09 +00:00