Go to file
Nick Clemens fd609d9bb3
Bug 39282: Clarify use of budget codes and ids
When getting items from the form on addorderiso2709.pl we are getting actual budget id's,
we only deal with codes when fetching the values from the MARC.
The code here assigns an id into a variable called code - this patch clarifies that and
ensures that we fallback to using the id if one has been passed from the interface form

To test:
0 - Apply first two patches
1 - prove -v t/db_dependent/Koha/MarcOrders.t
2 - It fails
3 - Apply this patch
4 - It fails?

Signed-off-by: John Vinke <jvinke@austinseminary.edu>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-03-17 08:21:20 +01:00
C4 Bug 39313: Make OpacTrustedCheckout self-checkout modal accept valid barcode 2025-03-17 08:21:18 +01:00
Koha Bug 39282: Clarify use of budget codes and ids 2025-03-17 08:21:20 +01:00
acqui Bug 39044: Pass budgets to template 2025-02-13 15:31:00 +01:00
admin Bug 38663: (follow-up) Fix new library creation 2025-03-10 11:42:29 +01:00
api Bug 39260: Fix typo in acquisitions baskets API docs 2025-03-07 15:41:17 +01:00
authorities Bug 30975: Use event delegation for framework plugins 2025-02-27 17:32:33 +01:00
basket Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
bin
…
bookings Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
catalogue Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
cataloguing Bug 39213: Force scalar on query param barcode 2025-03-07 15:41:15 +01:00
circ Bug 39302: Restore item's info 2025-03-13 10:29:21 +01:00
clubs Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
course_reserves Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
debian Bug 38944: Update debian/control 2025-03-13 17:25:07 +01:00
docs Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
erm Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
errors Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
etc Bug 36954: (follow-up) Return to the two logfiles pattern 2025-02-18 10:55:27 +01:00
ill Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
installer Bug 35635: Add missing NOT NULL clause in db rev 2025-03-11 14:42:03 +01:00
koha-tmpl Bug 39244: Fix display of change password/duplicate buttons 2025-03-13 10:29:24 +01:00
labels Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
lib Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
members Bug 23674: Add ability to add note to canceled charge 2025-03-10 11:42:36 +01:00
misc Bug 38408: (QA follow-up) Rename --forks, add usage 2025-03-17 08:21:17 +01:00
offline_circ Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac Bug 32051: Rename Library to Contact for one public library 2025-03-07 18:02:55 +01:00
patron_lists Bug 37266: patron_lists/delete.pl should have CSRF protection 2025-03-06 13:54:49 +01:00
patroncards Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
plugins Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
pos Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
preservation Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
recalls Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
reports Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
reserve Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
reviews Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
rotating_collections Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
serials Bug 34971: (QA follow-up) Op is now cud-reopen 2025-02-12 15:28:17 +01:00
services Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
skel
…
suggestion Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
svc Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
t Bug 39282: Ensure items are created using Item Information values if not using MarcItemFieldsToOrder 2025-03-17 08:21:20 +01:00
tags Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
tools Bug 26744: (QA follow up) Tidy 2025-03-10 11:42:32 +01:00
virtualshelves Bug 37434: Sort by publicationyear when copyrightdate is set in UNIMARC 2025-02-13 16:18:02 +01:00
xt Bug 39149: Make perltidy.t also check .PL files 2025-02-18 15:35:53 +01:00
.editorconfig
…
.git-blame-ignore-revs Bug 39096: Add 'tidy all' commits to a git blame ignore file 2025-02-17 13:10:25 +01:00
.gitignore Bug 35402: Update the OPAC and staff interface to Bootstrap 5 2024-08-23 15:58:41 +02:00
.htaccess
…
.mailmap 24.11.00: Update .mailmap 2024-11-25 13:16:42 +01:00
.perlcriticrc
…
.perltidyrc
…
.prettierrc.js Bug 38664: Treat .vue files like other JS files 2025-02-11 14:58:25 +01:00
.proverc.dist
…
.stylelintrc.json
…
INSTALL
…
Koha.pm Bug 38663: DBRev 24.12.00.018 2025-03-10 11:42:30 +01:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 39149: Tidy .PL files 2025-02-18 15:35:53 +01:00
README
…
README.md
…
README.robots
…
about.pl Bug 39154: Add sip.log test in about 2025-03-07 18:02:58 +01:00
app.psgi Bug 36149: Add userenv middleware to app.psgi 2024-05-14 15:04:37 -03:00
build-resources.PL
…
changelanguage.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
cpanfile Bug 38944: Add new dependency Test::NoWarnings 2025-03-13 17:25:03 +01:00
cypress.config.ts Bug 38770: Remove @vue/cli-service and babel 2025-01-16 15:56:15 +01:00
eslint.config.mjs Bug 38524: Enable ESLint for .ts and .vue files 2025-01-16 15:56:17 +01:00
fix-perl-path.PL Bug 39149: Tidy .PL files 2025-02-18 15:35:53 +01:00
gulpfile.js Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
help.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
kohaversion.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
mainpage.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
package.json Bug 38664: Bump the version of the prettier plugin 2025-02-11 22:31:25 +01:00
rewrite-config.PL Bug 39149: Tidy .PL files 2025-02-18 15:35:53 +01:00
rspack.config.js Bug 37824: (QA follow-up) Fix improper handling of jQuery and DataTables libraries by marking them as externals 2024-09-16 18:41:17 +02:00
tsconfig.json
…
webpack.config.js Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
yarn.lock Bug 38664: Update yarn.lock 2025-02-11 22:31:26 +01:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo