Go to file
Marcel de Rooy f53b6ec248 Bug 17380: Do not use GuessAuthTypeCode in MetadataRecord::Authority
If we got an authtypecode from the database and this value is not NULL
since the table column does not allow it, there is no need to call
GuessAuthTypeCode for empty string (read: Default framework) in the
sub get_from_authid.

Furthermore, we remove three Koha::MetadataRecord::Authority->new calls.
They are useless, since we do not pass a record. It just generates:
  No record passed at authorities/merge.pl line 96.
  Can't bless non-reference value at Koha/MetadataRecord/Authority.pm line 66.
Instead we throw an ObjectNotFound exception.

Test plan:
[1] Run t/db_dependent/Koha_Authority.t
[2] Interface will be tested in the following patches.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit db35492c79)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-10-23 15:56:39 +02:00
C4 Bug 19120: Leave cancelled ordered items alone when reopening basket 2017-10-17 09:50:10 +02:00
Koha Bug 17380: Do not use GuessAuthTypeCode in MetadataRecord::Authority 2017-10-23 15:56:39 +02:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 19372: (bug 15801 follow-up) pass selected frameworkcode to the template 2017-10-17 10:14:21 +02:00
admin Bug 18351: Able to delete budget with funds 2017-10-10 12:05:11 +02:00
api/v1 Bug 18763: Fix swagger/definitions.t 2017-06-20 10:19:55 +02:00
authorities Bug 17380: Do not use GuessAuthTypeCode in MetadataRecord::Authority 2017-10-23 15:56:39 +02:00
basket Bug 18124: Change the calls to generate and check CSRF tokens 2017-03-30 09:07:09 +00:00
catalogue Bug 19440: Existing calls need to be done in scalar context 2017-10-17 09:06:51 +02:00
cataloguing Revert "Bug 18295: C4::Items - Remove get_itemnumbers_of" 2017-06-12 09:17:26 +02:00
circ Bug 18469: QA Follow-up 2017-09-29 12:07:31 +02:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 18367 - (QA Followup) Only warn if doing a lookup and not having an item 2017-07-31 10:48:32 +02:00
debian Bug 9409: (QA followup) Add --dbhost help to koha-create man page 2017-09-29 12:17:35 +02:00
docs Bug 7143: Add Patricio Marrone to history.txt 2017-03-31 13:45:33 +00:00
errors Bug 15288: Error pages: Code duplication removal and better translatability 2016-01-27 05:57:34 +00:00
etc Bug 18669 - RewriteCond affecting wrong rule in koha-httpd.conf 2017-05-28 22:30:11 -04:00
installer Bug 18801: DBRev 17.05.00.003 2017-10-23 15:56:38 +02:00
koha-tmpl Bug 18801 - Merging authorities has an invalid 'Default' type in the merge framework selector 2017-10-23 15:56:38 +02:00
labels Revert "Bug 18295: C4::Items - Remove get_itemnumbers_of" 2017-06-12 09:17:26 +02:00
members Bug 19117: Add CSRF protection to paycollect.pl 2017-10-23 14:28:22 +02:00
misc Bug 18811: Add a script for checking authority data in hidden fields 2017-10-23 15:32:14 +02:00
offline_circ Bug 17501: Remove Koha::Upload::get from Koha::Upload 2017-01-20 14:20:05 +00:00
opac Bug 18956: Fix empty to in message queue 2017-10-23 14:28:02 +02:00
patron_lists Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
patroncards Bug 18246: Patron card creator: Unit not always displays properly in layouts 2017-03-22 20:58:10 +00:00
plugins Bug 19088: plugins-upload causes error log noise 2017-09-29 15:34:42 +02:00
reports Bug 18898 - Some permissions for Reports can be bypassed 2017-09-12 15:45:48 +02:00
reserve Revert "Bug 18295: C4::Items - Remove get_itemnumbers_of" 2017-06-12 09:17:26 +02:00
reviews Bug 15839: Koha::Reviews - Remove C4::Review residue 2016-09-09 10:31:00 +00:00
rotating_collections Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
serials Bug 19323: subscription edit permission issue 2017-10-17 09:55:43 +02:00
services Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
sms Bug 15258: Fix Perl scripts declaring unused variables 2015-12-30 17:24:45 -07:00
suggestion Bug 18839: Suggestion.pl spelling mistake 2017-07-27 16:30:17 +02:00
svc Bug 17898: Automagically convert SQL reports 2017-05-19 18:48:26 +00:00
t Bug 18811: [QA Follow-up] Add tests for Koha::Authority::Subfields/Tags 2017-10-23 15:32:37 +02:00
tags Bug 5471: Use uri_escape_utf8 to handle utf8 chars correctly 2017-09-29 11:17:17 +02:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities
…
tools Bug 19023 - inventory tool performance 2017-09-12 17:09:51 +02:00
virtualshelves Bug 7663: Fix bad merge conflict with bug 15584 2017-03-03 18:18:14 +00:00
xt Bug 19262: Remove xt/author/pod_spell.t 2017-10-23 15:29:50 +02:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.htaccess
…
.mailmap Update mailmap - Jonathan Druart 2017-06-29 09:33:25 +02:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Bug 18801: DBRev 17.05.00.003 2017-10-23 15:56:38 +02:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 19067: Map clubs/ into INTRANET_CGI_DIR in Makefile.PL 2017-09-12 16:04:02 +02:00
README
…
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots
…
about.pl Bug 18931 - Follow up - Typo fix in SQL statement 2017-07-27 10:25:20 +02:00
changelanguage.pl Bug 16776: Do not forget external language choice in language switcher 2016-08-10 13:51:33 +00:00
edithelp.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-05 21:28:14 +00:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
help.pl Bug 16724: Fix link to the online documentation links 2016-06-24 12:00:42 +00:00
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
koha_perl_deps.pl Bug 17990: Refactor Perl module versions check 2017-02-17 12:13:44 +00:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 18432 : Follow up - Updating to use they/them 2017-04-21 10:56:43 -04:00
rewrite-config.PL Bug 15427 : Enable TLS support for MySQL 2017-03-03 18:33:07 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo