gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/C4/SIP
History
Kyle M Hall 69392c8020 Bug 27204: Fix end boundary index, never return results for non-existant accountlines 
There are two primary issues I've identified with requesting line items
for fees via SIP:

1) The end boundary is incorrect. For example, if send a request with a
BP ( starting item) of 1, and a BQ (end item) of 1, I should get just
the first item. Instead I will get two items

2) Our SIP server does not check bounds. For example, if I have 3 fines,
but I send a BP of 1 and a BQ of 5, I will get back 5 AVs, two of
them being "empty" because the patron only has 3 accountlines!

Test Plan:
1) Apply the unit test patch
2) prove t/db_dependent/SIP/Patron.t
3) Note the failures
4) Apply the second patch
5) prove t/db_dependent/SIP/Patron.t
6) All tests should pass!

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 0a5232412f)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 0ebfff111d)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
 		2021-02-09 12:43:35 +00:00
..
ILS Bug 27204: Fix end boundary index, never return results for non-existant accountlines 2021-02-09 12:43:35 +00:00
Sip Bug 25903: Sending a SIP patron information request with a summary field flag in indexes 6-9 will crash server 2020-09-04 17:59:48 +00:00
t Bug 18432 : Follow up - Updating to use they/them 2017-04-21 10:56:43 -04:00
ILS.pm Bug 25808: Renewal via the SIP 'checkout' message gives incorrect message 2021-02-01 21:50:50 +00:00
ILS.pod Bug 13506 [QA Follouwp] - Fix POD 2015-02-20 11:54:41 -03:00
Logger.pm Bug 26673: Remove shebangs from Perl modules 2020-11-13 21:04:25 +00:00
Makefile
…
README Bug 15253: Rename syslog() to siplog() 2020-05-12 11:46:46 +01:00
SIPServer.pm Bug 26673: Remove shebangs from Perl modules 2020-11-13 21:04:25 +00:00
Sip.pm Bug 15253: Convert all tabs into 4 spaces in affected files 2020-05-12 11:47:01 +01:00
Trapper.pm Bug 15253: Add POD to C4/SIP/Logger.pm and C4/SIP/Trapper.pm 2020-05-12 11:47:04 +01:00
acstest.py
…
example_institution_dump.sh Bug 7904 Change SIP modules to use standard LIB path 2015-02-05 14:44:54 -03:00
interactive_item_dump.pl Bug 17196: Move marcxml out of the biblioitems table 2017-01-13 13:49:26 +00:00
interactive_patron_check_password.pl Bug 7904 Change SIP modules to use standard LIB path 2015-02-05 14:44:54 -03:00
interactive_patron_dump.pl Bug 7904 Change SIP modules to use standard LIB path 2015-02-05 14:44:54 -03:00
interactive_renew_all_dump.pl Bug 7904 Change SIP modules to use standard LIB path 2015-02-05 14:44:54 -03:00
test.txt
…
xmlparse.pl Bug 7904 Change SIP modules to use standard LIB path 2015-02-05 14:44:54 -03:00

README 

README for Open NSIP 3M-SIP Server

DEPENDENCIES

SIPServer is written entirely in Perl, but it require these CPAN
perl modules to run:

     Net::Server - The SIP server is a Net::Server::Prefork server
     XML::LibXML
     XML::Parser
     XML::Simple - for parsing the config file
     UNIVERSAL::require - for loading the correct ILS interface module
     Clone - for running the test cases

LOGGING

SIPServer uses Koha::Logger for status and debugging messages.