gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/admin
History
Jonathan Druart f8c8d6df0a Bug 22786: Prevent fund creation for locked budgets 
If a budget is locked, there is a "New fund for $budget" link that is
disabled but clickable.
We should ensure that the link is not clickable and prevent it at
controller level (do we need it at module level, ie.
Koha::Acquisition::Fund->store?)

Test plan:
- Create a budget, lock it
- Go to /cgi-bin/koha/admin/aqbudgetperiods.pl
- Click on the name of the budget you just created
=> The "New > New fund for $budget_name" button should be disabled
- Click it anyway
=> Without this patch the form to add a new fund is displayed
=> With this patch applied nothing happens
- Hit /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_period_id=XXX
With XXX the budget's id
=> Without this patch the form is displayed
=> With this patch applied you get a message:
  "The budget is locked, fund creation is not possible."
And you are not able to create a new fund

QA notes:
1. See description
2. The add_validate op can still be forced, let trust librarians with
administration permissions for now.

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 9215ca42d2)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 8d5a50384f)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
 		2019-09-21 15:31:28 +00:00
..
searchengine/elasticsearch Bug 22524: Fix publication date and year search with Elasticsearch 2019-08-31 03:35:36 +00:00
add_user_search.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
admin-home.pl Bug 20383: Hide link to plugin management if plugins are not enabled 2018-03-19 13:55:53 -03:00
aqbudgetperiods.pl Bug 19328: Internal server error because of missing currency 2017-10-11 13:05:31 -03:00
aqbudgets.pl Bug 22786: Prevent fund creation for locked budgets 2019-09-21 15:31:28 +00:00
aqcontract.pl Bug 19992: use Modern::Perl in Admin perl scripts 2018-02-05 09:45:46 -03:00
aqplan.pl Bug 21137: Replace USER_INFO with logged_in_user 2018-08-14 12:43:10 +00:00
audio_alerts.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
auth_subfields_structure.pl Bug 21706: (follow-up) Fix subfield delete button 2018-11-12 16:39:50 -03:00
auth_tag_structure.pl Bug 21706: (follow-up) remove unused template params 2018-11-12 16:39:04 -03:00
authorised_values.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
authtypes.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
biblio_framework.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
branch_transfer_limits.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
branches.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
categories.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
check_budget_parent.pl Bug 19992: use Modern::Perl in Admin perl scripts 2018-02-05 09:45:46 -03:00
check_parent_total.pl Bug 19992: use Modern::Perl in Admin perl scripts 2018-02-05 09:45:46 -03:00
checkmarc.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
cities.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
classsources.pl Bug 15836: Mark C4::ClassSource subs DEPRECATED 2018-11-13 15:18:22 +00:00
clone-rules.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
columns_settings.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
columns_settings.yml Bug 22020: (bug 21777 follow-up) Fix columns visibility for circulation.pl 2019-01-10 14:13:35 +00:00
currency.pl Bug 7651: Add a new permission for managing currencies and exchange rates 2018-07-18 17:45:21 +00:00
didyoumean.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
edi_accounts.pl Bug 21605: (follow-up) Simple ternary boolean to number conversion 2019-01-10 13:42:04 +00:00
edi_ean_accounts.pl Bug 21417: EDI ordering fails when basket and EAN libraries do not match 2018-10-09 11:54:08 +00:00
fieldmapping.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
import_export_framework.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
item_circulation_alerts.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
items_search_field.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
items_search_fields.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
itemtypes.pl Bug 22575: Item type administration uses invalid error class for dialog 2019-04-15 11:38:54 +01:00
koha2marclinks.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
library_groups.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
localization.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
marc_subfields_structure.pl Bug 23309: Use Koha::MarcSubfieldStructures to create to subfields 2019-09-17 20:17:10 +00:00
marctagstructure.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
matching-rules.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
oai_set_mappings.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
oai_sets.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
overdrive.pl Bug 21082: Update OverDrive authentication method 2018-10-09 11:04:23 +00:00
patron-attr-types.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
preferences.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
printers.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
smart-rules.pl Bug 22648: Fix typo in SQL in smart-rules.pl 2019-04-08 09:56:26 +01:00
sms_providers.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
sru_modmapping.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
systempreferences.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
transport-cost-matrix.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
usage_statistics.pl Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
z3950servers.pl Bug 23242: Fix insert of Z3950 servers with strict SQL modes 2019-09-17 20:24:45 +00:00