Go to file
Pedro Amorim ee4db6d763
Bug 34587: Improve title uniqueness rules
Improve robustness of unique matching here, to make sure we always match for same title if the case,

Some report rows may correspond to the same title as the previous row but have an empty match field, or alternatively come with a filled match field (e.g. DOI or Print_ISSN in TR_J4. Because of this we only verify a uniqueness match field if both current row and previous have it non-empty, otherwise we keep checking the remaining uniqueness match fields.

Example of this use-case, COUNTER report:
title    | publisher | platform  | Proprietary_ID | Print_ISSN | DOI     | YOP  | usages
examplet | examplep  | examplepl | 1              | 123        |        | 2020 | usages
examplet | examplep  | examplepl | 1              | 123        |someDOI | 2021 | usages

The above 2 rows is the same title, same publisher, same proprietary_id,
same Print_ISSN, etc. It just so happens that one was returned by SUSHI
with DOI and the other wasnt.
These 2 rows correspond to different usage statistics by YOP, not 2
different usage_titles

Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com>
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-31 16:46:27 -03:00
C4 Bug 34924: Add 'auto_renew_final' and 'auto_unseen_final' return to CanBookBeRenewed 2023-10-31 11:02:46 -03:00
Koha Bug 34587: Improve title uniqueness rules 2023-10-31 16:46:27 -03:00
acqui Bug 34908: Sort item types alphabetically by description when adding a new empty record as an order to a basket 2023-10-25 12:09:54 -03:00
admin Bug 34587: Usage statistics table column data 2023-10-31 16:45:55 -03:00
api Bug 34587: Add proprietary_id and platform to erm_usage_titles 2023-10-31 16:46:26 -03:00
authorities Bug 33406: (QA follow-up) Adjust tests and tidy 2023-09-15 15:50:43 -03:00
basket Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-12 09:44:59 -03:00
bin
…
catalogue Bug 35099: (bug 26314 follow-up) Fix detail view for records with invalid MARCXML 2023-10-20 11:02:52 -03:00
cataloguing Bug 32853: Fix cataloguing/value_builder/unimarc_field_125.pl 2023-10-30 09:02:15 -03:00
circ Bug 35003: Make cancelled hold requests filter by branch 2023-10-27 16:54:06 -03:00
clubs Bug 25079: Show club enrollment question answers in staff client 2023-06-23 11:00:54 -03:00
course_reserves Bug 20256: Use new methods 2023-02-02 11:59:26 -03:00
debian Bug 25672: Convert to restricting to listed repositories only 2023-10-31 11:02:43 -03:00
docs Bug 34424: Add Emily Lamancusa to QA Team 2023-10-31 11:02:51 -03:00
erm Bug 32922: Remove space in shebang 2023-02-20 09:44:06 -03:00
errors Bug 29420: HTTP status code incorrect when calling error pages directly under Plack/PSGI 2022-04-20 09:03:39 -10:00
etc Bug 25672: Convert to restricting to listed repositories only 2023-10-31 11:02:43 -03:00
ill Bug 30719: ILL Batches 2023-10-17 14:45:15 -03:00
installer Bug 34587: Add proprietary_id and platform to erm_usage_titles 2023-10-31 16:46:26 -03:00
koha-tmpl Bug 34587: Improve SUSHI COUNTER error handling 2023-10-31 16:46:25 -03:00
labels Bug 10762: (QA follow-up) Perltidy 2023-10-25 10:35:31 -03:00
lib/CGI/Session/Serialize
…
members Bug 35127: Fix 'Search type' for patron search 2023-10-25 10:35:26 -03:00
misc Bug 34587: Fix dry run and end date in the cronjob 2023-10-31 16:46:22 -03:00
offline_circ Bug 32496: Reduce unnecessary unblessings of objects in Circulation.pm 2023-09-22 10:52:39 -03:00
opac Bug 31503: Make opac-patron-consent more generic 2023-10-25 10:35:20 -03:00
patron_lists
…
patroncards Bug 24001: Fix patron card template edition 2022-04-28 10:49:20 -10:00
plugins Bug 25672: Fix double output_html_with_http_headers 2023-10-31 11:02:45 -03:00
pos Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-12 09:44:59 -03:00
preservation Bug 34030: Add a "print slips" action links to print in batch 2023-10-23 11:33:55 -03:00
recalls Bug 34013: Recalls awaiting pickup doesn't show count on each tab 2023-06-23 10:01:04 -03:00
reports Bug 34136: (QA follow-up) Perltidy 2023-10-27 16:46:22 -03:00
reserve Bug 31692: Tidy and rebase fix 2023-10-10 09:58:59 -03:00
reviews
…
rotating_collections
…
serials Bug 31846: Add syspref for serials search results limit 2023-10-25 10:35:27 -03:00
services
…
skel
…
suggestion Bug 26994: List names in alphabetical order in Suggestion filter 2023-10-20 16:31:14 -03:00
svc Bug 25393: (QA follow-up) Tidy 2023-10-20 16:31:24 -03:00
t Bug 34587: Move everything into a ERM/EUsage subfolder 2023-10-31 16:46:18 -03:00
tags Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
tools Bug 31383: (QA follow-up) Tidy 2023-10-20 14:44:03 -03:00
virtualshelves Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-12 09:44:59 -03:00
xt Bug 34911: Test files from HEAD instead of 'master' 2023-10-04 09:15:35 -04:00
.editorconfig Bug 27375: Set YAML file settings in .editorconfig 2021-11-03 15:40:52 +01:00
.eslintrc.json
…
.gitignore Bug 34587: Add ability to delete saved reports 2023-10-31 16:46:07 -03:00
.htaccess
…
.mailmap Update .mailmap 2023-06-12 11:52:05 -03:00
.perlcriticrc
…
.perltidyrc Bug 30002: Adjust perltidy 2023-06-08 08:32:42 -03:00
.proverc.dist
…
.stylelintrc.json Bug 31528: (follow-up) A few additional rules 2022-10-03 08:23:15 -03:00
INSTALL
…
Koha.pm Bug 34520: DBRev 23.06.00.055 2023-10-31 11:02:50 -03:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 30708: Add 'preservation' to Makefile.PL 2023-10-20 08:33:34 -03:00
README
…
README.md
…
README.robots
…
about.pl Bug 35033: (QA follow-up): tidy up code 2023-10-31 11:02:53 -03:00
app.psgi
…
build-resources.PL Bug 32609: Use the current yarn.lock to generate node_modules 2023-02-10 11:07:57 -03:00
changelanguage.pl
…
cpanfile Bug 34064: Add SQL::Translator dependency to cpanfile 2023-10-10 10:54:04 -03:00
cypress.config.ts Bug 34319: Upgrade cypress 9.7.0 to 12.17.2 2023-09-05 11:52:25 -03:00
fix-perl-path.PL
…
gulpfile.js Bug 35024: Do not wrap translations 2023-10-19 16:00:47 -03:00
help.pl
…
koha_perl_deps.pl
…
kohaversion.pl
…
mainpage.pl Bug 35019: Add a CSRF token when deleting news 2023-10-20 17:22:02 -03:00
package.json Bug 34319: Upgrade cypress 9.7.0 to 12.17.2 2023-09-05 11:52:25 -03:00
rewrite-config.PL
…
tsconfig.json Bug 32030: Move cypress to t - fix build_js/watch_js 2022-11-08 09:44:52 -03:00
webpack.config.js Bug 30708: Vue app 2023-10-18 15:41:40 -03:00
yarn.lock Bug 34319: Update yarn.lock 2023-09-05 11:52:25 -03:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo