Go to file
Andrew Isherwood d951f0906b Bug 21289: Fix "isa" bug during partner request
We cannot call 'handle_commit_maybe' inside a 'try' block.
handle_commit_maybe redirects the client then calls 'exit', this is
interpreted as an error and the 'catch' block is erroneously called.

This patch moves the calling of 'handle_commit_maybe' outside the try
block, it will only be reached if everything inside the try block
suceeds.

To test:
1) Enable ILL and have the FreeForm backend available
2) Create a patron category to hold ILL "partners" to whom requests can
be sent. The category can be called anything, you should note the code
you assign
3) Create a patron that belongs to your new category, the patron must
have a primary email defined.
4) In your <interlibrary_loans> block in koha-conf.xml, ensure you have
a <partner_code> element, it should contain the code you assigned in
step 2
5) Create an ILL request using the FreeForm backend
6) Once the request is created, select the "Place request with partners"
button
7) Select your "partner" from the "Select partner libraries" box
8) Click "Send email"
9) TEST: Observe no errors are displayed in the UI

Signed-off-by: Barry Cannon <bc@interleaf.ie>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit fca5a1cb3d)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 6bf50445b1)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2018-10-11 14:45:14 +02:00
C4 Bug 21196: Use replacement cost from the item type if not set at item level 2018-10-03 15:10:34 +02:00
Koha Bug 20669: Add upgrade method to plugins 2018-10-08 08:00:23 +02:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 16739: Show note instead of 500 error for 'Generate EDIFACT' when no EDI account is configured 2018-10-10 11:52:30 +02:00
admin Bug 20504: Fix lang attribute in html tag on systempreferences page 2018-09-21 15:36:01 +02:00
api/v1 Bug 7317: (QA followup) Make query parameters consistent with other endpoints 2017-11-09 11:42:16 -03:00
authorities Bug 19583: Remove use of C4::AuthoritiesMarc 2018-05-14 13:19:48 +00:00
basket Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
catalogue Bug 21248: Fix COinS carp in MARC details page on unknown record 2018-09-24 11:41:37 +02:00
cataloguing Bug 21053: Encode URI characters in plugin 008 2018-09-21 11:30:18 +02:00
circ Bug 21168: Handle deleted checked-in items on checking in 2018-09-24 09:04:24 +02:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 19230: Preventing warn when deleting course 2018-02-02 15:01:33 +00:00
debian Bug 21416: 'gr' option missing from ZEBRA_LANGUAGE options in koha-sites.conf 2018-10-11 14:36:28 +02:00
docs Bug 20906: Prevent test failures due to stricter perl 2018-06-28 07:44:23 +02:00
errors Bug 15288: Error pages: Code duplication removal and better translatability 2016-01-27 05:57:34 +00:00
etc Bug 21031: Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration 2018-09-21 11:57:55 +02:00
ill Bug 21289: Fix "isa" bug during partner request 2018-10-11 14:45:14 +02:00
installer Bug 16690: Simplify SHOW GRANTS to work when connected 2018-10-11 14:38:14 +02:00
koha-tmpl Bug 20785: Advanced Editor does not honor MarcFieldDocURL 2018-10-10 12:11:59 +02:00
labels Bug 20765: Fix search for items by acqdate in label batch 2018-09-24 11:52:13 +02:00
members Bug 21397: Mark "Routing list" tab as active when selected 2018-10-08 07:57:03 +02:00
misc Update release notes for 17.11.10 release 2018-09-24 16:15:09 +02:00
offline_circ Bug 13779: (QA follow-up) Correct checkauth call in offline_circ/download.pl 2018-09-24 11:39:46 +02:00
opac Bug 20023: (QA follow-up) Tiny simplification 2018-10-03 15:12:22 +02:00
patron_lists Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
patroncards Bug 8604: Patron cards made for patrons which don't have patron images use preceding card's image 2018-08-28 15:13:11 +02:00
plugins Bug 19088: plugins-upload causes error log noise 2017-08-30 15:05:56 -03:00
reports Bug 16653: (QA follow-up) Avoid a warning and remove unused variables 2018-07-04 09:00:47 +02:00
reserve Bug 20724: Move the ReservesNeedReturns logic to AddReserve 2018-08-27 14:45:26 +02:00
reviews Bug 19808: Handle deleted reviewers gracefully - reviews/reviewswaiting.pl 2017-12-21 16:07:12 +00:00
rotating_collections Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
serials Bug 20241: Fix display of publication year in subscription record search for MARC21 2018-10-10 12:07:06 +02:00
services Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 21048: (QA follow-up) Fix authorized value statuses in filter 2018-09-21 12:14:19 +02:00
svc Bug 20760: Fill authorised values in svc framework 2018-06-18 08:01:48 +02:00
t Bug 21133: [17.11] RMaint fixup 2018-10-10 14:22:01 +02:00
tags Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities changing DO_NOT_REMOVE to README.txt 2007-10-21 19:14:41 -05:00
tools Bug 21141: Handle non-existent itemnumbers in batch item modification/deletion 2018-10-08 07:33:09 +02:00
virtualshelves Bug 17214: Add records to lists by biblionumber 2017-10-27 14:10:26 -03:00
xt Bug 20906: Fix translatable-templates.t 2018-06-28 07:44:34 +02:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Bug 5458: DBRev 17.11.10.001 2018-10-03 15:20:56 +02:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
Makefile.PL Bug 7317: Interlibrary loans framework for Koha. 2017-11-09 11:42:12 -03:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
about.pl Bug 7317: Add partner_code checks to abot page 2017-11-09 11:42:14 -03:00
changelanguage.pl Bug 16776: Do not forget external language choice in language switcher 2016-08-10 13:51:33 +00:00
edithelp.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-05 21:28:14 +00:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
help.pl Bug 16724: Fix link to the online documentation links 2016-06-24 12:00:42 +00:00
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
koha_perl_deps.pl Bug 17990: Refactor Perl module versions check 2017-02-17 12:13:44 +00:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 18432 : Follow up - Updating to use they/them 2017-04-21 10:56:43 -04:00
rewrite-config.PL Bug 15427 : Enable TLS support for MySQL 2017-03-03 18:33:07 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo