caef98c7f6
Removed the SQL select condition 'AND closedate IS NOT NULL' because this was not returning shippingcost values and it does not exist in the SQL query to return the shipping cost in spent.pl Also removed the retrieval of shipping cost and the associated addition of item(s) cost and shipping cost in GetBudgetOrdered() in C4/Budgets.pm to prevent the shipping costs being subtracted off the fund total twice Test plan: 1. Go to Acquisition and create a currency, budget (make this value of 100), fund ( make this the value of 50), vendor (if neccessary) 2. Create a basket and click 'Add to basket' 3. Add 2 items with the vendor price of 10 4. Click 'Receive shipment' and write in the shipment cost of 6 5. Click 'Finish receiving' and go back to Acquisitions 6. Notice the spent column value is 0.00 but if you click on the value then the spent.pl page is displayed and shows that the shipment cost was 6.00 7. On the acquisition page also notice that the ordered column value is 26.00 8. Click on the name of the fund and notice the spent column value is 0.00 in the fund page table 9. Apply patch 10. Refresh acquisition page and notice that 6.00 is the value in the Spent column and 20.00 is the value in the ordered column. Both of which match the subtotal of the full-list tables displayed when you click on these values 11. Also notice the spent value in the fund page table is 6.00 12 Observe the changes to GetBudgetSpent() and GetBudgetOrdered() C4/Budgets.pm and check they make sense Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
||
|---|---|---|
| C4 | ||
| Koha | ||
| OpenILS | ||
| acqui | ||
| admin | ||
| api/v1 | ||
| authorities | ||
| basket | ||
| catalogue | ||
| cataloguing | ||
| circ | ||
| clubs | ||
| course_reserves | ||
| debian | ||
| docs | ||
| errors | ||
| etc | ||
| installer | ||
| koha-tmpl | ||
| labels | ||
| members | ||
| misc | ||
| offline_circ | ||
| opac | ||
| patron_lists | ||
| patroncards | ||
| plugins | ||
| reports | ||
| reserve | ||
| reviews | ||
| rotating_collections | ||
| serials | ||
| services | ||
| skel | ||
| sms | ||
| suggestion | ||
| svc | ||
| t | ||
| tags | ||
| test | ||
| tmp/modified_authorities | ||
| tools | ||
| virtualshelves | ||
| xt | ||
| .editorconfig | ||
| .htaccess | ||
| .mailmap | ||
| INSTALL | ||
| Koha.pm | ||
| LICENSE | ||
| MANIFEST.SKIP | ||
| Makefile.PL | ||
| README | ||
| README.md | ||
| README.robots | ||
| about.pl | ||
| changelanguage.pl | ||
| edithelp.pl | ||
| fix-perl-path.PL | ||
| help.pl | ||
| install-CPAN.pl | ||
| koha_perl_deps.pl | ||
| kohaversion.pl | ||
| mainpage.pl | ||
| rewrite-config.PL | ||
README.md
Koha is a free software integrated library system (ILS).
Koha is distributed under the GNU GPL version 3 or later.
Note: This is a synced mirror of the official Koha repo.
Note: Koha does not accept pull requests from git hosting sites.
Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.
For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch
The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook
