Go to file
Kyle M Hall c8efbde5ed Bug 21417: EDI ordering fails when basket and EAN libraries do not match
When clicking Create EDIFACT Order on /acqui/basket.pl, an EDIFACT message will not be generated if aqbasket.branch does not match edifact_ean.branchcode. This failure does not generate any sort of error message, it just fails to produce a message.

We should allow ean's to not require a branch to be set, then if we don't find a branch specific each, we can look for the default version of the ean.

Test Plan:
1) Apply this patch set
2) Run updatedatabase
3) Verify you can create a Library EAN without setting a branchcode for it
4) Verify you can use this EAN to send an EDI order where the basket has a branchcode set

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 18674cfde3)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit c2537558e0)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2018-11-08 16:28:05 +01:00
C4 Bug 10382: Course reserves: handle empty values 2018-10-24 10:57:11 +02:00
Koha Bug 21417: EDI ordering fails when basket and EAN libraries do not match 2018-11-08 16:28:05 +01:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 20151: always use current language for stemming 2018-10-15 16:55:49 +02:00
admin Bug 21417: EDI ordering fails when basket and EAN libraries do not match 2018-11-08 16:28:05 +01:00
api/v1 [17.11.x] correct duplicat keys in definitions.json 2018-11-02 15:18:20 +01:00
authorities Bug 21455: Authority search options get shuffled around when you click on 'Search' 2018-11-08 16:23:56 +01:00
basket Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
catalogue Bug 21248: Fix COinS carp in MARC details page on unknown record 2018-09-24 11:41:37 +02:00
cataloguing Bug 20151: always use current language for stemming 2018-10-15 16:55:49 +02:00
circ Bug 21168: Handle deleted checked-in items on checking in 2018-09-24 09:04:24 +02:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 19230: Preventing warn when deleting course 2018-02-02 15:01:33 +00:00
debian Bug 17237: Remove CREATE USER 'user'@'%' line 2018-11-08 16:10:01 +01:00
docs Bug 20906: Prevent test failures due to stricter perl 2018-06-28 07:44:23 +02:00
errors Bug 15288: Error pages: Code duplication removal and better translatability 2016-01-27 05:57:34 +00:00
etc Bug 21031: Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration 2018-09-21 11:57:55 +02:00
ill Bug 21289: Fix "isa" bug during partner request 2018-10-11 14:45:14 +02:00
installer Bug 21417: EDI ordering fails when basket and EAN libraries do not match 2018-11-08 16:28:05 +01:00
koha-tmpl Bug 21417: EDI ordering fails when basket and EAN libraries do not match 2018-11-08 16:28:05 +01:00
labels Bug 20765: Fix search for items by acqdate in label batch 2018-09-24 11:52:13 +02:00
members Bug 21397: Mark "Routing list" tab as active when selected 2018-10-08 07:57:03 +02:00
misc Update release notes for 17.11.11 release 2018-10-24 11:37:22 +02:00
offline_circ Bug 13779: (QA follow-up) Correct checkauth call in offline_circ/download.pl 2018-09-24 11:39:46 +02:00
opac Bug 20023: (QA follow-up) Tiny simplification 2018-10-03 15:12:22 +02:00
patron_lists Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
patroncards Bug 8604: Patron cards made for patrons which don't have patron images use preceding card's image 2018-08-28 15:13:11 +02:00
plugins Bug 19088: plugins-upload causes error log noise 2017-08-30 15:05:56 -03:00
reports Bug 16653: (QA follow-up) Avoid a warning and remove unused variables 2018-07-04 09:00:47 +02:00
reserve Bug 20724: Move the ReservesNeedReturns logic to AddReserve 2018-08-27 14:45:26 +02:00
reviews Bug 19808: Handle deleted reviewers gracefully - reviews/reviewswaiting.pl 2017-12-21 16:07:12 +00:00
rotating_collections Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
serials Bug 20241: Fix display of publication year in subscription record search for MARC21 2018-10-10 12:07:06 +02:00
services Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 21048: (QA follow-up) Fix authorized value statuses in filter 2018-09-21 12:14:19 +02:00
svc Bug 20760: Fill authorised values in svc framework 2018-06-18 08:01:48 +02:00
t Bug 10382: Course reserves: handle empty values 2018-10-24 10:57:11 +02:00
tags Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities
…
tools Bug 20131: Inventory optional filters correct "For loan" addition 2018-10-17 14:34:19 +02:00
virtualshelves Bug 17214: Add records to lists by biblionumber 2017-10-27 14:10:26 -03:00
xt Bug 20906: Fix translatable-templates.t 2018-06-28 07:44:34 +02:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.htaccess
…
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Bug 21617: DBRev 17.11.11.001 2018-11-08 11:17:48 +01:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
Makefile.PL Bug 7317: Interlibrary loans framework for Koha. 2017-11-09 11:42:12 -03:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
about.pl Bug 7317: Add partner_code checks to abot page 2017-11-09 11:42:14 -03:00
changelanguage.pl Bug 16776: Do not forget external language choice in language switcher 2016-08-10 13:51:33 +00:00
edithelp.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-05 21:28:14 +00:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
help.pl Bug 16724: Fix link to the online documentation links 2016-06-24 12:00:42 +00:00
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
koha_perl_deps.pl Bug 17990: Refactor Perl module versions check 2017-02-17 12:13:44 +00:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 18432 : Follow up - Updating to use they/them 2017-04-21 10:56:43 -04:00
rewrite-config.PL Bug 15427 : Enable TLS support for MySQL 2017-03-03 18:33:07 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo