9e90ca26f7
When an item is checked in via SIP2 at the correct target branch after a transfer, the system was incorrectly triggering an alert flag. This occurred because the TransferArrived message was not being filtered out for accounts with checked_in_ok="1", causing the alert logic to treat successful transfer completion as a failure condition. The TransferArrived message indicates successful transfer completion and is purely informational - it should not trigger SIP alerts. This fix ensures that TransferArrived messages are filtered out before alert evaluation, preventing false positive alerts on successful operations. Test Plan: 1. Set up a SIP2 account with checked_in_ok="1" in SIPconfig.xml 2. Via staff client, check out an item to a patron 3. Return the item to a different branch to trigger a transfer 4. Use misc/sip_cli_emulator.pl to check in the item at the target branch 5. Verify SIP response shows alert flag 'N' (no alert) instead of 'Y' 6. Test wrong branch checkin still shows alert flag 'Y' with CV04 type Before: Transfer completion at correct branch incorrectly shows alert='Y' After: Transfer completion at correct branch correctly shows alert='N' Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: Jackie Usher <jackie.usher@westsussex.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> |
||
|---|---|---|
| .. | ||
| Checkin.pm | ||
| Checkout.pm | ||
| FeePayment.pm | ||
| Hold.pm | ||
| Renew.pm | ||
| RenewAll.pm | ||