28fb7b4f83
The original code for Koha::REST::V1::Auth::under called authenticate_api_request when requesting the API spec. This didn't make sense, and recent changes on what conditions are tested for public routes, broke the route. We could add another condition, but it really doesn't make sense to call authenticate_api_request if it should be publicly available in any configuration, as discussed on the bug. This patch adds a trivial check and the requested route, and lets the request through in any case in 'under'. To test: 1. Point your browser to: http://kohadev.myDNSname.org:8080/api/v1/ http://kohadev.myDNSname.org:8080/api/v1/.html => FAIL: In both cases you get an authorization error. 2. Apply the regression tests patch 3. Run: $ kshell k$ prove t/db_dependent/api/v1/auth.t => FAIL: The tests reflect the situation, and fail 4. Apply this patch 5. Repeat 1 and 3 => SUCCESS: All good! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> |
||
|---|---|---|
| .. | ||
| Acquisitions | ||
| Clubs | ||
| Patrons | ||
| Auth.pm | ||
| Biblios.pm | ||
| Checkouts.pm | ||
| Cities.pm | ||
| Holds.pm | ||
| Illrequests.pm | ||
| Items.pm | ||
| Library.pm | ||
| OAuth.pm | ||
| Patrons.pm | ||
| ReturnClaims.pm | ||
| Stage.pm | ||
| Static.pm | ||