Koha-clms/opac
David Cook fad32519c1
Bug 43019: Fix branch comparison
This change fixes the branch comparison between the Page
and the user. Previously, it was doing a numeric "!=" and now it
does the string comparison "ne". Also, if no environmental variable
is set for the default branch, it defaults to an empty string
for anonymous (ie non-authenticated) users.

Test plan:
0. Apply the patch
1. restart_all
2. Log into the staff interface
3. Go to Tools
4. Click on "Pages"
5. Create a Page for All Libraries for the OPAC
6. Copy the "OPAC" link in the "Page URL" table cell and open it
in a private window or a separate browser
7. Note that the page appears
8. Now change the "Page" to a specific library
9. Revisit the URL in the private window
10. Note that it now gives a 404 error
11. Log into the OPAC with a user whose library matches the libary
of the Page
12. Note that now you can view the URL again
13. Change the library of the user or the Page
14. Note that you cannot see the Page now

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz>
2026-08-04 13:45:36 +12:00
..
clubs Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
errors Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
external/overdrive Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
sci Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
sco Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
svc Bug 40163: (follow-up) Fix wrong GNU links and update test 2026-01-07 14:32:37 +00:00
ilsdi.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
maintenance.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
oai.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-ISBDdetail.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-MARCdetail.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-account-pay-return.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-account-pay.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-account.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-addbybiblionumber.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-alert-subscribe.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-alert-subscriptions.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-article-request-cancel.pl Bug 41558: Fix and standardize links to tab on opac-user 2026-05-23 15:58:46 -04:00
opac-authorities-home.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-authoritiesdetail.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-basket.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-blocked.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-browse.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-browser.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-changelanguage.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-course-details.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-course-reserves.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-curbside-pickups.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-detail.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-discharge.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-dismiss-message.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-downloadcart.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-downloadshelf.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-export.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-holdshistory.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-ics.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-idref.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-illrequests-unauthenticated.pl Bug 36197: (QA follow-up): Adopt POST REDIRECT GET pattern 2025-04-25 08:47:11 +02:00
opac-illrequests.pl Bug 41237: (QA follow-up): Utilize available logged in user object 2026-02-27 11:55:14 -05:00
opac-image.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-imageviewer.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-issue-note.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-library.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-main.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-memberentry.pl Bug 37143: Do not allow required fields with only whitespace to be submitted 2026-06-24 14:57:32 +12:00
opac-messaging.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-modrequest-suspend.pl Bug 41558: Fix and standardize links to tab on opac-user 2026-05-23 15:58:46 -04:00
opac-modrequest.pl Bug 41558: Fix and standardize links to tab on opac-user 2026-05-23 15:58:46 -04:00
opac-mymessages.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-news-rss.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-overdrive-search.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-page.pl Bug 43019: Fix branch comparison 2026-08-04 13:45:36 +12:00
opac-passwd.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-password-recovery.pl Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
opac-patron-consent.pl Bug 41662: Prevent CSRF on opac-patron-consent.pl 2026-01-29 07:47:34 -07:00
opac-patron-image.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-privacy.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-ratings.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-readingrecord.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-recall.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-recalls.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-registration-verify.pl Bug 41076: [25.05.x] Adjust perl tidiness 2026-02-24 08:35:34 -07:00
opac-renew.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-reportproblem.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-request-article.pl Bug 41558: Fix and standardize links to tab on opac-user 2026-05-23 15:58:46 -04:00
opac-reserve.pl Bug 41558: Fix and standardize links to tab on opac-user 2026-05-23 15:58:46 -04:00
opac-reset-password.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-restrictedpage.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-retrieve-file.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-review.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-routing-lists.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-search-history.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-search.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-sendbasket.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-sendshelf.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-serial-issues.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-shareshelf.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-shelves.pl Bug 41655: Local OPAC covers are not displayed in OPAC lists 2026-04-01 16:41:32 -04:00
opac-showmarc.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-showreviews.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-suggestions.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-tags.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-tags_subject.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-topissues.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
opac-user.pl Bug 41558: Fix and standardize links to tab on opac-user 2026-05-23 15:58:46 -04:00
opac-virtual-card.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
tracklinks.pl Bug 40163: Fix several http addresses in the code docs 2026-01-07 14:32:30 +00:00
unapi Bug 41261: RMaint patch for 25.05.x-security 2026-04-21 12:02:45 -06:00