Go to file
Alex Buckley b933a44441 Bug 26346: Add option to make public lists editable by all staff
If a staff member has access to the staff client (either because
'catalogue' permission is enabled or they're a superlibrarian
then that user can add items (from OPAC or staff client) to a list
marked 'Staff only'

Test plan:
1. In the staff client go to: Lists > 'New list'. Notice under 'Allow changes to contents
from' there are three options: Nobody, Owner only, Anyone seeing this
list

2. Apply first 3 patches and run updatedatabase.pl
cd installer/data/mysql
sudo koha-shell <instance>
./updatedatabase.pl

3. Restart memcached and plack

4. Create 4 patron accounts:
- User A : Superlibrarian permissions
- User B : 'Staff access, allows viewing of catalogue in staff interface
(catalogue)'
- User C : No permissions
- User D : 'Staff access, allows viewing of catalogue in staff
interface' and 'Lists' > Edit public lists (edit_public_lists)' sub-permission

5. Login to staff client as User A.
Create a public list and select the new 'Staff only' option under 'Allow changes to contents from'

6. Log into the staff client as User B.
Confirm you can add items to the list from the following staff client pages:
- Individual list page using the 'Add items' button
- Staff client search result page
- Staff client biblio detail page

7. Confirm you can remove items from the list

8. Confirm you can perform an OPAC search when not logged in

9. Log into the OPAC as User B. Confirm you can add items to the list
from the following OPAC pages:
- OPAC search result page
- OPAC biblio detail page

10. Log into the OPAC as User C. Do an OPAC search and confirm you
can view the list, but not add items to it

11. Login to the staff client as User B. Create a new list with the
following settings:
- 'Category'='Private',
- 'Allow changes to contents from'='Staff only'

Notice a red hint message is displayed.
Change 'Category'='Public' and notice the hint is removed

12. Log into the OPAC as User C. Notice the 'Staff only' option is not
available when creating a list

13. Log into the OPAC as User B. Repeat step 11. Confirm the same
outcome

14. Log into the staff client as User A. Create a list with the
following settings:

- Public = 'Public'
- Allow changes to contents from = 'owner only'

15. Log into the staff client as User D. Edit the list from step 14
confirm you can edit the list to have 'Allow changes to contents from' =
'Staff only'

16. Run Patron.t and Virtualshelves.t unit tests:
sudo koha-shell <instance>
prove t/db_dependent/Koha/Patron.t
prove t/db_dependent/Virtualshelves.t

Sponsored-by: Horowhenua District Council, New Zealand

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2022-04-12 17:13:02 +02:00
C4 Bug 22347: Translatability of ILSDI GetAvailability 2022-04-12 17:13:02 +02:00
Koha Bug 26346: Add option to make public lists editable by all staff 2022-04-12 17:13:02 +02:00
acqui Bug 30055: Use /acquisitions/baskets/managers for basket's manager 2022-04-04 09:46:58 +02:00
admin Bug 29695: Make "modalselect" syspref's values translatable 2022-04-12 11:40:16 +02:00
api Bug 29810: Document x-koha-embed header on orders endpoints 2022-04-12 11:40:16 +02:00
authorities Bug 11083: Add ability to generate authority summary using XSLT 2022-04-08 15:49:15 +02:00
basket Bug 29609: Centralized code to build the link to a biblio detail page 2022-04-08 15:49:16 +02:00
bin Bug 20582: Turn Koha into a Mojolicious application 2020-10-06 12:00:04 +02:00
catalogue Bug 21225: (follow-up) Make SyndeticCovers work on catalog detail page 2022-04-08 15:49:16 +02:00
cataloguing Bug 29609: Centralized code to build the link to a biblio detail page 2022-04-08 15:49:16 +02:00
circ Bug 29609: Centralized code to build the link to a biblio detail page 2022-04-08 15:49:16 +02:00
clubs Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
course_reserves Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
debian Bug 29957: Add --keep-cookie option to koha-create 2022-04-12 11:40:17 +02:00
docs Revert "Bug 20076: Add Thibaud Guillot to contributors" 2022-01-13 22:12:53 -10:00
errors Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
etc Bug 29957: Add example lines in koha-conf.xml 2022-04-12 11:40:17 +02:00
ill Bug 29844: Fix ->search occurrences 2022-02-09 15:36:23 -10:00
installer Bug 26346: Database changes 2022-04-12 17:13:02 +02:00
koha-tmpl Bug 26346: Add option to make public lists editable by all staff 2022-04-12 17:13:02 +02:00
labels Bug 29821: Add interface for generating barcodes using svc/barcode 2022-04-08 15:49:17 +02:00
lib/CGI/Session/Serialize Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
members Bug 30063: Restore back behaviour 2022-04-04 09:47:02 +02:00
misc Bug 26669: Last Run if report not always updated 2022-04-04 16:23:46 +02:00
offline_circ Bug 29255: Built-in offline circulation broken with SQL error 2021-11-15 12:38:39 +01:00
opac Bug 26346: Add option to make public lists editable by all staff 2022-04-12 17:13:02 +02:00
patron_lists Bug 16446: Add ability to add patrons to list by borrowernumber 2021-10-21 12:24:04 +02:00
patroncards Bug 30055: Use /patrons for patron's cards 2022-04-04 09:46:57 +02:00
plugins Bug 29787: Add plugin version to plugin search results 2022-04-08 15:49:15 +02:00
pos Bug 28481: (RM follow-up) formatting 2021-12-16 12:13:51 -10:00
recalls Bug 19532: (RM follow-up) Fix recalls.old is default 0 2022-03-15 00:31:32 -10:00
reports Bug 26669: Last Run if report not always updated 2022-04-04 16:23:46 +02:00
reserve Bug 30093: Make patron search from request.pl use the REST API 2022-04-04 09:47:00 +02:00
reviews Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
rotating_collections Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
serials Bug 29609: Centralized code to build the link to a biblio detail page 2022-04-08 15:49:16 +02:00
services Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
skel
…
suggestion Bug 30055: Use /api/v1/suggestions/managers to list managers or suggestions 2022-04-04 09:46:57 +02:00
svc Bug 29859: Fix club/enroll 2022-04-05 17:36:59 +02:00
t Bug 26346: Add option to make public lists editable by all staff 2022-04-12 17:13:02 +02:00
tags Bug 29469: (bug 17600 follow-up) Fix tag approval/rejection from staff 2021-11-16 15:49:22 +01:00
tmp/modified_authorities
…
tools Bug 29695: (follow-up) Remove C4::Reports::Guided::_get_column_defs 2022-04-12 11:40:16 +02:00
virtualshelves Bug 26346: Add option to make public lists editable by all staff 2022-04-12 17:13:02 +02:00
xt Bug 30194: (follow-up) Fix xt/api.t 2022-03-29 17:14:50 +02:00
.editorconfig Bug 27375: Set YAML file settings in .editorconfig 2021-11-03 15:40:52 +01:00
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
…
.mailmap 21.11.00 - Update .mailmap 2021-11-26 12:26:22 +01:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.proverc.dist Bug 19821: Install sample data, ES mappings and Version syspref 2021-10-25 11:27:40 +02:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Bug 17018: DBRev 21.12.00.026 2022-04-12 17:13:02 +02:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 19532: Database and installer stuff 2022-03-14 22:45:50 -10:00
README
…
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots
…
about.pl Bug 28870: Move email address validation to a specific class method 2021-09-28 10:22:36 +02:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 28610: Elasticsearch 7 - hits.total is now an object 2022-04-04 16:23:46 +02:00
fix-perl-path.PL Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
gulpfile.js Bug 29695: Remove columns.def 2022-04-12 11:40:17 +02:00
help.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
koha_perl_deps.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
mainpage.pl Bug 29020: Add link on the mainpage for users without admin access 2021-10-19 09:29:09 +02:00
package.json Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00
rewrite-config.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-17 10:07:36 +02:00
yarn.lock Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo