gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
34,051 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Kyle M Hall ae7f79b903 Bug 23116: AllowHoldPolicyOverride allows a librarian to almost place a hold on an item already on hold 
A library appears to be able to place a second item level hold on an item a patron already has on hold if
A) AllowHoldPolicyOverride is enabled
and
B) the circ rule allow for multple item level holds.

Once the patron submits the hold requests though, the hold does not get stored in the database.

Because allowing two item level holds for the same item makes no sense, we should not allow
this attempt to take place, even if AllowHoldPolicyOverride is enabled.

Test Plan:
 1) Enable AllowHoldPolicyOverride
 2) Set up circ rules to allow for multiple item level holds on one record
 3) Place an item level hold on a record
 4) Note you can force placing a second item hold on that reocrd
 5) Attempt to do so, it will not actually work
 6) Apply this patch
 7) Note you can no longer place another item level hold for the same item
   you just placed an item-level hold on
 8) Note you can still force holds that contravene the circ rules for
   any and all other reasons
 9) Test with record level holds
10) Test by placing multiple holds from search results

Signed-off-by: Martha Fuerst <mfurest@hmcpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Simple fix for a regression. Works as expected.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 2c5e9bed7d)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

(cherry picked from commit d0186dd176)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
 		2019-07-22 23:46:31 +00:00
C4 Bug 23057: If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason 2019-07-19 21:54:51 +00:00
Koha Bug 23022: Remove the SQl mode NO_AUTO_CREATE_USER 2019-06-26 16:53:13 +00:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 22225: Correctly use invoiceincgst over listincgst 2019-05-30 08:15:24 +01:00
admin Bug 22339: Fix search field mappings of MARC fixed fields 2019-04-26 16:20:48 +01:00
api/v1 Bug 13895: (QA follow-up) Make the class plural 2019-04-01 15:02:00 +01:00
authorities Bug 19994: Used Modern::Perl in Authorities perl scripts 2019-02-01 15:06:13 +00:00
basket Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-31 17:07:03 +00:00
catalogue Bug 22762: Fix items.collection display on receiving 2019-04-26 16:04:43 +01:00
cataloguing Bug 16232: Fix edit as new in Rancor 2019-04-26 16:10:34 +01:00
circ Bug 13640: (QA follow-up) Allow NULL values for default_branch_item_rules.holdallowed 2019-07-19 17:51:30 +00:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 21003: Removed warning and changed wording on add_items-step2.tt 2019-04-15 11:54:24 +01:00
debian Bug 23090: Add some special characters 2019-07-19 17:11:20 +00:00
docs Bug 7143: (follow-up) Update about page for new devs (Academy) 2019-02-25 18:57:43 +00:00
errors Bug 19998: use Modern::Perl in error perl scripts 2018-02-05 09:45:48 -03:00
etc Bug 23053: Add phrase index to authority Local-Number 2019-06-19 19:16:10 +00:00
ill Bug 20996: Remove prefix use of borrower category 2018-11-02 10:33:02 +00:00
installer RMaint Follow-up: Fix typo in updatedatabase.pl 2019-07-12 16:48:54 +00:00
koha-tmpl Bug 23153: In framework management action subfields must not go directly to edition 2019-07-19 18:57:43 +00:00
labels Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
members Bug 23082: Fatal error editing a restricted patron 2019-06-26 17:17:41 +00:00
misc Update release notes for 18.11.07 release 2019-06-27 18:01:51 +00:00
offline_circ Bug 13779: (QA follow-up) Correct checkauth call in offline_circ/download.pl 2018-09-14 17:27:29 +00:00
opac Bug 23150: (follow-up) Make gdpr_proc_consent mandatory for create 2019-07-19 18:38:19 +00:00
patron_lists Bug 19524: Use existing logged_in_user variable 2018-07-18 16:49:30 +00:00
patroncards Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
plugins Bug 20011: use Modern::Perl in plugins perl scripts 2018-02-05 09:46:44 -03:00
reports Bug 22090: Add missing information to cash register CSV file 2019-04-25 15:03:03 +01:00
reserve Bug 23116: AllowHoldPolicyOverride allows a librarian to almost place a hold on an item already on hold 2019-07-22 23:46:31 +00:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-09 15:02:45 +00:00
serials Bug 11492: (follow-up) Don't pass publisheddatetext param to NewIssue 2019-06-11 14:37:06 +00:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 21048: (QA follow-up) Fix authorized value statuses in filter 2018-08-08 20:58:23 +00:00
svc Bug 23144: (QA follow-up) Fix another POD error in svc/barcode 2019-07-18 23:04:02 +00:00
t Bug 18344: Add unit tests 2019-06-19 19:22:48 +00:00
tags Bug 22036: Indented code where '^I' was written rather than an indent. 2019-01-23 12:25:07 +00:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities
…
tools Bug 23006: Cannot use inventory with barcodes containing special chars 2019-06-11 14:46:18 +00:00
virtualshelves Bug 22941: Do not return 500 if sortfield contain parenthesis 2019-06-26 16:38:53 +00:00
xt Bug 21576: Keep compatibility with QA script 2018-10-26 17:09:52 +00:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Increment version for 18.11.07 release 2019-06-27 17:57:25 +00:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
Makefile.PL Bug 20174: Remove xml_sax.pl target from Makefile.pl 2019-02-25 15:26:15 +00:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
about.pl Bug 20996: Remove prefix use of borrower category 2018-11-02 10:33:02 +00:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
gulpfile.js Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 21907: Fix article requests count for non-superlibrarians 2019-02-11 13:42:24 +00:00
package.json Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00
rewrite-config.PL Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
yarn.lock Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo