Go to file
Nick Clemens a363413a4e Bug 27529: Choose patron's branch or item's homebranch if following group rules and patron cannot choose branch
This patch defaults the holds pickup location to the items homebranch or the patron's branch when a group option is selected
for the hold fulfillment policy and the patron is not allowed to choose the branch on the OPAC

To test:
1 - Set 'Default checkout, hold and return policy' -> 'Hold pickup library match' to item's hold group or patron's hold group
2 - Set  OPACAllowUserToChooseBranch to 'Don't allow'
3 - Try to place an item level hold on the opac
4 - Ka-boom, etiher:
    The method Koha::Item->patrongroup is not covered by tests!
    The method Koha::Item->itemgroup is not covered by tests!
5 - Apply patch
6 - Repeat
7 - Note the pickup location is set to either the patron's branch or the items homebranch
8 - Repeat plan with the other group setting

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 99c3b9ae1f)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit b78ccb3e47)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2021-04-25 16:36:13 +00:00
C4 Bug 27746: prevent regexp undefined warning when checking subfield contents ($oclc) 2021-04-25 15:16:05 +00:00
Koha Bug 28123: Quote filename value in Content-Disposition header 2021-04-25 16:25:31 +00:00
acqui Bug 27828: (bug 24469 follow-up) Add missing import 2021-03-14 18:59:56 +00:00
admin Bug 26051: Add sort=1 on cn-sort in mappings.yaml 2021-03-05 13:44:51 +00:00
api/v1 Bug 27680: Add support for sorting fields with multiple data points 2021-03-05 21:31:36 +00:00
authorities Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
basket Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
catalogue Bug 23475: Use localStorage to preserve simple search values 2020-12-15 20:00:00 +00:00
cataloguing Bug 27739: Advanced editor should use DefaultCountryField008 preference 2021-04-25 16:04:42 +00:00
circ Bug 7806: [20.05] Fix remaining occurrences of 0000-00-00 2021-03-08 14:26:22 +00:00
clubs Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
course_reserves Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
debian Bug 17429: document the --plack/--noplack options of koha-list 2021-01-29 21:27:24 +00:00
docs Bug 7143: Update about page for new devs 2021-02-03 21:54:32 +00:00
errors Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
etc Bug 8426: Diacritics not being mapped for searching 2021-03-23 12:43:26 +00:00
ill Bug 23173: (follow-up) Small improvements in efficiency 2020-04-06 11:05:09 +01:00
installer DBRev 20.05.10.001 2021-04-25 14:34:28 +00:00
koha-tmpl Bug 28103: Fix barcode plugin on the order receive view 2021-04-25 16:17:38 +00:00
labels Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
members Bug 28147: Pass itemnumber through to Account->pay 2021-04-25 16:08:03 +00:00
misc Bug 26312: (follow-up) Fix passing of exception messages 2021-04-25 15:23:38 +00:00
offline_circ Bug 26675: (bug 23463 follow-up) Fix typo onloadn vs onloan 2020-11-10 22:49:05 +00:00
opac Bug 27529: Choose patron's branch or item's homebranch if following group rules and patron cannot choose branch 2021-04-25 16:36:13 +00:00
patron_lists Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
patroncards Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
plugins Bug 24633: Add support for gitlab searching of plugins 2020-11-16 22:21:01 +00:00
pos Bug 26023: Properly secure the cashup and refund actions 2020-09-04 17:43:21 +00:00
reports Bug 7806: [20.05] Fix remaining occurrences of 0000-00-00 2021-03-08 14:26:22 +00:00
reserve Bug 28118: Default to current branch when placing hold 2021-04-25 16:01:58 +00:00
reviews Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
rotating_collections Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
serials Bug 7806: [20.05] Fix remaining occurrences of 0000-00-00 2021-03-08 14:26:22 +00:00
services
…
skel
…
suggestion Bug 7806: [20.05] Fix remaining occurrences of 0000-00-00 2021-03-08 14:26:22 +00:00
svc Bug 26457: [20.05.x] Throw exception if update of issues table fails 2021-03-05 20:41:32 +00:00
t Bug 28123: Fix expected value in unit test 2021-04-25 16:25:46 +00:00
tags Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
tmp/modified_authorities
…
tools Bug 28015: Fix inventory for timeformat=12h 2021-04-25 15:57:01 +00:00
virtualshelves Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
xt Bug 26265: add a plan for tests 2020-09-02 14:32:44 +00:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
…
.mailmap
…
.perlcriticrc Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
INSTALL
…
Koha.pm DBRev 20.05.10.001 2021-04-25 14:34:28 +00:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 26265: Add missing xt dir 2020-09-02 14:32:13 +00:00
README
…
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-12-14 15:32:15 +00:00
README.robots
…
about.pl Bug 25826: Add a warning to the about page 2021-01-13 21:59:36 +00:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
cpanfile Bug 26848: Fix Readonly dependency in cpanfile 2021-01-20 01:54:26 +00:00
fix-perl-path.PL Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
gulpfile.js Bug 26228: Update gulpfile to work with Node.js v12 2020-09-03 14:49:31 +00:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl
…
mainpage.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
package.json Bug 26228: Update gulpfile to work with Node.js v12 2020-09-03 14:49:31 +00:00
rewrite-config.PL Bug 25792: Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 2020-07-28 14:46:44 +00:00
yarn.lock Bug 26228: Update gulpfile to work with Node.js v12 2020-09-03 14:49:31 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo