318 lines
14 KiB
Perl
318 lines
14 KiB
Perl
#!/usr/bin/perl
|
|
|
|
# Copyright 2016 Koha-Suomi Oy
|
|
#
|
|
# This file is part of Koha
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use Test::More tests => 3;
|
|
|
|
use Benchmark;
|
|
|
|
use Koha::IssuingRules;
|
|
|
|
use t::lib::TestBuilder;
|
|
use t::lib::Mocks;
|
|
|
|
my $schema = Koha::Database->new->schema;
|
|
$schema->storage->txn_begin;
|
|
|
|
my $builder = t::lib::TestBuilder->new;
|
|
|
|
subtest 'get_effective_issuing_rule' => sub {
|
|
plan tests => 3;
|
|
|
|
my $patron = $builder->build({ source => 'Borrower' });
|
|
my $item = $builder->build({ source => 'Item' });
|
|
|
|
my $categorycode = $patron->{'categorycode'};
|
|
my $itemtype = $item->{'itype'};
|
|
my $branchcode = $item->{'homebranch'};
|
|
|
|
subtest 'Call with undefined values' => sub {
|
|
plan tests => 4;
|
|
|
|
my $rule;
|
|
Koha::IssuingRules->delete;
|
|
|
|
is(Koha::IssuingRules->search->count, 0, 'There are no issuing rules.');
|
|
$rule = Koha::IssuingRules->get_effective_issuing_rule({
|
|
branchcode => undef,
|
|
categorycode => undef,
|
|
itemtype => undef,
|
|
});
|
|
is($rule, undef, 'When I attempt to get effective issuing rule by'
|
|
.' providing undefined values, then undef is returned.');
|
|
ok(Koha::IssuingRule->new({
|
|
branchcode => '*',
|
|
categorycode => '*',
|
|
itemtype => '*',
|
|
})->store, 'Given I added an issuing rule branchcode => *,'
|
|
.' categorycode => *, itemtype => *,');
|
|
$rule = Koha::IssuingRules->get_effective_issuing_rule({
|
|
branchcode => undef,
|
|
categorycode => undef,
|
|
itemtype => undef,
|
|
});
|
|
ok(_row_match($rule, '*', '*', '*'), 'When I attempt to get effective'
|
|
.' issuing rule by providing undefined values, then the above one is'
|
|
.' returned.');
|
|
};
|
|
|
|
subtest 'Get effective issuing rule in correct order' => sub {
|
|
plan tests => 18;
|
|
|
|
my $rule;
|
|
Koha::IssuingRules->delete;
|
|
is(Koha::IssuingRules->search->count, 0, 'There are no issuing rules.');
|
|
$rule = Koha::IssuingRules->get_effective_issuing_rule({
|
|
branchcode => $branchcode,
|
|
categorycode => $categorycode,
|
|
itemtype => $itemtype,
|
|
});
|
|
is($rule, undef, 'When I attempt to get effective issuing rule, then undef'
|
|
.' is returned.');
|
|
|
|
ok(Koha::IssuingRule->new({
|
|
branchcode => '*',
|
|
categorycode => '*',
|
|
itemtype => '*',
|
|
})->store, 'Given I added an issuing rule branchcode => *, categorycode => *, itemtype => *,');
|
|
$rule = Koha::IssuingRules->get_effective_issuing_rule({
|
|
branchcode => $branchcode,
|
|
categorycode => $categorycode,
|
|
itemtype => $itemtype,
|
|
});
|
|
ok(_row_match($rule, '*', '*', '*'), 'When I attempt to get effective issuing rule,'
|
|
.' then the above one is returned.');
|
|
|
|
ok(Koha::IssuingRule->new({
|
|
branchcode => '*',
|
|
categorycode => '*',
|
|
itemtype => $itemtype,
|
|
})->store, "Given I added an issuing rule branchcode => *, categorycode => *, itemtype => $itemtype,");
|
|
$rule = Koha::IssuingRules->get_effective_issuing_rule({
|
|
branchcode => $branchcode,
|
|
categorycode => $categorycode,
|
|
itemtype => $itemtype,
|
|
});
|
|
ok(_row_match($rule, '*', '*', $itemtype), 'When I attempt to get effective issuing rule,'
|
|
.' then the above one is returned.');
|
|
|
|
ok(Koha::IssuingRule->new({
|
|
branchcode => '*',
|
|
categorycode => $categorycode,
|
|
itemtype => '*',
|
|
})->store, "Given I added an issuing rule branchcode => *, categorycode => $categorycode, itemtype => *,");
|
|
$rule = Koha::IssuingRules->get_effective_issuing_rule({
|
|
branchcode => $branchcode,
|
|
categorycode => $categorycode,
|
|
itemtype => $itemtype,
|
|
});
|
|
ok(_row_match($rule, '*', $categorycode, '*'), 'When I attempt to get effective issuing rule,'
|
|
.' then the above one is returned.');
|
|
|
|
ok(Koha::IssuingRule->new({
|
|
branchcode => '*',
|
|
categorycode => $categorycode,
|
|
itemtype => $itemtype,
|
|
})->store, "Given I added an issuing rule branchcode => *, categorycode => $categorycode, itemtype => $itemtype,");
|
|
$rule = Koha::IssuingRules->get_effective_issuing_rule({
|
|
branchcode => $branchcode,
|
|
categorycode => $categorycode,
|
|
itemtype => $itemtype,
|
|
});
|
|
ok(_row_match($rule, '*', $categorycode, $itemtype), 'When I attempt to get effective issuing rule,'
|
|
.' then the above one is returned.');
|
|
|
|
ok(Koha::IssuingRule->new({
|
|
branchcode => $branchcode,
|
|
categorycode => '*',
|
|
itemtype => '*',
|
|
})->store, "Given I added an issuing rule branchcode => $branchcode, categorycode => '*', itemtype => '*',");
|
|
$rule = Koha::IssuingRules->get_effective_issuing_rule({
|
|
branchcode => $branchcode,
|
|
categorycode => $categorycode,
|
|
itemtype => $itemtype,
|
|
});
|
|
ok(_row_match($rule, $branchcode, '*', '*'), 'When I attempt to get effective issuing rule,'
|
|
.' then the above one is returned.');
|
|
|
|
ok(Koha::IssuingRule->new({
|
|
branchcode => $branchcode,
|
|
categorycode => '*',
|
|
itemtype => $itemtype,
|
|
})->store, "Given I added an issuing rule branchcode => $branchcode, categorycode => '*', itemtype => $itemtype,");
|
|
$rule = Koha::IssuingRules->get_effective_issuing_rule({
|
|
branchcode => $branchcode,
|
|
categorycode => $categorycode,
|
|
itemtype => $itemtype,
|
|
});
|
|
ok(_row_match($rule, $branchcode, '*', $itemtype), 'When I attempt to get effective issuing rule,'
|
|
.' then the above one is returned.');
|
|
|
|
ok(Koha::IssuingRule->new({
|
|
branchcode => $branchcode,
|
|
categorycode => $categorycode,
|
|
itemtype => '*',
|
|
})->store, "Given I added an issuing rule branchcode => $branchcode, categorycode => $categorycode, itemtype => '*',");
|
|
$rule = Koha::IssuingRules->get_effective_issuing_rule({
|
|
branchcode => $branchcode,
|
|
categorycode => $categorycode,
|
|
itemtype => $itemtype,
|
|
});
|
|
ok(_row_match($rule, $branchcode, $categorycode, '*'), 'When I attempt to get effective issuing rule,'
|
|
.' then the above one is returned.');
|
|
|
|
ok(Koha::IssuingRule->new({
|
|
branchcode => $branchcode,
|
|
categorycode => $categorycode,
|
|
itemtype => $itemtype,
|
|
})->store, "Given I added an issuing rule branchcode => $branchcode, categorycode => $categorycode, itemtype => $itemtype,");
|
|
$rule = Koha::IssuingRules->get_effective_issuing_rule({
|
|
branchcode => $branchcode,
|
|
categorycode => $categorycode,
|
|
itemtype => $itemtype,
|
|
});
|
|
ok(_row_match($rule, $branchcode, $categorycode, $itemtype), 'When I attempt to get effective issuing rule,'
|
|
.' then the above one is returned.');
|
|
};
|
|
|
|
subtest 'Performance' => sub {
|
|
plan tests => 4;
|
|
|
|
my $worst_case = timethis(500,
|
|
sub { Koha::IssuingRules->get_effective_issuing_rule({
|
|
branchcode => 'nonexistent',
|
|
categorycode => 'nonexistent',
|
|
itemtype => 'nonexistent',
|
|
});
|
|
}
|
|
);
|
|
my $mid_case = timethis(500,
|
|
sub { Koha::IssuingRules->get_effective_issuing_rule({
|
|
branchcode => $branchcode,
|
|
categorycode => 'nonexistent',
|
|
itemtype => 'nonexistent',
|
|
});
|
|
}
|
|
);
|
|
my $sec_best_case = timethis(500,
|
|
sub { Koha::IssuingRules->get_effective_issuing_rule({
|
|
branchcode => $branchcode,
|
|
categorycode => $categorycode,
|
|
itemtype => 'nonexistent',
|
|
});
|
|
}
|
|
);
|
|
my $best_case = timethis(500,
|
|
sub { Koha::IssuingRules->get_effective_issuing_rule({
|
|
branchcode => $branchcode,
|
|
categorycode => $categorycode,
|
|
itemtype => $itemtype,
|
|
});
|
|
}
|
|
);
|
|
ok($worst_case, 'In worst case, get_effective_issuing_rule finds matching'
|
|
.' rule '.sprintf('%.2f', $worst_case->iters/$worst_case->cpu_a)
|
|
.' times per second.');
|
|
ok($mid_case, 'In mid case, get_effective_issuing_rule finds matching'
|
|
.' rule '.sprintf('%.2f', $mid_case->iters/$mid_case->cpu_a)
|
|
.' times per second.');
|
|
ok($sec_best_case, 'In second best case, get_effective_issuing_rule finds matching'
|
|
.' rule '.sprintf('%.2f', $sec_best_case->iters/$sec_best_case->cpu_a)
|
|
.' times per second.');
|
|
ok($best_case, 'In best case, get_effective_issuing_rule finds matching'
|
|
.' rule '.sprintf('%.2f', $best_case->iters/$best_case->cpu_a)
|
|
.' times per second.');
|
|
};
|
|
};
|
|
|
|
subtest 'get_opacitemholds_policy' => sub {
|
|
plan tests => 4;
|
|
my $itype = $builder->build_object({ class => 'Koha::ItemTypes' });
|
|
my $itemtype = $builder->build_object({ class => 'Koha::ItemTypes' });
|
|
my $library = $builder->build_object({ class => 'Koha::Libraries' });
|
|
my $patron = $builder->build_object({ class => 'Koha::Patrons' });
|
|
my $biblio = $builder->build_object({ class => 'Koha::Biblios' });
|
|
my $biblioitem = $builder->build_object( { class => 'Koha::Biblioitems', value => { itemtype => $itemtype->itemtype, biblionumber => $biblio->biblionumber } } );
|
|
my $item = $builder->build_object(
|
|
{ class => 'Koha::Items',
|
|
value => {
|
|
homebranch => $library->branchcode,
|
|
holdingbranch => $library->branchcode,
|
|
notforloan => 0,
|
|
itemlost => 0,
|
|
withdrawn => 0,
|
|
biblionumber => $biblio->biblionumber,
|
|
biblioitemnumber => $biblioitem->biblioitemnumber,
|
|
itype => $itype->itemtype,
|
|
}
|
|
}
|
|
);
|
|
|
|
Koha::IssuingRules->delete;
|
|
Koha::IssuingRule->new({categorycode => '*', itemtype => '*', branchcode => '*', opacitemholds => "N"})->store;
|
|
Koha::IssuingRule->new({categorycode => '*', itemtype => $itype->itemtype, branchcode => '*', opacitemholds => "Y"})->store;
|
|
Koha::IssuingRule->new({categorycode => '*', itemtype => $itemtype->itemtype, branchcode => '*', opacitemholds => "N"})->store;
|
|
t::lib::Mocks::mock_preference('item-level_itypes', 1);
|
|
my $opacitemholds = Koha::IssuingRules->get_opacitemholds_policy( { item => $item, patron => $patron } );
|
|
is ( $opacitemholds, 'Y', 'Patrons can place a hold on this itype');
|
|
t::lib::Mocks::mock_preference('item-level_itypes', 0);
|
|
$opacitemholds = Koha::IssuingRules->get_opacitemholds_policy( { item => $item, patron => $patron } );
|
|
is ( $opacitemholds, 'N', 'Patrons cannot place a hold on this itemtype');
|
|
|
|
Koha::IssuingRules->delete;
|
|
Koha::IssuingRule->new({categorycode => '*', itemtype => '*', branchcode => '*', opacitemholds => "N"})->store;
|
|
Koha::IssuingRule->new({categorycode => '*', itemtype => $itype->itemtype, branchcode => '*', opacitemholds => "N"})->store;
|
|
Koha::IssuingRule->new({categorycode => '*', itemtype => $itemtype->itemtype, branchcode => '*', opacitemholds => "Y"})->store;
|
|
t::lib::Mocks::mock_preference('item-level_itypes', 1);
|
|
$opacitemholds = Koha::IssuingRules->get_opacitemholds_policy( { item => $item, patron => $patron } );
|
|
is ( $opacitemholds, 'N', 'Patrons cannot place a hold on this itype');
|
|
t::lib::Mocks::mock_preference('item-level_itypes', 0);
|
|
$opacitemholds = Koha::IssuingRules->get_opacitemholds_policy( { item => $item, patron => $patron } );
|
|
is ( $opacitemholds, 'Y', 'Patrons can place a hold on this itemtype');
|
|
|
|
$patron->delete;
|
|
};
|
|
|
|
subtest 'get_onshelfholds_policy' => sub {
|
|
plan tests => 3;
|
|
|
|
t::lib::Mocks::mock_preference('item-level_itypes', 1);
|
|
Koha::IssuingRules->delete;
|
|
|
|
my $patron = $builder->build_object({ class => 'Koha::Patrons' });
|
|
my $item = $builder->build_object({ class => 'Koha::Items' });
|
|
|
|
is( Koha::IssuingRules->get_onshelfholds_policy({ item => $item, patron => $patron }), undef, 'Should return undef when no rules can be found' );
|
|
Koha::IssuingRule->new({ categorycode => $patron->categorycode, itemtype => $item->itype, branchcode => '*', onshelfholds => "0" })->store;
|
|
is( Koha::IssuingRules->get_onshelfholds_policy({ item => $item, patron => $patron }), 0, 'Should be zero' );
|
|
Koha::IssuingRule->new({ categorycode => $patron->categorycode, itemtype => $item->itype, branchcode => $item->holdingbranch, onshelfholds => "2" })->store;
|
|
is( Koha::IssuingRules->get_onshelfholds_policy({ item => $item, patron => $patron }), 2, 'Should be two now' );
|
|
};
|
|
|
|
sub _row_match {
|
|
my ($rule, $branchcode, $categorycode, $itemtype) = @_;
|
|
|
|
return $rule->branchcode eq $branchcode && $rule->categorycode eq $categorycode
|
|
&& $rule->itemtype eq $itemtype;
|
|
}
|
|
|
|
$schema->storage->txn_rollback;
|
|
|