Koha-clms/members
Jonathan Druart 3f0b11ad41 Bug 22868: Move suggestions_manage subperm out of acquisition perm
Bug 11911 replaced the permission of suggestions.pl (create a purchase
suggestion) from catalogue => 1 to acquisition => 'suggestions_manage'.
However we have a lot of acquisition scripts that have lax permissions
(acquisition => '*' which means any sub permissions of acquisition is
enough).

That causes problem when a circulation staff can create purchase
suggestions but not access acquisition information.

One solution is to move the suggestions_manage subpermission out of the
acquisition permission and create a new suggestion permission.

Test plan:
0. Setup
* Create a patron with several permission (and full acquisition
permission)
* Create another patron with several permission, and suggestions_manage
permission
* Create another patron without the suggestions_manage permission
1. Apply the patch and execute the update database entry
2. Note that the third patron you create still does not have
suggestions_manage
3. Confirm that you can create a purchase suggestion if you have
suggestions_manage, but cannot access acquisition pages if you do not
have any subpermissions of the acquisition permission

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit 462db68024)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit f0c60dfe6f)

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
2020-02-18 10:03:31 +13:00
..
accountline-details.pl Bug 20666: Correct executable permissions 2018-05-03 13:26:48 -03:00
apikeys.pl Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-31 17:07:03 +00:00
boraccount.pl Bug 20629: (QA follow-up) Remove actions_col 2018-11-06 16:32:42 +00:00
default_messageprefs.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
deletemem.pl Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-31 17:07:03 +00:00
discharge.pl Bug 18789: Use Koha::Patron->image from the templates 2018-02-16 13:03:58 -03:00
discharges.pl Bug 18403: Patron discharges 2018-02-12 15:41:41 -03:00
files.pl Bug 20226: Centralize update child code (CATCODE_MULTI) 2018-08-14 11:58:26 +00:00
guarantor_search.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
holdshistory.pl Bug 21939: Fix permissions for holds history tab 2019-12-17 13:56:35 +13:00
housebound.pl Bug 20226: Centralize update child code (CATCODE_MULTI) 2018-08-14 11:58:26 +00:00
mancredit.pl Bug 22066: Record library_id for manual credits 2019-02-01 12:31:33 +00:00
maninvoice.pl Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-31 17:07:03 +00:00
member-flags.pl Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-31 17:07:03 +00:00
member-password.pl Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-31 17:07:03 +00:00
member.pl Bug 20998: Simplify the conditional statement 2018-06-29 19:05:57 +00:00
memberentry.pl Bug 23199: Koha::Patron->store must check 'uppercasesurname' syspref 2019-08-02 20:15:42 +00:00
members-home.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
members-update-do.pl Bug 20287: Move ModMember to Koha::Patron 2018-07-18 15:49:50 +00:00
members-update.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
merge-patrons.pl Bug 9302: Add error message if keeper patron is invalid 2018-04-20 13:34:41 -03:00
mod_debarment.pl Bug 18403: Fix few errors found with hit_pages.t 2018-02-12 15:41:43 -03:00
moremember.pl Bug 21068: Remove NorwegianPatronDB related code 2018-08-30 13:40:29 +00:00
notices.pl Bug 20226: Centralize update child code (CATCODE_MULTI) 2018-08-14 11:58:26 +00:00
patronimage.pl Bug 17423 - patronimage.pl permission is too restrictive 2016-10-17 23:44:25 +00:00
pay.pl Bug 18805: Add ability to use up account credits 2018-12-10 09:58:56 +00:00
paycollect.pl Bug 22724: Check permissions in the script before displaying template 2019-05-30 21:22:37 +01:00
print_overdues.pl Bug 17553: Move GetOverduesForPatron to Koha::Patron->get_overdues 2018-04-03 11:43:06 -03:00
printfeercpt.pl Bug 20629: Remove ability to 'reverse' payments 2018-11-06 16:32:34 +00:00
printinvoice.pl Bug 20226: Centralize update child code (CATCODE_MULTI) 2018-08-14 11:58:26 +00:00
printslip.pl Bug 18403: Add sub output_and_exit_if_error - unknown_patron & cannot_see_patron_infos 2018-02-12 15:41:38 -03:00
purchase-suggestions.pl Bug 22868: Move suggestions_manage subperm out of acquisition perm 2020-02-18 10:03:31 +13:00
readingrec.pl Bug 20226: Centralize update child code (CATCODE_MULTI) 2018-08-14 11:58:26 +00:00
routing-lists.pl Bug 21397: Mark "Routing list" tab as active when selected 2018-09-26 16:18:16 +00:00
setstatus.pl Bug 18403: Fix few errors found with hit_pages.t 2018-02-12 15:41:43 -03:00
statistics.pl Bug 21027: Fix checkout statistics if 1+ of the fields is not defined 2019-08-13 19:23:23 +00:00
summary-print.pl Bug 21013: Missing itemtype for checkut makes patron summary print explode 2019-04-15 12:31:03 +01:00
update-child.pl Bug 20226: Centralize update child code (CATCODE_MULTI) 2018-08-14 11:58:26 +00:00