Koha-clms/C4/SIP/Sip
Kyle M Hall 9d811184fe
Bug 21997: SIP patron information requests can lock patron out of account
Many SIP services send an empty password field (AD). Even if allow_empty_passwords is enabled for the given SIP account, this empty password is run though Koha's password checker which increments the number of login attempts for a patron. Thus repeated patron information requests can lock a patron out! Empty password fields in SIP should not call for a password check if allow_empty_passwords is enabled.

Test Plan:
1) Enable a patron password attempt with a limit of 3
2) Send 4 patron information requests with an empty AD field
3) Note the patron's account is now locked
4) Apply this patch
5) Repeat step 2 with a different patron
6) Note the patron's account does not get locked!

Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit fac2c17214)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2019-02-26 09:23:26 +00:00
..
Checksum.pm Bug 7904 Change SIP modules to use standard LIB path 2015-02-05 14:44:54 -03:00
Configuration.pm Bug 13506: Remove unused Sip/Configuration Classes 2015-02-20 11:54:36 -03:00
Constants.pm Bug 7904 Change SIP modules to use standard LIB path 2015-02-05 14:44:54 -03:00
MsgType.pm Bug 21997: SIP patron information requests can lock patron out of account 2019-02-26 09:23:26 +00:00