Go to file
Emmi Takkinen 8d1d824436
Bug 37255: Fix handling of "All" values on waiting hold cancellation policy
If one creates a default waiting hold cancellation policy with
patron categories set as "All" and itemtype set as "All", Koha
breaks on 500 error. This happens because in we try to match
template policy with "All" values either in category or itemtype
with *, not undef. This patch fixes this.

To test:
1. Create a new default waiting hold cancellation policy and
set both patron category and itemtype as "All".
2. Save policy.
=> Error page for error 500 is displayed.
3. Apply this patch.
4. Reload page.
=> Page is displayed and policy listing displays new policy
as it should.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2024-08-12 15:35:07 -03:00
C4 Bug 37198: Improve GetPreparedLetter documentation 2024-07-19 15:32:34 +00:00
Koha Bug 37018: Add 400 response definition to all routes 2024-07-25 15:10:22 +00:00
acqui Bug 37377: Fix orders search do_search param 2024-07-24 20:10:50 +00:00
admin Bug 36880: Record overlay rules are not validated 2024-07-19 14:35:16 +00:00
api Bug 36481: (follow-up) Add missing library_id parameter 2024-07-25 15:10:22 +00:00
authorities Bug 25387: (QA follow-up) Tidy 2024-07-18 20:03:17 +00:00
basket Bug 34478: Add 'op' to sendbasketform 2024-03-01 10:58:53 +01:00
bin
…
bookings Bug 35574: Bookings tab from biblio details should only require manage_bookings permission 2023-12-18 15:21:04 +01:00
catalogue Bug 35294: Fix typos in catalogue code comments 2024-07-18 17:59:04 +00:00
cataloguing Bug 36498: Tidy cataloguing/additem.pl 2024-07-19 15:23:51 +00:00
circ Bug 37210: Properly escape SQL query parameters by using bind values 2024-07-25 15:17:43 +00:00
clubs Bug 34478: Manual fix - add op clubs/templates-add-modify 2024-03-01 10:57:55 +01:00
course_reserves Bug 34478: Manual fix - Course reserves 2024-03-01 10:56:56 +01:00
debian Bug 33563: Add comments for Elasticsearch security config 2024-07-18 19:57:49 +00:00
docs Bug 37003: (follow-up) Amend 22.11 RMaint 2024-07-18 19:44:01 +00:00
erm
…
errors Bug 36148: Improve error handling and restore programming errors 2024-03-01 11:01:06 +01:00
etc Bug 33563: Add comments for Elasticsearch security config 2024-07-18 19:57:49 +00:00
ill Bug 35106: CSRF fix 2024-04-29 18:53:09 +02:00
installer Increment version for the 24.05.02 release 2024-07-25 17:09:44 +00:00
koha-tmpl Bug 37255: Fix handling of "All" values on waiting hold cancellation policy 2024-08-12 15:35:07 -03:00
labels Bug 36931: Fix label-item-search.pl by removing CSRF requirement 2024-05-24 15:36:46 +02:00
lib Bug 35681: Use ::Bootstrap version of FromANSI 2024-05-02 16:47:39 +02:00
members Bug 33849: Do not reset new patrons home library when error occurs 2024-05-13 10:36:09 +02:00
misc Generate release notes for 24.05.02 release 2024-07-25 17:32:07 +00:00
offline_circ Bug 34478: Changes for offline_circ 2024-03-01 10:58:34 +01:00
opac Bug 30372: Fix value->attribute 2024-07-19 15:17:57 +00:00
patron_lists Bug 34478: Changes for patron_lists/add-modify 2024-03-01 10:57:41 +01:00
patroncards Bug 36877: (follow-up) Fix op eq edit to op eq edit_form in edit-batch.pl 2024-05-17 12:03:52 +02:00
plugins Bug 30897: Add option to disable automated restart 2024-04-11 16:53:42 +02:00
pos Bug 33478: Apply formatting to RECEIPT 2024-04-26 20:15:44 +02:00
preservation Bug 34030: Add a "print slips" action links to print in batch 2023-10-23 11:33:55 -03:00
recalls Bug 33478: Apply formatting to RECALL_REQUESTER_DET 2024-04-26 20:15:45 +02:00
reports Bug 36380: Add filter value on patron statistics report summary 2024-05-10 15:19:11 +02:00
reserve Bug 30579: Disentangle multi-hold and single bib forms 2024-05-07 15:53:57 +02:00
reviews Bug 37074: Comment approval and un-approval should be CSRF-protected 2024-07-25 14:08:54 +00:00
rotating_collections Bug 34478: Manual fix - add op - rotating_collections/addItems 2024-03-01 10:57:33 +01:00
serials Bug 37247: Fix display of "closed" 2024-07-25 14:24:53 +00:00
services
…
skel
…
suggestion Bug 34963: Restore the ability to blank fields when editing a suggestion 2024-04-19 18:06:36 +02:00
svc Bug 36891: Restore returning 404 from svc/bib when the bib number doesn't exist 2024-07-18 20:12:47 +00:00
t Bug 37018: Add 400 response definition to all routes 2024-07-25 15:10:22 +00:00
tags Bug 34478: Add 'op' to tags/review 2024-03-01 10:58:25 +01:00
tools Bug 37129: Patron attributes linked to an authorized value don't show a select menu in batch modification 2024-07-18 19:24:08 +00:00
virtualshelves Bug 36858: Remove warnings 2024-05-22 16:18:11 +02:00
xt Bug 37018: Add 400 response definition to all routes 2024-07-25 15:10:22 +00:00
.editorconfig
…
.eslintrc.json Bug 36400: Centralize {js,ts,vue} formatting config in .prettierrc.js 2024-04-22 08:57:39 +02:00
.gitignore Bug 36546: (QA follow-up) Add bundle spec to .gitignore 2024-04-30 15:55:37 -03:00
.htaccess
…
.mailmap Bug 36943: (follow-up) 24.05.00 - Update .mailmap 2024-05-24 15:36:40 +02:00
.perlcriticrc
…
.perltidyrc
…
.prettierrc.js Bug 36400: (follow-up) remove option editorconfig from .prettierrc.js 2024-04-22 08:57:40 +02:00
.proverc.dist
…
.stylelintrc.json
…
INSTALL
…
Koha.pm Increment version for the 24.05.02 release 2024-07-25 17:09:44 +00:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 36546: Deploy swagger_bundle.json via make 2024-04-30 14:32:10 +02:00
README
…
README.md
…
README.robots
…
about.pl Bug 32693: About script: Process only the tab being queried 2024-04-22 12:39:24 +02:00
app.psgi Bug 36149: Add userenv middleware to app.psgi 2024-05-14 15:04:37 -03:00
build-resources.PL
…
changelanguage.pl
…
cpanfile Bug 25159: Add ability to specify a pre-modified version of action log data and store as diff 2024-05-02 16:47:42 +02:00
cypress.config.ts Bug 36012: Extend cypress's requestTimeout value 2024-03-22 15:07:36 +01:00
fix-perl-path.PL
…
gulpfile.js Bug 36730: (Bug 35428 follow-up) po files (sometimes) fail to update 2024-05-07 15:53:44 +02:00
help.pl
…
kohaversion.pl
…
mainpage.pl Bug 30493: (QA follow-up) Fix for the only_my_library case as well 2024-07-18 19:31:50 +00:00
package.json Bug 36546: Deploy swagger_bundle.json via make 2024-04-30 14:32:10 +02:00
rewrite-config.PL
…
tsconfig.json
…
webpack.config.js Bug 35919: Add record sources admin page 2024-04-26 17:06:04 +02:00
yarn.lock Bug 36546: Fix js-yaml dependency in package.json 2024-04-30 14:32:09 +02:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo