This patch enforces SELECT-only SQL in the reports module. It introduces code to check SQL in two places. The first is when a save is attempted on a user constructed SQL statement. If a non-SELECT SQL statement is entered, the user will be presented with an error message and a button giving the option of editing the SQL. The second is when any SQL is executed. If execution of a non-SELECT SQL statement is attempted, the user is presented with an error message and instructed to delete that report as the SQL is invalid. The second check is intended as a safety net as no non-SELECT SQL should ever be saved. It may be well to document the proper usage of the direct SQL entry type report. Signed-off-by: Joshua Ferraro <jmf@liblime.com> |
||
|---|---|---|
| C4 | ||
| acqui | ||
| admin | ||
| authorities | ||
| catalogue | ||
| cataloguing | ||
| circ | ||
| errors | ||
| etc | ||
| install_misc | ||
| installer | ||
| koha-tmpl | ||
| labels | ||
| members | ||
| misc | ||
| opac | ||
| reports | ||
| reserve | ||
| reviews | ||
| rss | ||
| serials | ||
| skel | ||
| sms | ||
| suggestion | ||
| svc | ||
| t | ||
| tags | ||
| tmp/modified_authorities | ||
| tools | ||
| virtualshelves | ||
| xt | ||
| .htaccess | ||
| INSTALL | ||
| INSTALL.debian | ||
| INSTALL.fedora7 | ||
| INSTALL.opensuse | ||
| LICENSE | ||
| MANIFEST.SKIP | ||
| Makefile.PL | ||
| README | ||
| about.pl | ||
| changelanguage.pl | ||
| edithelp.pl | ||
| fix-perl-path.PL | ||
| help.pl | ||
| install-CPAN.pl | ||
| kohaversion.pl | ||
| mainpage.pl | ||
| rewrite-config.PL | ||
README
Koha 3 - the next-generation release of the award-winning Koha open-source integrated library system. 30 December 2007 - Joshua Ferraro <jmf AT liblime DOT com> Koha is distributed under the GNU GPL. Please read the file LICENSE for more details. To install or upgrade Koha, please see the INSTALL file. Please report any bugs to the koha mailing lists or bug tracker and we will try to fix them in a future release. The main koha web site is http://www.koha.org/