Go to file
Nick Clemens 7bbf4f7b5f Bug 17515: Order Z3950 server by rank and preserve ordering
Previously we put all the servers into an object with keys of the server id

This patch converts it to an array of objects to preserve order, and adjusts code to use the array index
where necessary and store the server id within the array

To test:
1 - Add some new Z3950 servers, they don't need to be valid
    FIRST
    SECOND
    THIRD
    FOURTH
2 - Adjust the ranking so FOURTH:1 THIRD:2 SECOND:3 FIRST:4
3 - Enable and launch the advanced editor
4 - Click 'Advanced' under search on the left
5 - Note the list displays in the order you entered the servers
6 - Apply patch
7 - Reload
8 - Order is correct
9 - With valid servers, confirm that searching still works and servers can be checked or unchecked to include/remove from results

https://bugs.koha-community.org/show_bug.cgi?id=17515

Signed-off-by: B Johnson <barbara.johnson@bedfordtx.gov>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-11-02 11:03:09 +01:00
C4 Bug 22806: (QA follow-up) 2020-11-02 11:03:08 +01:00
Koha Bug 17515: Order Z3950 server by rank and preserve ordering 2020-11-02 11:03:09 +01:00
acqui Bug 26577: Make basket.pl and cancelorder.pl use ->cancel 2020-10-15 14:50:07 +02:00
admin Bug 26487: Add all MARC flavours for not-onloan-count search field 2020-11-02 11:03:08 +01:00
api Bug 26595: Embed the whole smtp_server object 2020-10-14 15:53:38 +02:00
authorities Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
basket Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
bin Bug 20582: Turn Koha into a Mojolicious application 2020-10-06 12:00:04 +02:00
catalogue Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cataloguing Bug 17515: Order Z3950 server by rank and preserve ordering 2020-11-02 11:03:09 +01:00
circ Bug 18170: Show damaged status in table of checkins 2020-10-15 12:56:31 +02:00
clubs Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
course_reserves Bug 25898: Fix new occurrences 2020-10-15 13:56:41 +02:00
debian Bug 25898: Fix indirect object notation in debian/list-deps 2020-10-26 16:01:52 -03:00
docs Bug 7143: Update about page for new devs 2020-10-26 00:16:14 +01:00
errors Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
etc Bug 20582: Add very simple configuration file for Apache 2020-10-06 12:00:04 +02:00
ill Bug 23173: (follow-up) Small improvements in efficiency 2020-04-06 11:05:09 +01:00
installer Bug 18050: move aqbudgetperiods table before aqbudgets, to fix sql error 2020-10-26 15:55:11 -03:00
koha-tmpl Bug 17515: Order Z3950 server by rank and preserve ordering 2020-11-02 11:03:09 +01:00
labels Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
members Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
misc Bug 26601: Add utf8 encoding to text output of overdue_notices.pl 2020-10-26 00:14:41 +01:00
offline_circ Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
opac Bug 22806: (QA follow-up) 2020-11-02 11:03:08 +01:00
patron_lists Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
patroncards Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
plugins Bug 26751: Fix fatal exception if only one repo defined 2020-10-22 10:23:55 +02:00
pos Bug 26418: Fix translatability of REFUND credit type 2020-09-28 15:07:27 +02:00
reports Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
reserve Bug 22806: (QA follow-up) 2020-11-02 11:03:08 +01:00
reviews Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
rotating_collections Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
serials Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
services Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
skel
…
suggestion Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
svc Bug 17515: Order Z3950 server by rank and preserve ordering 2020-11-02 11:03:09 +01:00
t Bug 22806: (QA follow-up) 2020-11-02 11:03:08 +01:00
tags Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
tmp/modified_authorities
…
tools Bug 26784: Silence warns about comparing undefined values for MARC modification templates 2020-10-26 00:14:41 +01:00
virtualshelves Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
xt Bug 24972: Remove de-DE installer data 2020-10-26 00:14:42 +01:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
…
.mailmap Bug 26621: Adjust .mailmap to reduce the number of invalid authors 2020-10-15 12:56:30 +02:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Bug 18050: DBRev 20.06.00.055 2020-10-26 00:14:42 +01:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 20582: Map app.psgi file and bin directory in Makefile.PL 2020-10-06 18:14:30 +02:00
README
…
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots
…
about.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 22417: Add new Net::Stomp dependency 2020-10-05 15:23:08 +02:00
fix-perl-path.PL Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
gulpfile.js Bug 20168: (follow-up) Add automatic creation of RTL CSS 2020-09-09 14:13:09 +02:00
help.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
mainpage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
package.json Bug 20168: (follow-up) Add automatic creation of RTL CSS 2020-09-09 14:13:09 +02:00
rewrite-config.PL Bug 26290: Make Makefile.PL aware of SMTP configs 2020-10-02 15:27:18 +02:00
yarn.lock Bug 20168: (follow-up) Add automatic creation of RTL CSS 2020-09-09 14:13:09 +02:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo