gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/cataloguing/value_builder
History
Baptiste Wojtkowski d09a7f3cdf
Bug 8425: Increment the barcode on each call of set_barcode() 
Duplicate barcodes are generated when placing an Order in Acquisitions when AcqCreateItem = "placing an order" and Autobarcode is turned on.

The problem is that you can accidentally attach 3 items to an order, but only 1 will be saved to the database. When you go to receive your order, you can only receive 1 item as the other two were never made, since the barcode wasn't unique.

In 3.8.0, a software error comes up which prevent any item creation, I believe, but master (3.9.x) doesn't throw any warnings or errors.

Yes.. This tries and solve a bug from 3.8.0 /o/

Test plan:
1 - set syspref "autoBarcode" to generated in the form <branchcode> yymm001
2 - set the barcode field to "barcode.pl" in marc structure
3 - create a new basket
4 - add one item to this basket
5 - click on the barcode field -> it should have a barcode
6 - click on add item and click on the new barcode fiels, it should have
 the same value
 APPLY PATCH:
7 - click on the barcode field -> it should have a barcode
8 - click on add item and click on the new barcode fields, it should have
  an higher barcode.

Note : The barcode is incremented each time the barcode with an empty
value is clicked on. Therefore, if the
librarian removes the value from barcode and click again, they could get
another barcode. I do not know if it is an issue.
Note: This patch is not splitted in two parts anymore

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Signed-off-by: Magnus Enger <magnus@libriotech.no>
Followed the test plan, works as advertised.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit b7ed38413a)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
 		2025-04-22 23:02:11 +02:00
..
EXAMPLE.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
barcode.pl Bug 8425: Increment the barcode on each call of set_barcode() 2025-04-22 23:02:11 +02:00
barcode_manual.pl Bug 24879: Add check_cookie_auth when missing 2024-04-03 17:05:50 +02:00
callnumber-KU.pl Bug 32814: Fix cataloguing/value_builder/callnumber-KU.pl 2023-02-20 09:54:13 -03:00
callnumber.pl Bug 32815: Fix cataloguing/value_builder/callnumber.pl 2023-03-06 09:51:46 -03:00
cn_browser.pl Bug 33365: Add item type column to cn_browser results 2023-05-16 10:17:14 -03:00
dateaccessioned.pl Bug 37371: Move Maskito init to onReady in dateaccessioned.pl 2024-07-22 07:33:18 +01:00
marc21_field_005.pl Bug 24879: Add check_cookie_auth when missing 2024-04-03 17:05:50 +02:00
marc21_field_006.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
marc21_field_007.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
marc21_field_008.pl Bug 27461: Right pad with default elements for too short 008s 2021-09-28 15:12:45 +02:00
marc21_field_008_authorities.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
marc21_field_008_classifications.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
marc21_field_245h.pl Bug 24879: Add check_cookie_auth when missing 2024-04-03 17:05:50 +02:00
marc21_field_260b.pl Bug 24879: Add check_cookie_auth when missing 2024-04-03 17:05:50 +02:00
marc21_leader.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
marc21_leader_authorities.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
marc21_linking_section.pl Bug 36577: (bug 34478 follow-up) marc21_linking_section.pl not working 2024-04-18 16:51:12 +02:00
marc21_orgcode.pl Bug 24879: Add check_cookie_auth when missing 2024-04-03 17:05:50 +02:00
stocknumber.pl Bug 24879: Add check_cookie_auth when missing 2024-04-03 17:05:50 +02:00
stocknumberAV.pl Bug 38030: (QA follow-up) Move csrf_token to POST body from URL 2024-11-21 13:49:08 +01:00
stocknumberam123.pl Bug 32819: Fix cataloguing/value_builder/stocknumberam123.pl 2023-03-06 09:51:47 -03:00
unimarc_field_4XX.pl Bug 32872: Fix cataloguing/value_builder/unimarc_field_4XX.pl 2023-04-24 10:43:26 -03:00
unimarc_field_009_ppn.pl Bug 31536: Add UNIMARC framework plugin to fetch PPN from sudoc.fr 2022-10-04 08:02:58 -03:00
unimarc_field_010.pl Bug 32822: Fix cataloguing/value_builder/unimarc_field_010.pl 2023-02-24 16:46:40 -03:00
unimarc_field_100.pl Bug 32824: Fix cataloguing/value_builder/unimarc_field_100.pl 2023-02-24 16:44:34 -03:00
unimarc_field_100_authorities.pl Bug 32823: Fix cataloguing/value_builder/unimarc_field_100_authorities.pl 2023-02-24 17:00:48 -03:00
unimarc_field_105.pl Bug 32825: Fix cataloguing/value_builder/unimarc_field_105.pl 2023-02-24 16:43:57 -03:00
unimarc_field_106.pl Bug 32826: (QA follow-up) Remove tab 2023-02-24 17:00:58 -03:00
unimarc_field_110.pl Bug 32827: Fix cataloguing/value_builder/unimarc_field_110.pl 2023-02-24 17:01:08 -03:00
unimarc_field_115a.pl Bug 32828: Fix cataloguing/value_builder/unimarc_field_115a.pl 2023-02-24 17:01:17 -03:00
unimarc_field_115b.pl Bug 32829: Fix cataloguing/value_builder/unimarc_field_115b.pl 2023-02-24 17:01:25 -03:00
unimarc_field_116.pl Bug 32830: Fix cataloguing/value_builder/unimarc_field_116.pl 2023-03-27 11:29:38 +02:00
unimarc_field_117.pl Bug 32831: Fix cataloguing/value_builder/unimarc_field_117.pl 2023-03-27 11:29:53 +02:00
unimarc_field_120.pl Bug 32832: Fix cataloguing/value_builder/unimarc_field_120.pl 2023-03-27 11:29:54 +02:00
unimarc_field_121a.pl Bug 32833: Fix cataloguing/value_builder/unimarc_field_121a.pl 2023-03-27 11:29:55 +02:00
unimarc_field_121b.pl Bug 32834: Fix cataloguing/value_builder/unimarc_field_121b.pl 2023-03-28 15:38:09 +02:00
unimarc_field_122.pl Bug 32835: Fix cataloguing/value_builder/unimarc_field_122.pl 2023-02-24 16:44:17 -03:00
unimarc_field_123a.pl Bug 32836: Fix cataloguing/value_builder/unimarc_field_123a.pl 2023-03-28 15:38:07 +02:00
unimarc_field_123defg.pl Bug 34657: Merge cataloging plugins for UNIMARC 123d, e, f, and g 2023-10-09 11:41:18 -03:00
unimarc_field_123i.pl Bug 32841: Fix cataloguing/value_builder/unimarc_field_123i.pl 2023-03-29 12:28:54 +02:00
unimarc_field_123j.pl Bug 32842: Fix cataloguing/value_builder/unimarc_field_123j.pl 2023-03-29 12:28:55 +02:00
unimarc_field_124.pl Bug 32850: Fix cataloguing/value_builder/unimarc_field_124.pl 2023-03-29 12:29:04 +02:00
unimarc_field_124a.pl Bug 32843: Fix cataloguing/value_builder/unimarc_field_124a.pl 2023-03-29 12:28:56 +02:00
unimarc_field_124b.pl Bug 32844: Fix cataloguing/value_builder/unimarc_field_124b.pl 2023-03-29 12:28:57 +02:00
unimarc_field_124c.pl Bug 32845: Fix cataloguing/value_builder/unimarc_field_124c.pl 2023-03-29 12:28:58 +02:00
unimarc_field_124d.pl Bug 32846: Fix cataloguing/value_builder/unimarc_field_124d.pl 2023-03-29 12:28:59 +02:00
unimarc_field_124e.pl Bug 32847: Fix cataloguing/value_builder/unimarc_field_124e.pl 2023-03-29 12:29:01 +02:00
unimarc_field_124f.pl Bug 32848: Fix cataloguing/value_builder/unimarc_field_124f.pl 2023-03-29 12:29:02 +02:00
unimarc_field_124g.pl Bug 32849: Fix cataloguing/value_builder/unimarc_field_124g.pl 2023-03-29 12:29:03 +02:00
unimarc_field_125.pl Bug 32853: Fix cataloguing/value_builder/unimarc_field_125.pl 2023-10-30 09:02:15 -03:00
unimarc_field_125a.pl Bug 32851: Fix cataloguing/value_builder/unimarc_field_125a.pl 2023-03-29 12:29:05 +02:00
unimarc_field_125b.pl Bug 32852: Fix cataloguing/value_builder/unimarc_field_125b.pl 2023-03-29 12:29:06 +02:00
unimarc_field_126.pl Bug 32856: Fix cataloguing/value_builder/unimarc_field_126.pl 2023-10-30 09:02:14 -03:00
unimarc_field_126a.pl Bug 32854: Fix cataloguing/value_builder/unimarc_field_126a.pl 2023-03-30 12:12:39 +02:00
unimarc_field_126b.pl Bug 32855: Fix cataloguing/value_builder/unimarc_field_126b.pl 2023-03-30 12:12:51 +02:00
unimarc_field_127.pl Bug 32857: Fix cataloguing/value_builder/unimarc_field_127.pl 2023-03-30 12:31:37 +02:00
unimarc_field_128a.pl Bug 32858: Fix cataloguing/value_builder/unimarc_field_128a.pl 2023-03-30 12:31:38 +02:00
unimarc_field_128b.pl Bug 32859: Fix cataloguing/value_builder/unimarc_field_128b.pl 2023-03-30 12:31:39 +02:00
unimarc_field_128c.pl Bug 32860: Fix cataloguing/value_builder/unimarc_field_128c.pl 2023-03-30 12:31:40 +02:00
unimarc_field_130.pl Bug 32861: Fix cataloguing/value_builder/unimarc_field_130.pl 2023-03-30 12:31:41 +02:00
unimarc_field_135a.pl Bug 32862: Fix cataloguing/value_builder/unimarc_field_135a.pl 2023-03-30 12:31:42 +02:00
unimarc_field_140.pl Bug 32863: Fix cataloguing/value_builder/unimarc_field_140.pl 2023-03-30 12:31:43 +02:00
unimarc_field_141.pl Bug 32864: Fix cataloguing/value_builder/unimarc_field_141.pl 2023-03-30 12:31:44 +02:00
unimarc_field_146a.pl Bug 32865: Fix cataloguing/value_builder/unimarc_field_146a.pl 2023-04-24 10:43:34 -03:00
unimarc_field_146b.pl Bug 30941: (QA follow-up) Add exec flag to scripts 2022-08-19 08:55:09 -03:00
unimarc_field_146c.pl Bug 30941: (QA follow-up) Add exec flag to scripts 2022-08-19 08:55:09 -03:00
unimarc_field_146d.pl Bug 30941: (QA follow-up) Add exec flag to scripts 2022-08-19 08:55:09 -03:00
unimarc_field_146e.pl Bug 30941: (QA follow-up) Add exec flag to scripts 2022-08-19 08:55:09 -03:00
unimarc_field_146f.pl Bug 30941: (QA follow-up) Add exec flag to scripts 2022-08-19 08:55:09 -03:00
unimarc_field_146h.pl Bug 32866: Fix cataloguing/value_builder/unimarc_field_146h.pl 2023-04-24 10:43:29 -03:00
unimarc_field_146i.pl Bug 32867: Fix cataloguing/value_builder/unimarc_field_146i.pl 2023-04-24 10:43:28 -03:00
unimarc_field_181-2.pl Bug 30504: Value builder for field 181 2022-08-19 08:45:22 -03:00
unimarc_field_181a.pl Bug 30504: Value builder for field 181 2022-08-19 08:45:22 -03:00
unimarc_field_181b.pl Bug 30504: Value builder for field 181 2022-08-19 08:45:22 -03:00
unimarc_field_181c.pl Bug 30504: Value builder for field 181 2022-08-19 08:45:22 -03:00
unimarc_field_182-2.pl Bug 30506: Value builder for field 182 2022-08-19 08:45:50 -03:00
unimarc_field_182a.pl Bug 30506: Value builder for field 182 2022-08-19 08:45:50 -03:00
unimarc_field_182c.pl Bug 30506: Value builder for field 182 2022-08-19 08:45:50 -03:00
unimarc_field_183-2.pl Bug 30507: Value builder for field 183 2022-08-19 08:46:27 -03:00
unimarc_field_183a.pl Bug 30507: Value builder for field 183 2022-08-19 08:46:27 -03:00
unimarc_field_210c.pl Bug 32869: Fix cataloguing/value_builder/unimarc_field_210c.pl 2023-04-24 10:43:32 -03:00
unimarc_field_210c_bis.pl Bug 32868: Fix cataloguing/value_builder/unimarc_field_210c_bis.pl 2023-04-24 10:43:31 -03:00
unimarc_field_225a.pl Bug 32871: Fix cataloguing/value_builder/unimarc_field_225a.pl 2023-04-24 10:43:30 -03:00
unimarc_field_225a_bis.pl Bug 32870: Fix cataloguing/value_builder/unimarc_field_225a_bis.pl 2023-04-24 10:43:33 -03:00
unimarc_field_283-2.pl Bug 31371: Value builder for field 283 2022-10-04 08:02:21 -03:00
unimarc_field_283a.pl Bug 31371: Value builder for field 283 2022-10-04 08:02:21 -03:00
unimarc_field_325h.pl Bug 31372: Value builder for field 325 2022-10-04 08:01:17 -03:00
unimarc_field_325j.pl Bug 31372: Value builder for field 325 2022-10-04 08:01:17 -03:00
unimarc_field_686a.pl Bug 32873: Fix cataloguing/value_builder/unimarc_field_686a.pl 2023-04-24 10:43:32 -03:00
unimarc_leader.pl Bug 32876: Fix cataloguing/value_builder/unimarc_leader.pl 2023-04-24 10:43:24 -03:00
unimarc_leader_authorities.pl Bug 32875: Fix cataloguing/value_builder/unimarc_leader_authorities.pl 2023-04-24 10:43:25 -03:00
upload.pl Bug 24879: Add check_cookie_auth when missing 2024-04-03 17:05:50 +02:00