Koha-clms/tools
Mark Tompsett 13325b2597 Bug 14001: Inventory has bad $_ references
After receiving an error while attempt a simple inventory run,
Two lines were changed from:
    ...$_->...
to
    ...$item->...
since the loop variable is $item. And $_ is not set to the
expected hash reference, when there is a loop variable.

This also helps explain the "Why are there blank dates on my
last seen field?" problem that has been mentioned by users.

TEST PLAN
---------
 1) Apply this patch after a reset to master.
 2) Log in to staff client
 3) Add one item via z39.50, setting barcode to a known value (BARCODE1)
 4) Wait for the reindex
 5) Home -> Tools -> Inventory/Stocktaking
 6) Browse for a file with the barcode in it
 7) Set the library dropdown to the library branch of the added item.
 8) Check 'Compare barcodes list to results:'
 9) Click 'Submit'
    -- This should not die under plack.
       This should not generate blank last seen dates.
       The last seen dates should be as expected.
10) run koha qa test tools
11) Confirm the two change point correspond to the two change points
    in the patch which shall not be pushed to master.

The test result comply with expected outcome outlined in test plan.

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
(cherry picked from commit 3ebc081962)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
2015-07-16 09:36:35 +00:00
..
csv-profiles MT2116: Addons to the CSV export 2010-02-17 07:51:33 -05:00
quotes Bug 14440: get_template_and_user can not have an empty template_name (quote*_ajax.pl) 2015-07-05 02:20:59 +00:00
ajax-inventory.pl Bug 7684: QA Followup and bugfixes 2013-11-01 00:11:45 +00:00
background-job-progress.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
batchMod.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
batch_delete_records.pl Bug 12403 [Follow-up] Batch record deletion 2014-11-07 15:26:02 -03:00
batch_records_ajax.pl Bug 11876 [Follow-up] Add a diff view to staged MARC Records 2014-10-31 14:25:11 -03:00
cleanborrowers.pl Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:58 +12:00
copy-holidays.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
csv-profiles.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
exceptionHolidays.pl Bug 7351 : feature that allows to delete a range of dates 2012-09-28 12:19:45 +02:00
export.pl Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:58 +12:00
holidays.pl Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:58 +12:00
import_borrowers.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
inventory.pl Bug 14001: Inventory has bad $_ references 2015-07-16 09:36:35 +00:00
koha-news.pl Bug 12740: Make the error message translatable 2014-10-11 11:52:16 -03:00
letter.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
manage-marc-import.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
marc_modification_templates.pl Bug 8015: QA Followup 2 2013-10-31 22:50:48 +00:00
modborrowers.pl Bug 11929: patron modification error shows borrowernumber 2015-06-08 14:14:52 +12:00
newHolidays.pl Bug 8842 fix Plack scoping for holidays 2012-11-05 08:41:17 -05:00
overduerules.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
picture-upload.pl Bug 14338: Unable to delete patron images 2015-06-16 13:23:34 +12:00
quotes-upload.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
quotes.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
scheduler.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
showdiffmarc.pl Bug 6520: Display items for staged record - diff view 2015-04-22 11:07:00 +12:00
stage-marc-import.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
tools-home.pl Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:58 +12:00
upload-cover-image.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
upload-file-progress.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
upload-file.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
viewlog.pl Bug 10355: paramater 'object' lost on the road 2015-06-16 10:34:05 +12:00