Go to file
Fridolin Somers 7494cea82f Bug 23542: Fix SRU import encoding
When importing records from a SRU server, the diacritics have bad encoding.
I reproduce with BNF server so it may be a UNIMARC issue.

Tests show that difference between Z39.50 server and SRU is that leader contains 'a' at postion 9.
Looking at MARC::Record->encoding() shows that encoding depends on leader even for UNIMARC.
So this patch adds a call to MARC::Record->encoding('UTF-8') in case of a SRU server in C4::Breeding.

Same use exists in Koha::MetadataRecord::Authority::get_from_breeding().

In case of import via Z3950, MarcToUTF8Record() is called,
 which calls SetMarcUnicodeFlag(),
 which calls MARC::Record->encoding('UTF-8')

Test plan :
1) Use a UNIMARC database
2) Configure a connexion to a UNIMARC SRU, for example BNF,
   see https://doc.biblibre.com/koha/autour_de_koha/serveurs_z3950_sru#serveur_de_la_bnf
3) Go to cataloguing module
4) Click on 'New from Z39.50/SRU'
5) Choose only the SRU target
6) Search for ISBN 2266072889
7) Confirm you see good encoding : diacritic on 'a' of title 'Strate-a-gemmes'
8) Click on 'Marc preview'
9) Confirm you see good encoding
10) Click import
11) Confirm you see good encoding
12) Check also Authorities import via SRU
13) Check also SRU imports on a MARC21 database

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Amended: Removed change to new_from_xml call. We should respect syntax.
But the added MARC::Record encoding does the tric! Which is implicit
for Z3950 targets where MarcToUTF8Record does the same.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 19d9ba176d)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 79855e9f5b)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
2020-08-17 21:53:46 +12:00
C4 Bug 23542: Fix SRU import encoding 2020-08-17 21:53:46 +12:00
Koha Bug 25882: Remove phr indicator from limits when processing 2020-08-17 21:30:44 +12:00
OpenILS
…
acqui Bug 25599: Fix default value placeholders for UseACQFrameworkForBiblioRecords 2020-08-13 16:12:42 +12:00
admin Bug 25873: Ignore malformed data for Elasticsearch integer fields 2020-08-17 09:00:55 +12:00
api/v1 Bug 25944: Schema fix for illrequests route 2020-07-31 01:19:02 +12:00
authorities Bug 25428: Correctly encode link if authority subfield is a URL 2020-06-09 05:06:03 +00:00
basket Bug 17842: Simplify the code 2020-06-18 13:48:02 +12:00
catalogue Bug 5103: Refactor the code to avoid repetition 2020-04-03 17:26:54 +00:00
cataloguing Bug 25553: Make date columns sortable on the edit items table 2020-07-13 10:07:41 +12:00
circ Bug 25868: Fix transfers page to show effective itemtype 2020-07-31 01:48:08 +12:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Revert "Bug 23727: Editing course reserve items is broken" 2020-05-19 23:46:46 +00:00
debian Bug 25920: Add liblocale-codes-perl package to fix ubuntu-stable (focal) 2020-08-07 13:42:10 +12:00
docs Corrections to teams for 20.05 cycle 2019-11-29 12:10:34 +00:00
errors Bug 23329: Move error page to its own subroutine 2019-11-27 11:30:19 +00:00
etc Bug 25277: Don't specify a field in query if none passed 2020-05-19 22:57:25 +00:00
ill Bug 21460: (follow-up) Fix bugs found in QA 2019-04-25 10:46:56 +00:00
installer Bug 26070: DBRev 19.11.08.003 2020-08-07 14:22:05 +12:00
koha-tmpl Bug 25336: Show checkouts/fines to guarantor is in the wrong section of the patron file 2020-08-17 11:28:43 +12:00
labels Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
members Bug 25526: Equality matching is case sensative 2020-06-18 13:51:58 +12:00
misc Bug 25853: Fix file permissions for update_patrons_category script 2020-08-17 11:13:25 +12:00
offline_circ Bug 22600: Add 'interface' to accountlines 2019-04-10 19:43:11 +00:00
opac Bug 26070: Remove GoogleIndicTransliteration system preference 2020-08-07 14:20:49 +12:00
patron_lists Bug 19524: Use existing logged_in_user variable 2018-07-18 16:49:30 +00:00
patroncards Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
plugins Bug 21073: (QA follow-up) Avoid unnecessary unless/else construct 2019-06-18 17:30:44 +01:00
reports Bug 24940: Serials statistics wizard: order vendor list alphabetically 2020-05-01 17:39:21 +00:00
reserve Bug 24802: Updating holds can cause suspensions to apply to wrong hold 2020-04-01 22:42:26 +00:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-09 15:02:45 +00:00
serials Bug 25081: Fix wrong comment 2020-05-04 20:44:10 +00:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel
…
suggestion Bug 22868: Move suggestions_manage subperm out of acquisition perm 2020-02-10 23:08:59 +00:00
svc Bug 24964: [19.11.x] Do not filter patrons after they have been fetched 2020-04-29 15:57:56 +00:00
t Bug 25882: Unit test 2020-08-17 21:30:07 +12:00
tags Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
tmp/modified_authorities
…
tools Bug 25893: Use wildcards when searching logs 2020-08-17 10:04:11 +12:00
virtualshelves Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
xt Bug 21576: Keep compatibility with QA script 2018-10-26 17:09:52 +00:00
.editorconfig
…
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
…
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Bug 26070: DBRev 19.11.08.003 2020-08-07 14:22:05 +12:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 24445: Add z3950 to makefile (bug 13937 follow-up) 2020-01-18 15:05:48 +00:00
README
…
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots
…
about.pl Bug 25506: Fix for "Use of uninitialized value" in about.pl 2020-06-09 03:13:10 +00:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
fix-perl-path.PL
…
gulpfile.js Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display 2019-02-04 14:13:35 +00:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl
…
mainpage.pl Bug 21907: Fix article requests count for non-superlibrarians 2019-02-04 14:50:40 +00:00
package.json Bug 23025: security vulnerability detected in fstream < 1.0.12 defined in yarn.lock 2019-11-27 11:30:17 +00:00
rewrite-config.PL Bug 17851: Add elasticsearch config to koha-conf.xml 2019-10-07 14:09:10 +01:00
yarn.lock Bug 23025: Update yarn.lock 2019-11-27 11:30:17 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo