gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
43,273 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Jonathan Druart 6545259bbf Bug 28785: Centralize cookie auth check in check_cookie_auth 
This code is duplicated in 3 different places, we must call
check_cookie_auth instead.

It makes check_cookie_auth returns a 'restricted' when
SessionRestrictionByIP is set and the IP changed.
It also returns a third parameters contained the old and new IP, to fill
the "info" hash in checkauth but apparently the oldip and newip
variables are not even used from the template. We may want to remove it
completely.

No change is expected with this patch, the different authentication
methods should still work as before.

Test plan:
Log in the staff and OPAC interfaces, logout.
Log in and call script that call the 3 different subroutines modified by
this patch. For instance you can list checkouts (that is using
check_cookie_auth) and display a patron's image (using check_api_auth).

QA with good knowledge of the C4::Auth module and the different
authentication methods is required.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
 		2021-10-18 11:28:41 +02:00
C4 Bug 28785: Centralize cookie auth check in check_cookie_auth 2021-10-18 11:28:41 +02:00
Koha Bug 28445: Split and join on ' | ' instead of '|' for repeatable 2021-10-18 11:28:40 +02:00
acqui Bug 29243: Correct call when adding items from staged records 2021-10-18 11:28:41 +02:00
admin Bug 18984: Remove ES mapping for NORMARC 2021-10-07 15:36:40 +02:00
api Bug 27947: (QA follow-up) Clarify permissions 2021-10-06 10:09:25 +02:00
authorities Bug 28769: Remove tabloop from cataloguing plugins 2021-10-18 11:28:40 +02:00
basket Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
bin Bug 20582: Turn Koha into a Mojolicious application 2020-10-06 12:00:04 +02:00
catalogue Bug 28484: ES clean title in biblio detail 2021-09-29 11:34:18 +02:00
cataloguing Bug 28445: Use the task queue for the batch delete and update items tool 2021-10-18 11:28:40 +02:00
circ Bug 27949: Allow multiple article requests print slip 2021-10-18 11:28:41 +02:00
clubs Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
course_reserves Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
debian Bug 18984: Remove NORMARC support 2021-10-07 15:36:40 +02:00
docs Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
errors Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
etc Bug 28337: Use existing definition in ccl.properties and bib1.att 2021-10-15 11:34:26 +02:00
ill Bug 22614: Migrate original request 2021-09-21 20:22:57 +02:00
installer Bug 29093: (follow-up) DBRev 21.06.00.033 2021-10-15 13:17:43 +02:00
koha-tmpl Bug 27949: (QA follow-up) Remove TODO 2021-10-18 11:28:41 +02:00
labels Bug 17600: Fix POSIX imports 2021-07-29 14:37:26 +02:00
lib/CGI/Session/Serialize Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
members Bug 15812: Use patron search in place of circ search 2021-10-14 09:19:30 +02:00
misc Bug 28445: Use the task queue for the batch delete and update items tool 2021-10-18 11:28:40 +02:00
offline_circ Bug 26351: Add plugin hooks to transform item barcodes 2021-10-06 14:56:09 +02:00
opac Bug 29093: Interface changes 2021-10-15 11:34:26 +02:00
patron_lists Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
patroncards Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
plugins Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
pos Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
reports Bug 28804: (bug 25026 follow-up) Handle SQL errors in reports 2021-08-11 12:00:10 +02:00
reserve Bug 29116: Use a pre-existing accessor instead of reimplementing it 2021-10-12 11:15:32 +02:00
reviews Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
rotating_collections Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
serials Bug 29111: Remove unused indicator modification code for items 2021-10-15 11:34:26 +02:00
services Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
skel
…
suggestion Bug 28946: (bug 23271 follow-up) Missing occurrence in add_user_search.pl 2021-09-14 18:23:28 +02:00
svc Bug 28931: Use EXPORT_OK from Koha::DateUtils 2021-10-07 11:01:05 +02:00
t Bug 28445: Split and join on ' | ' instead of '|' for repeatable 2021-10-18 11:28:40 +02:00
tags Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
tmp/modified_authorities
…
tools Bug 28445: Fix subfields to blank 2021-10-18 11:28:40 +02:00
virtualshelves Bug 12561: Change prototype of XSLTParse4Display 2021-08-16 09:57:05 +02:00
xt Bug 27622: Fix sample_notices.t 2021-10-07 15:49:01 +02:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore
…
.htaccess
…
.mailmap Bug 28386: Disambiguate Tomas and Blou 2021-05-26 12:30:59 +02:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.scss-lint.yml
…
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Bug 29093: DBRev 21.06.00.033 2021-10-15 11:34:26 +02:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 18984: Remove NORMARC support 2021-10-07 15:36:40 +02:00
README
…
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots
…
about.pl Bug 28870: Move email address validation to a specific class method 2021-09-28 10:22:36 +02:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 28870: Remove traces of Email::Valid 2021-09-28 10:22:35 +02:00
fix-perl-path.PL Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
gulpfile.js Bug 18984: Remove NORMARC support 2021-10-07 15:36:40 +02:00
help.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
koha_perl_deps.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
mainpage.pl Bug 27944: (QA follow-up) Make staff home page show new article requests 2021-10-05 10:58:14 +02:00
package.json Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00
rewrite-config.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-17 10:07:36 +02:00
yarn.lock Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo