Koha-clms/svc
Nick Clemens 17571f824d Bug 17515: Order Z3950 server by rank and preserve ordering
Previously we put all the servers into an object with keys of the server id

This patch converts it to an array of objects to preserve order, and adjusts code to use the array index
where necessary and store the server id within the array

To test:
1 - Add some new Z3950 servers, they don't need to be valid
    FIRST
    SECOND
    THIRD
    FOURTH
2 - Adjust the ranking so FOURTH:1 THIRD:2 SECOND:3 FIRST:4
3 - Enable and launch the advanced editor
4 - Click 'Advanced' under search on the left
5 - Note the list displays in the order you entered the servers
6 - Apply patch
7 - Reload
8 - Order is correct
9 - With valid servers, confirm that searching still works and servers can be checked or unchecked to include/remove from results

https://bugs.koha-community.org/show_bug.cgi?id=17515

Signed-off-by: B Johnson <barbara.johnson@bedfordtx.gov>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 7bbf4f7b5f)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2020-11-16 18:31:26 +00:00
..
cataloguing Bug 17515: Order Z3950 server by rank and preserve ordering 2020-11-16 18:31:26 +00:00
club Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
config Bug 14391: (QA follow-up) Resolve POD warn on svc..systempreferences 2018-11-07 12:29:32 +00:00
hold Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
letters Bug 26331: Make svc/letters/preview executable 2020-09-14 21:22:22 +00:00
mana Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
members Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
records Bug 24663: Force authentication in svc/records/preview (?) 2020-08-31 20:04:05 +00:00
virtualshelves Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
article_request Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
authentication Bug 20016: use Modern::Perl in svc scripts 2018-02-05 09:46:45 -03:00
barcode Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
bib Bug 24827: Standardise on 'UTF-8' as the encoding name 2020-03-16 14:45:39 +00:00
bib_framework Bug 16424: (QA follow-up) Use Modern::Perl 2018-09-28 19:01:51 +00:00
bib_profile Bug 20016: use Modern::Perl in svc scripts 2018-02-05 09:46:45 -03:00
checkin Bug 23463: Replace ModItem with Koha::Item->store 2020-03-23 09:26:30 +00:00
checkout_notes Bug 17698: Make patron notes show up on staff dashboard 2018-07-23 15:23:40 +00:00
checkouts Bug 26424: Better performance of svc/checkouts 2020-10-20 13:43:49 +00:00
convert_report Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
cover_images Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
creator_batches Bug 15766: (follow-up) Fixing layout of description button 2018-10-24 13:52:43 +00:00
holds Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
import_bib Bug 24827: Standardise on 'UTF-8' as the encoding name 2020-03-16 14:45:39 +00:00
localization Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
new_bib Bug 24827: Standardise on 'UTF-8' as the encoding name 2020-03-16 14:45:39 +00:00
problem_reports Bug 4461: Fix status and borrowernumber fields in problem_reports and more 2020-04-06 11:18:59 +01:00
renew Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
report Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
return_claims Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
split_callnumbers Bug 26251: Remove unused routines from svc/split_callnumbers 2020-09-04 16:15:09 +00:00