5a5d1b8089
This patch fixes the logic in a condition to address the fact that permissions are not checked for plugins. This was due to bad parenthesis pairing and the lack of good tests for this. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t => FAIL: Tests fail because of bad logic 3. Apply this patch 4. Repeat (2) => SUCCESS: Tests pass! 5. Verify the tests cover the use cases that are needed: - Anonymous access - Real user with wrong permissions (parameters => 1) - Real user with right permissions (borrowers => 1) => SUCCESS: Needed use cases so we catch any regression are found 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> (cherry picked from commit 66402643d7cb95bf5ebc4832bff61becfa3d5a6a) |
||
|---|---|---|
| .. | ||
| Plugin | ||
| V1 | ||
| V1.pm | ||