Go to file
Nick Clemens 5867cf7a40 Bug 26457: [19.11.x] Throw exception if update of issues table fails
While this won't prevent the deadlock, it should catch the case where
a deadlock causes the DB update to fail and provide feedback to the user
and rollback the transaction

I don't know how to trigger the deadlock, I can only confirm that we see it, and
that this should catch it.

To test:
1 - Apply patches
2 - Checkout several items to a patron
3 - Confirm that 'Renew all' feature continues to work as expected and all items are renewed

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Bug 26457: Unit test

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Bug 26457: (QA follow-up) Switch to PK index in UPDATE on issues

The deadlock reports tell us that multiple transactions are
waiting for a X lock on a record but using a secondary index
on borrowernumber and itemnumber. Since we have the issue_id
at hand already, we should use that and benefit from the clustered
index (on PK) instead of using a secondary index.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
2021-03-24 00:39:44 +01:00
C4 Bug 26457: [19.11.x] Throw exception if update of issues table fails 2021-03-24 00:39:44 +01:00
Koha Bug 26457: [19.11.x] Throw exception if update of issues table fails 2021-03-24 00:39:44 +01:00
OpenILS
…
acqui Bug 26997: Remove 0000-00-00 from aqorders.datecancellationprinted 2021-03-18 21:02:44 +01:00
admin Bug 27416: Make "Modify tag" and "Add tag" translatable 2021-02-02 00:37:15 +01:00
api/v1 Bug 26271: Add null to the list of accepted account_line data types 2020-09-15 23:42:39 +12:00
authorities Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
basket Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
catalogue Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
cataloguing Bug 26605: Correctly URI-encode query string in call number browse plugin 2020-11-17 18:15:44 +13:00
circ Bug 27676: Correct finesMode ne off condition 2021-02-21 16:18:24 +01:00
clubs Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
course_reserves Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
debian Bug 17429: document the --plack/--noplack options of koha-list 2021-02-02 00:18:57 +01:00
docs Bug 7143: Update about page for new devs 2021-02-04 18:35:06 +01:00
errors Bug 23329: Move error page to its own subroutine 2019-11-27 11:30:19 +00:00
etc Revert "Bug 27299: Remove tokenization for phrase register/index with ICU" 2021-02-04 18:35:03 +01:00
ill Bug 21460: (follow-up) Fix bugs found in QA 2019-04-25 10:46:56 +00:00
installer Bug 27821: Make sanitize_zero_date support datetime and timestamp 2021-03-22 16:25:09 +01:00
koha-tmpl Revert "Bug 27798: Add warning to IndependentBranches system preference" 2021-03-24 00:39:41 +01:00
labels Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
members Bug 26076: (QA Follow up) Prevent error by using a fresh resultset 2020-09-09 21:21:57 +12:00
misc Update release notes for 19.11.15 release 2021-02-23 22:33:03 +01:00
offline_circ Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
opac Bug 27626: Fix self registration if categorycode is hidden and PatronSelfRegistrationVerifyByEmail 2021-03-18 22:14:51 +01:00
patron_lists Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
patroncards Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
plugins Bug 25549: Add error reporting to plugins-home 2020-11-17 17:12:45 +13:00
reports Bug 17801: Use issuedate for limits in Most Circulated Items 2020-09-15 23:48:55 +12:00
reserve Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
reviews Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
rotating_collections Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
serials Bug 26604: "Generate next" button gives error on serials-collection.pl 2020-11-17 16:45:07 +13:00
services
…
skel
…
suggestion Bug 22868: Move suggestions_manage subperm out of acquisition perm 2020-02-10 23:08:59 +00:00
svc Bug 26457: [19.11.x] Throw exception if update of issues table fails 2021-03-24 00:39:44 +01:00
t Bug 26457: [19.11.x] Throw exception if update of issues table fails 2021-03-24 00:39:44 +01:00
tags Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
tmp/modified_authorities
…
tools Bug 26298: Don't set too_many_items_to_process if equal to limit 2021-02-11 02:48:46 +01:00
virtualshelves Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
xt
…
.editorconfig
…
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore
…
.htaccess
…
.mailmap
…
.scss-lint.yml
…
INSTALL
…
Koha.pm Increment version for 19.11.15 release 2021-02-23 22:33:02 +01:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 25792: Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 2020-09-09 22:18:40 +12:00
README
…
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-12-16 22:36:52 +01:00
README.robots
…
about.pl Bug 25826: Add a warning to the about page 2021-01-21 21:35:20 +01:00
changelanguage.pl
…
fix-perl-path.PL
…
gulpfile.js Bug 26228: Update gulpfile to work with Node.js v12 2020-09-09 16:04:42 +12:00
help.pl
…
koha_perl_deps.pl
…
kohaversion.pl
…
mainpage.pl Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
package.json Bug 26228: Update gulpfile to work with Node.js v12 2020-09-09 16:04:42 +12:00
rewrite-config.PL Bug 25792: Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 2020-09-09 22:18:40 +12:00
yarn.lock Bug 26228: Update gulpfile to work with Node.js v12 2020-09-09 16:04:42 +12:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo