Koha-clms/debian/systemd
Martin Renvoize 3eb65c1041
Bug 40901: (QA follow-up) Drop redundant ExecStart systemctl call in koha-common.service
koha-common.service already declares BindsTo=koha.target and
After=koha.target.  BindsTo= implies Requires=, so systemd will start
koha.target automatically when this compat unit starts and will wait for
it to be active before proceeding.  The explicit

    ExecStart=/bin/systemctl start koha.target

was therefore redundant, and calling systemctl from within a service body
is an anti-pattern (it makes an extra D-Bus round-trip back to PID 1 and
can deadlock in edge cases during early boot).

Replace with /bin/true so the oneshot succeeds immediately after the
ExecStartPre ES-indexer discovery step.  ExecStop is kept as-is because
there is no declarative equivalent for "stopping this unit should stop
koha.target" — BindsTo= only propagates stops in the other direction.

Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
2026-09-29 09:02:05 +00:00
..
koha-common.service Bug 40901: (QA follow-up) Drop redundant ExecStart systemctl call in koha-common.service 2026-09-29 09:02:05 +00:00
koha-create-dirs@.service Bug 40901: (follow-up) Order per-component units after koha-create-dirs 2026-09-29 09:01:56 +00:00
koha-es-indexer@.service Bug 40901: (follow-up) Systemd hardening 2026-09-29 09:01:59 +00:00
koha-indexer@.service Bug 40901: (follow-up) Systemd hardening 2026-09-29 09:01:59 +00:00
koha-plack@.service Bug 40901: (follow-up) Systemd hardening 2026-09-29 09:01:59 +00:00
koha-sip@.service Bug 40901: (follow-up) Systemd hardening 2026-09-29 09:01:59 +00:00
koha-systemd-ctl Bug 40901: (follow-up) Fix incomplete systemd wiring in helpers 2026-09-29 09:01:34 +00:00
koha-worker-long_tasks@.service Bug 40901: (follow-up) Systemd hardening 2026-09-29 09:01:59 +00:00
koha-worker@.service Bug 40901: (follow-up) Systemd hardening 2026-09-29 09:01:59 +00:00
koha-z3950@.service Bug 40901: (follow-up) Systemd hardening 2026-09-29 09:01:59 +00:00
koha-zebra@.service Bug 40901: (follow-up) Systemd hardening 2026-09-29 09:01:59 +00:00
koha.target Bug 40901: Add koha-systemd package with native systemd units 2026-09-29 09:01:21 +00:00
koha@.target Bug 40901: (follow-up) Drop redundant StopWhenUnneeded on koha@.target 2026-09-29 09:01:58 +00:00