Go to file
Martin Renvoize 3c4232e746 Bug 22489: Update onboarding tool for bug 18925
When going through the onboarding process, the tool fails on submit of step 5,
due to changes made in the database structure and rule definitions by bug
18925.

This patch fixes this, adding code that creates a circulation rule where an
issuing rule is also created in onboarding.pl. It removes maxissueqty from
being sent with params to make an issuing rule, and adds it instead to the
params to make a circulation rule, to reflect the changes that have been made
in the database.

Test plan:
1) Drop and recreate your database
2) Reload the staff client and follow the installer and onboarding
process
3) Confirm that the process finishes without errors

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Bug 22489: (follow-up) Correctly set success messages

The original patch was duplicating the success message upon successful
circ rule insertion. This corrects that.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Patches squashed for readability

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2019-03-15 11:33:09 +00:00
C4 Bug 22483: Restore exact behaviour of undef 2019-03-09 05:16:40 -03:00
Koha Bug 22368: DBRev 18.12.00.024 2019-03-11 13:03:37 +00:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 15774: (follow-up) Address QA issues 2019-03-07 20:37:05 +00:00
admin Bug 19489: Detailed Description of charges in Patron accounting 2019-03-11 12:45:58 +00:00
api/v1 Bug 22216: Make GET /patrons/{patron_id} staff only 2019-02-22 13:15:11 +00:00
authorities Bug 19994: Used Modern::Perl in Authorities perl scripts 2019-01-28 14:58:23 +00:00
basket Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-25 20:38:32 +00:00
catalogue Bug 19046: Make seach pulldown to retain index selection 2019-03-11 10:28:09 +00:00
cataloguing Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
circ Bug 17347: Ignore whitespace before and after on renewing 2019-02-11 18:30:10 +00:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 21501: Remove dead code from course reserves module 2018-11-02 10:37:45 +00:00
debian Bug 22397: Wrong message in koha-sip --start 2019-02-26 13:22:37 +00:00
docs Bug 7143: (follow-up) Update about page for new devs (Academy) 2019-02-19 13:52:14 +00:00
errors Bug 19998: use Modern::Perl in error perl scripts 2018-02-05 09:45:48 -03:00
etc Bug 22016: Always send CT field for SIP checkin, even if empty 2019-02-27 09:14:21 -05:00
ill Bug 20581: (follow-up) Passed value to status_alias 2019-02-22 14:31:31 +00:00
installer Bug 22489: Update onboarding tool for bug 18925 2019-03-15 11:33:09 +00:00
koha-tmpl Bug 11375: Compiled CSS 2019-03-11 13:08:54 +00:00
labels Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
members Bug 19489: (QA follow-up) Revert changes in printinvoice 2019-03-11 12:45:58 +00:00
misc Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
offline_circ Bug 22049: (QA follow-up) update MarkIssueReturned call in process_koc.pl 2019-01-25 20:46:48 +00:00
opac Bug 20639: (follow-up) Fix population of backends 2019-03-07 20:51:11 +00:00
patron_lists Bug 19524: Use existing logged_in_user variable 2018-07-18 16:49:30 +00:00
patroncards Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
plugins Bug 20011: use Modern::Perl in plugins perl scripts 2018-02-05 09:46:44 -03:00
reports Bug 22278: Clear cache when creating new report groups or subgroups 2019-02-08 20:46:26 +00:00
reserve Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-09 15:02:45 +00:00
serials Bug 15774: (follow-up) fix rebase issues 2019-03-07 20:37:06 +00:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 21048: (QA follow-up) Fix authorized value statuses in filter 2018-08-08 20:58:23 +00:00
svc Bug 22483: Restore svc/members/search 2019-03-09 05:16:40 -03:00
t Bug 22368: Make sure the tests will always pass 2019-03-11 12:53:29 +00:00
tags Bug 22036: Indented code where '^I' was written rather than an indent. 2019-01-17 02:23:28 +00:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities
…
tools Bug 22363: Use Koha::ActionLogs->search instead of GetLogs in log viewer 2019-03-11 11:22:00 +00:00
virtualshelves Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
xt Bug 21576: Keep compatibility with QA script 2018-10-26 17:09:52 +00:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Bug 22368: DBRev 18.12.00.024 2019-03-11 13:03:37 +00:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
Makefile.PL Bug 20174: Remove xml_sax.pl target from Makefile.pl 2019-02-15 18:42:48 +00:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
about.pl Bug 20996: Remove prefix use of borrower category 2018-11-02 10:33:02 +00:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
gulpfile.js Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display 2019-02-04 14:13:35 +00:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 21907: Fix article requests count for non-superlibrarians 2019-02-04 14:50:40 +00:00
package.json Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00
rewrite-config.PL Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
yarn.lock Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo