gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
32,923 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Mark Tompsett 2ca766f392 Bug 21349: Instructors with special characters in cardnumber cannot be removed from course reserves 
The cardnumber can contain strange non-javascript-friendly
characters. This patch converts all the internal references
to borrowernumber, but displays the cardnumber when showing
list of matching users.

TEST PLAN
---------
1) Make sure Course Reserves is being used. Check system preferences.
2) Make sure there is a Course entered.
3) Make sure there is a patron with an cardnumber which breaks
   the existing javascript (eg. Ka-boom:Ka-boom!KABOOM@#$!)
4) Go into the course list.
5) Click the course name link
6) In the "Instructor Search" box enter the patron name.
7) Select the patron which has the ugly cardnumber.
8) Click Save
   -- The course listing should have the new teacher listed.
9) Click the course name link again.
10) Click 'Remove' beside the instructor's name.
    -- nothing happens, and inspecting the error console gives
       you the ugly error described in comment #0
11) apply this patch
12) restart_all
13) sudo service apache2 restart
14) refresh the page.
15) click 'Remove' beside the instructor's name.
    -- name is removed.
16) Click Save
    -- the course listing no longer lists the new teacher.
17) Actually confirm that adding and removing others normally
    works as expected.
18) run koha qa test tools.

Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
 		2018-10-29 00:35:41 +00:00
C4 Bug 21641: (follow-up) Address wrong call method 2018-10-29 00:22:17 +00:00
Koha Bug 18591: Fix pluralization of type 2018-10-27 15:53:34 +00:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 21587: don't drop patrons to notify in order creation 2018-10-26 16:43:15 +00:00
admin Bug 21704: (QA follow-up) Fix evil tabs 2018-10-29 00:17:34 +00:00
api/v1 Bug 20772: Return cost & price_paid in API 2018-10-13 08:34:32 -03:00
authorities Bug 21456: (QA follow-up) Catch missed case in authorities merge 2018-10-17 13:52:23 +00:00
basket Bug 16575: Irregular behaviour using window.print() followed by window.location.href 2018-07-19 16:12:56 +00:00
catalogue Bug 21291: (follow-up) Pass subscriptionsnumber to all tools in staff detail's sidebar 2018-10-15 13:40:47 +00:00
cataloguing Bug 21365: Call BiblioAutoLink from AddBiblio and ModBiblio 2018-10-15 13:11:53 +00:00
circ Bug 15139: Add non-public item notes to overdue report 2018-10-15 13:56:22 +00:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 21349: Instructors with special characters in cardnumber cannot be removed from course reserves 2018-10-29 00:35:41 +00:00
debian Bug 17084: Automatic debian/control updates (unstable/master) 2018-10-13 08:50:38 -03:00
docs Bug 7143: Update about page for new devs Margaret Hade and Isobel Graham 2018-10-26 16:25:02 +00:00
errors Bug 19998: use Modern::Perl in error perl scripts 2018-02-05 09:45:48 -03:00
etc Bug 14302: (QA follow-up) Remove remaining file 2018-08-31 11:24:21 +00:00
ill Bug 18591: Allow any number of comments on ILLs 2018-10-27 13:15:58 +00:00
installer Bug 19263: DBRev 18.06.00.047 2018-10-27 14:20:56 +00:00
koha-tmpl Bug 21349: Instructors with special characters in cardnumber cannot be removed from course reserves 2018-10-29 00:35:41 +00:00
labels Bug 15766: Adding descriptions to patron card batches 2018-10-24 13:52:40 +00:00
members Bug 21167: Fix price formatting on printed fee invoice and receipt 2018-09-28 19:41:36 +00:00
misc Bug 21526: uri escape TT variables when used in 'a href' 2018-10-26 17:09:57 +00:00
offline_circ Bug 13779: (QA follow-up) Correct checkauth call in offline_circ/download.pl 2018-09-14 17:27:29 +00:00
opac Bug 20450: Add collection to item table when placing a hold on a specific copy (OPAC) 2018-10-27 14:20:57 +00:00
patron_lists Bug 19524: Use existing logged_in_user variable 2018-07-18 16:49:30 +00:00
patroncards Bug 15766: Adding descriptions to patron card batches 2018-10-24 13:52:40 +00:00
plugins Bug 20011: use Modern::Perl in plugins perl scripts 2018-02-05 09:46:44 -03:00
reports Bug 9188: Remove 'debug' information from patron statistics 2018-10-01 13:56:37 +00:00
reserve Bug 20450: Add collection to item table when placing a hold on a specific copy (Intranet) 2018-10-27 14:20:57 +00:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-09 15:02:45 +00:00
serials Bug 21511: (RM follow-up) Use orders.count instead of new variable 2018-10-24 17:22:48 +00:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 21048: (QA follow-up) Fix authorized value statuses in filter 2018-08-08 20:58:23 +00:00
svc Bug 19263: Rancor - Add auto-001 widget 2018-10-27 13:26:08 +00:00
t Bug 18591: Allow any number of comments on ILLs 2018-10-27 13:15:58 +00:00
tags Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities
…
tools Bug 21621: Remove incorrect GROUP BY from tools/letter.pl 2018-10-29 00:29:12 +00:00
virtualshelves Bug 21629: Use cn_sort instead of itemcallnumber when displaying a list 2018-10-26 17:09:51 +00:00
xt Bug 21576: Keep compatibility with QA script 2018-10-26 17:09:52 +00:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
…
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Bug 19263: DBRev 18.06.00.047 2018-10-27 14:20:56 +00:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
MANIFEST.SKIP
…
Makefile.PL Bug 19817: Remove local help files + edit help feature 2018-09-06 17:32:27 +00:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots
…
about.pl Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
changelanguage.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
gulpfile.js Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 17698: Do not send pending_checkout_notes from all circ scripts 2018-07-23 15:23:44 +00:00
package.json Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00
rewrite-config.PL Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
yarn.lock Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo