Superflous use of sprintf combined with rebasing issue left the stockrotation cronjob such that a 'No action taken' email report would catastrophically fail with the error: Redundant argument in sprintf at ./stockrotation.pl line 316 This patch both resolves the error and cleans up some additional unrequired sprintf usage. Test Plan 1) Create a rotation plan 2) Add some items to the rotation plan 3) Run the cronjob using `stockrotation.pl --report=email --send-email --execute` 4) Note the lack of errors Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> |
||
|---|---|---|
| .. | ||
| admin | ||
| bin | ||
| cronjobs | ||
| devel | ||
| interface_customization | ||
| load_testing | ||
| maintenance | ||
| migration_tools | ||
| release_notes | ||
| search_tools | ||
| translator | ||
| batchCompareMARCvsFrameworks.pl | ||
| batchDeleteUnusedSubfields.pl | ||
| batchImportMARCWithBiblionumbers.pl | ||
| batchRebuildBiblioTables.pl | ||
| batchRebuildItemsTables.pl | ||
| batchRepairMissingBiblionumbers.pl | ||
| batchdeletebiblios.pl | ||
| check_sysprefs.pl | ||
| commit_file.pl | ||
| export_borrowers.pl | ||
| export_records.pl | ||
| exportauth.pl | ||
| import_patrons.pl | ||
| koha-install-log | ||
| kohalib.pl | ||
| link_bibs_to_authorities.pl | ||
| mod_zebraqueue.pl | ||
| perlmodule_ls.pl | ||
| perlmodule_rm.pl | ||
| recreateIssueStatistics.pl | ||
| sax_parser_print.pl | ||
| sax_parser_test.pl | ||
| sip_cli_emulator.pl | ||
| stage_file.pl | ||