1705 lines
68 KiB
Perl
Executable File
1705 lines
68 KiB
Perl
Executable File
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <https://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
use Test::NoWarnings;
|
|
use Test::More tests => 12;
|
|
use Test::Exception;
|
|
|
|
use DateTime::Duration;
|
|
|
|
use C4::Context;
|
|
use Koha::Database;
|
|
use Koha::DateUtils qw( dt_from_string );
|
|
use Koha::Virtualshelves;
|
|
use Koha::Virtualshelfshares;
|
|
use Koha::Virtualshelfcontents;
|
|
|
|
use t::lib::Dates;
|
|
use t::lib::TestBuilder;
|
|
|
|
my $builder = t::lib::TestBuilder->new;
|
|
|
|
my $schema = Koha::Database->new->schema;
|
|
$schema->storage->txn_begin;
|
|
my $dbh = C4::Context->dbh;
|
|
teardown();
|
|
|
|
subtest 'CRUD' => sub {
|
|
plan tests => 15;
|
|
my $patron = $builder->build(
|
|
{
|
|
source => 'Borrower',
|
|
}
|
|
);
|
|
|
|
my $number_of_shelves = Koha::Virtualshelves->search->count;
|
|
|
|
is( $number_of_shelves, 0, 'No shelves should exist' );
|
|
|
|
my $shelf = Koha::Virtualshelf->new(
|
|
{
|
|
shelfname => "my first shelf",
|
|
owner => $patron->{borrowernumber},
|
|
public => 0,
|
|
}
|
|
)->store;
|
|
|
|
is( ref($shelf), 'Koha::Virtualshelf', 'The constructor should return a valid object' );
|
|
|
|
$number_of_shelves = Koha::Virtualshelves->search->count;
|
|
is( $number_of_shelves, 1, '1 shelf should have been inserted' );
|
|
is( $shelf->allow_change_from_owner, 1, 'The default value for allow_change_from_owner should be 1' );
|
|
is( $shelf->allow_change_from_others, 0, 'The default value for allow_change_from_others should be 0' );
|
|
is( $shelf->allow_change_from_staff, 0, 'The default value for allow_change_from_staff should be 0' );
|
|
is(
|
|
$shelf->allow_change_from_permitted_staff, 0,
|
|
'The default value for allow_change_from_permitted_staff should be 0'
|
|
);
|
|
is(
|
|
t::lib::Dates::compare( $shelf->created_on, dt_from_string ), 0,
|
|
'The creation time should have been set to today'
|
|
);
|
|
|
|
# Test if creation date will not be overwritten by store
|
|
my $created = dt_from_string->subtract( hours => 1 );
|
|
$shelf->created_on($created);
|
|
$shelf->store;
|
|
|
|
my $retrieved_shelf = Koha::Virtualshelves->find( $shelf->shelfnumber );
|
|
|
|
is( $retrieved_shelf->shelfname, $shelf->shelfname, 'Find should correctly return the shelfname' );
|
|
is(
|
|
t::lib::Dates::compare( $retrieved_shelf->created_on, $created ), 0,
|
|
'Creation date is the same after update (Bug 18672)'
|
|
);
|
|
|
|
# Insert with the same name
|
|
eval {
|
|
$shelf = Koha::Virtualshelf->new(
|
|
{
|
|
shelfname => "my first shelf",
|
|
owner => $patron->{borrowernumber},
|
|
public => 0,
|
|
}
|
|
)->store;
|
|
};
|
|
is(
|
|
ref($@), 'Koha::Exceptions::Virtualshelf::DuplicateObject',
|
|
'Exception on duplicate name'
|
|
);
|
|
$number_of_shelves = Koha::Virtualshelves->search->count;
|
|
is( $number_of_shelves, 1, 'To be sure the number of shelves is still 1' );
|
|
|
|
my $another_patron = $builder->build(
|
|
{
|
|
source => 'Borrower',
|
|
}
|
|
);
|
|
|
|
$shelf = Koha::Virtualshelf->new(
|
|
{
|
|
shelfname => "my first shelf",
|
|
owner => $another_patron->{borrowernumber},
|
|
public => 0,
|
|
}
|
|
)->store;
|
|
$number_of_shelves = Koha::Virtualshelves->search->count;
|
|
is( $number_of_shelves, 2, 'Another patron should be able to create a shelf with an existing shelfname' );
|
|
|
|
my $is_deleted = Koha::Virtualshelves->find( $shelf->shelfnumber )->delete;
|
|
ok( $is_deleted, 'The shelf has been deleted correctly' );
|
|
$number_of_shelves = Koha::Virtualshelves->search->count;
|
|
is( $number_of_shelves, 1, 'To be sure the shelf has been deleted' );
|
|
|
|
teardown();
|
|
};
|
|
|
|
subtest 'Owner filter logic' => sub {
|
|
plan tests => 16;
|
|
|
|
my ( @where_strs, @args );
|
|
|
|
my $test_logic = sub {
|
|
my ($owner) = @_;
|
|
@where_strs = ();
|
|
@args = ();
|
|
|
|
if ( defined $owner and $owner ne '' ) {
|
|
$owner =~ s/^\s+|\s+$//g; # Trim leading/trailing spaces
|
|
$owner =~ s/\s+/ /g; # Normalize internal whitespace
|
|
|
|
return ( [], [] ) if $owner eq '';
|
|
|
|
my @name_parts = split ' ', $owner;
|
|
|
|
if ( @name_parts == 2 ) {
|
|
push @where_strs, '( bo.firstname LIKE ? AND bo.surname LIKE ? )';
|
|
push @args, "%$name_parts[0]%", "%$name_parts[1]%";
|
|
} else {
|
|
push @where_strs, '(bo.firstname LIKE ? OR bo.surname LIKE ?)';
|
|
push @args, "%$owner%", "%$owner%";
|
|
}
|
|
}
|
|
|
|
return ( \@where_strs, \@args );
|
|
};
|
|
|
|
my ( $where, $args );
|
|
|
|
( $where, $args ) = $test_logic->(undef);
|
|
is_deeply( $where, [], 'No where clause when owner is undef' );
|
|
is_deeply( $args, [], 'No args when owner is undef' );
|
|
|
|
( $where, $args ) = $test_logic->('');
|
|
is_deeply( $where, [], 'No where clause when owner is empty' );
|
|
is_deeply( $args, [], 'No args when owner is empty' );
|
|
|
|
( $where, $args ) = $test_logic->('John Smith');
|
|
is_deeply( $where, ['( bo.firstname LIKE ? AND bo.surname LIKE ? )'], 'AND clause for two name parts' );
|
|
is_deeply( $args, [ '%John%', '%Smith%' ], 'Args match both names' );
|
|
|
|
( $where, $args ) = $test_logic->(' John Smith ');
|
|
is_deeply( $where, ['( bo.firstname LIKE ? AND bo.surname LIKE ? )'], 'Trimmed whitespace around two name parts' );
|
|
is_deeply( $args, [ '%John%', '%Smith%' ], 'Args match trimmed names' );
|
|
|
|
( $where, $args ) = $test_logic->('John Smith');
|
|
is_deeply( $where, ['( bo.firstname LIKE ? AND bo.surname LIKE ? )'], 'Normalized internal whitespace' );
|
|
is_deeply( $args, [ '%John%', '%Smith%' ], 'Args match normalized names' );
|
|
|
|
( $where, $args ) = $test_logic->('John ');
|
|
is_deeply( $where, ['(bo.firstname LIKE ? OR bo.surname LIKE ?)'], 'Single name with trailing space' );
|
|
is_deeply( $args, [ '%John%', '%John%' ], 'Args match single name trimmed' );
|
|
|
|
( $where, $args ) = $test_logic->(' ');
|
|
is_deeply( $where, [], 'No where clause when owner is only whitespace' );
|
|
is_deeply( $args, [], 'No args when owner is only whitespace' );
|
|
|
|
( $where, $args ) = $test_logic->(' John ');
|
|
is_deeply( $where, ['(bo.firstname LIKE ? OR bo.surname LIKE ?)'], 'Single name with leading/trailing spaces' );
|
|
is_deeply( $args, [ '%John%', '%John%' ], 'Args match cleaned single name' );
|
|
};
|
|
|
|
subtest 'Sharing' => sub {
|
|
plan tests => 21;
|
|
my $patron_wants_to_share = $builder->build(
|
|
{
|
|
source => 'Borrower',
|
|
}
|
|
);
|
|
my $share_with_me = $builder->build(
|
|
{
|
|
source => 'Borrower',
|
|
}
|
|
);
|
|
my $just_another_patron = $builder->build(
|
|
{
|
|
source => 'Borrower',
|
|
}
|
|
);
|
|
|
|
my $number_of_shelves_shared = Koha::Virtualshelfshares->search->count;
|
|
is( $number_of_shelves_shared, 0, 'No shelves should exist' );
|
|
|
|
my $shelf_to_share = Koha::Virtualshelf->new(
|
|
{
|
|
shelfname => "my first shelf",
|
|
owner => $patron_wants_to_share->{borrowernumber},
|
|
public => 0,
|
|
}
|
|
)->store;
|
|
|
|
my $shelf_not_to_share = Koha::Virtualshelf->new(
|
|
{
|
|
shelfname => "my second shelf",
|
|
owner => $patron_wants_to_share->{borrowernumber},
|
|
public => 0,
|
|
}
|
|
)->store;
|
|
|
|
my $shared_shelf = eval { $shelf_to_share->share };
|
|
is( ref($@), 'Koha::Exceptions::Virtualshelf::InvalidKeyOnSharing', 'Do not share if no key given' );
|
|
$shared_shelf = eval { $shelf_to_share->share('valid key') };
|
|
is(
|
|
ref($shared_shelf), 'Koha::Virtualshelfshare',
|
|
'On sharing, the method should return a valid Koha::Virtualshelfshare object'
|
|
);
|
|
|
|
my $another_shared_shelf = eval { $shelf_to_share->share('valid key2') }; # Just to have 2 shares in DB
|
|
|
|
$number_of_shelves_shared = Koha::Virtualshelfshares->search->count;
|
|
is( $number_of_shelves_shared, 2, '2 shares should have been inserted' );
|
|
|
|
my $is_accepted = eval { $shared_shelf->accept( 'invalid k', $share_with_me->{borrowernumber} ); };
|
|
is( $is_accepted, undef, 'The share should have not been accepted if the key is invalid' );
|
|
is(
|
|
ref($@), 'Koha::Exceptions::Virtualshelf::InvalidInviteKey',
|
|
'accept with an invalid key should raise an exception'
|
|
);
|
|
|
|
$is_accepted = $shared_shelf->accept( 'valid key', $share_with_me->{borrowernumber} );
|
|
ok( defined($is_accepted), 'The share should have been accepted if the key valid' );
|
|
|
|
is( $shelf_to_share->is_shared, 1, 'first shelf is shared' );
|
|
is( $shelf_not_to_share->is_shared, 0, 'second shelf is not shared' );
|
|
|
|
is(
|
|
$shelf_to_share->is_shared_with( $patron_wants_to_share->{borrowernumber} ), 0,
|
|
"The shelf should not be shared with the owner"
|
|
);
|
|
is(
|
|
$shelf_to_share->is_shared_with( $share_with_me->{borrowernumber} ), 1,
|
|
"The shelf should be shared with share_with_me"
|
|
);
|
|
is(
|
|
$shelf_to_share->is_shared_with( $just_another_patron->{borrowernumber} ), 0,
|
|
"The shelf should not be shared with just_another_patron"
|
|
);
|
|
|
|
is(
|
|
$shelf_to_share->remove_share( $just_another_patron->{borrowernumber} ), 0,
|
|
'No share should be removed if the share has not been done with this patron'
|
|
);
|
|
$number_of_shelves_shared = Koha::Virtualshelfshares->search->count;
|
|
is( $number_of_shelves_shared, 2, 'To be sure no shares have been removed' );
|
|
|
|
is(
|
|
$shelf_not_to_share->remove_share( $share_with_me->{borrowernumber} ), 0,
|
|
'0 share should have been removed if the shelf is not share'
|
|
);
|
|
$number_of_shelves_shared = Koha::Virtualshelfshares->search->count;
|
|
is( $number_of_shelves_shared, 2, 'To be sure no shares have been removed' );
|
|
|
|
# Test double accept (BZ 11943) before removing the accepted share
|
|
my $third_share = $shelf_to_share->share('valid key3');
|
|
is( Koha::Virtualshelfshares->search->count, 3, 'Three shares' );
|
|
$is_accepted = $third_share->accept( 'valid key3', $share_with_me->{borrowernumber} );
|
|
is( $is_accepted->shelfnumber, $shelf_to_share->shelfnumber, 'Accept returned the existing share' );
|
|
is( Koha::Virtualshelfshares->search->count, 2, 'Check that number of shares went down again' );
|
|
|
|
# Remove the first accept
|
|
ok(
|
|
$shelf_to_share->remove_share( $share_with_me->{borrowernumber} ),
|
|
'1 share should have been removed if the shelf was shared with this patron'
|
|
);
|
|
$number_of_shelves_shared = Koha::Virtualshelfshares->search->count;
|
|
is( $number_of_shelves_shared, 1, 'To be sure the share has been removed' );
|
|
|
|
teardown();
|
|
};
|
|
|
|
subtest 'Shelf content' => sub {
|
|
|
|
plan tests => 26;
|
|
my $patron1 = $builder->build( { source => 'Borrower', } );
|
|
my $patron2 = $builder->build( { source => 'Borrower', } );
|
|
my $patron3 = $builder->build( { source => 'Borrower', value => { flags => 1 } } );
|
|
my $patron4 = $builder->build( { source => 'Borrower', } );
|
|
$builder->build(
|
|
{
|
|
source => 'UserPermission',
|
|
value => {
|
|
borrowernumber => $patron4->{borrowernumber},
|
|
module_bit => 20, # lists
|
|
code => 'eit_public_list_contents',
|
|
},
|
|
}
|
|
);
|
|
my $biblio1 = $builder->build_sample_biblio;
|
|
my $biblio2 = $builder->build_sample_biblio;
|
|
my $biblio3 = $builder->build_sample_biblio;
|
|
my $biblio4 = $builder->build_sample_biblio;
|
|
my $number_of_contents = Koha::Virtualshelfcontents->search->count;
|
|
|
|
is( $number_of_contents, 0, 'No content should exist' );
|
|
|
|
my $dt_yesterday = dt_from_string->subtract_duration( DateTime::Duration->new( days => 1 ) );
|
|
my $shelf = Koha::Virtualshelf->new(
|
|
{
|
|
shelfname => "my first shelf",
|
|
owner => $patron1->{borrowernumber},
|
|
public => 0,
|
|
lastmodified => $dt_yesterday,
|
|
}
|
|
)->store;
|
|
|
|
$shelf = Koha::Virtualshelves->find( $shelf->shelfnumber );
|
|
is(
|
|
t::lib::Dates::compare( $shelf->lastmodified, $dt_yesterday ), 0,
|
|
'The lastmodified has been set to yesterday, will be useful for another test later'
|
|
);
|
|
my $content1 = $shelf->add_biblio( $biblio1->biblionumber, $patron1->{borrowernumber} );
|
|
is(
|
|
ref($content1), 'Koha::Virtualshelfcontent',
|
|
'add_biblio to a shelf should return a Koha::Virtualshelfcontent object if inserted'
|
|
);
|
|
$shelf = Koha::Virtualshelves->find( $shelf->shelfnumber );
|
|
is(
|
|
t::lib::Dates::compare( $shelf->lastmodified, dt_from_string ), 0,
|
|
'Adding a biblio to a shelf should update the lastmodified for the shelf'
|
|
);
|
|
my $content2 = $shelf->add_biblio( $biblio2->biblionumber, $patron1->{borrowernumber} );
|
|
$number_of_contents = Koha::Virtualshelfcontents->search->count;
|
|
is( $number_of_contents, 2, '2 biblio should have been inserted' );
|
|
|
|
my $content1_bis = $shelf->add_biblio( $biblio1->biblionumber, $patron1->{borrowernumber} );
|
|
is( $content1_bis, undef, 'add_biblio should return undef on duplicate' ); # Or an exception ?
|
|
$number_of_contents = Koha::Virtualshelfcontents->search->count;
|
|
is( $number_of_contents, 2, 'The biblio should not have been duplicated' );
|
|
|
|
$shelf = Koha::Virtualshelves->find( $shelf->shelfnumber );
|
|
my $contents = $shelf->get_contents;
|
|
is( $contents->count, 2, 'There are 2 biblios on this shelf' );
|
|
|
|
# Patron 2 will try to remove biblios
|
|
# allow_change_from_owner = 1, allow_change_from_others = 0 (defaults)
|
|
my $number_of_deleted_biblios = $shelf->remove_biblios(
|
|
{ biblionumbers => [ $biblio1->biblionumber ], borrowernumber => $patron2->{borrowernumber} } );
|
|
is( $number_of_deleted_biblios, 0, 'Patron 2 removed nothing' );
|
|
|
|
# Now try with patron 1
|
|
$number_of_deleted_biblios = $shelf->remove_biblios(
|
|
{ biblionumbers => [ $biblio1->biblionumber ], borrowernumber => $patron1->{borrowernumber} } );
|
|
is( $number_of_deleted_biblios, 1, 'Patron 1 removed biblio' );
|
|
$number_of_contents = Koha::Virtualshelfcontents->search->count;
|
|
is( $number_of_contents, 1, 'To be sure the content has been deleted' );
|
|
|
|
# allow_change_from_owner == 0 (readonly)
|
|
$shelf->allow_change_from_owner(0);
|
|
$shelf->store;
|
|
$number_of_deleted_biblios = $shelf->remove_biblios(
|
|
{ biblionumbers => [ $biblio2->biblionumber ], borrowernumber => $patron1->{borrowernumber} } );
|
|
is( $number_of_deleted_biblios, 0, 'Owner could not delete' );
|
|
$number_of_contents = Koha::Virtualshelfcontents->search->count;
|
|
is( $number_of_contents, 1, 'Number of entries still equal to 1' );
|
|
$shelf->add_biblio( $biblio2->biblionumber, $patron1->{borrowernumber} );
|
|
$number_of_contents = Koha::Virtualshelfcontents->search->count;
|
|
is( $number_of_contents, 1, 'Biblio not added to the list' );
|
|
|
|
# Add back biblio1
|
|
$shelf->allow_change_from_owner(1);
|
|
$shelf->add_biblio( $biblio1->biblionumber, $patron1->{borrowernumber} );
|
|
$number_of_contents = Koha::Virtualshelfcontents->search->count;
|
|
is( $number_of_contents, 2, 'Biblio added to the list' );
|
|
|
|
# allow_change_from_others == 1
|
|
$shelf->allow_change_from_others(1);
|
|
my $content3 = $shelf->add_biblio( $biblio3->biblionumber, $patron2->{borrowernumber} );
|
|
my $content4 = $shelf->add_biblio( $biblio4->biblionumber, $patron2->{borrowernumber} );
|
|
$number_of_contents = Koha::Virtualshelfcontents->search->count;
|
|
is( $number_of_contents, 4, 'The biblio should have been added to the shelf by the patron 2' );
|
|
$number_of_deleted_biblios = $shelf->remove_biblios(
|
|
{ biblionumbers => [ $biblio3->biblionumber ], borrowernumber => $patron2->{borrowernumber} } );
|
|
is( $number_of_deleted_biblios, 1, 'Biblio 3 deleted by patron 2' );
|
|
$number_of_contents = Koha::Virtualshelfcontents->search->count;
|
|
is( $number_of_contents, 3, 'Back to three entries' );
|
|
|
|
# allow_change_from_staff == 1 and allow_change_from_others == 0
|
|
$shelf->allow_change_from_staff(1);
|
|
$shelf->allow_change_from_others(0);
|
|
$content4 = $shelf->add_biblio( $biblio3->biblionumber, $patron3->{borrowernumber} );
|
|
$number_of_contents = Koha::Virtualshelfcontents->search->count;
|
|
is( $number_of_contents, 4, 'The biblio should have been added to the shelf by patron 2' );
|
|
$number_of_deleted_biblios = $shelf->remove_biblios(
|
|
{ biblionumbers => [ $biblio3->biblionumber ], borrowernumber => $patron3->{borrowernumber} } );
|
|
is( $number_of_deleted_biblios, 1, 'Biblio 3 deleted by patron 2' );
|
|
$number_of_contents = Koha::Virtualshelfcontents->search->count;
|
|
is( $number_of_contents, 3, 'Back to three entries' );
|
|
|
|
# allow_change_from_permitted_staff == 1 and allow_change_from_staff = 1 and allow_change_from_others == 0
|
|
$shelf->allow_change_from_permitted_staff(1);
|
|
$shelf->allow_change_from_staff(0);
|
|
$shelf->allow_change_from_others(1);
|
|
$content4 = $shelf->add_biblio( $biblio3->biblionumber, $patron3->{borrowernumber} );
|
|
$number_of_contents = Koha::Virtualshelfcontents->search->count;
|
|
is( $number_of_contents, 4, 'The biblio should have been added to the shelf by patron 3' );
|
|
$number_of_deleted_biblios = $shelf->remove_biblios(
|
|
{ biblionumbers => [ $biblio3->biblionumber ], borrowernumber => $patron3->{borrowernumber} } );
|
|
is( $number_of_deleted_biblios, 1, 'Biblio 3 deleted by patron 3' );
|
|
$number_of_contents = Koha::Virtualshelfcontents->search->count;
|
|
is( $number_of_contents, 3, 'Back to three entries' );
|
|
|
|
$content4 = $shelf->add_biblio( $biblio3->biblionumber, $patron4->{borrowernumber} );
|
|
$number_of_contents = Koha::Virtualshelfcontents->search->count;
|
|
is( $number_of_contents, 4, 'The biblio should have been added to the shelf by patron 4' );
|
|
$number_of_deleted_biblios = $shelf->remove_biblios(
|
|
{ biblionumbers => [ $biblio3->biblionumber ], borrowernumber => $patron4->{borrowernumber} } );
|
|
$number_of_contents = Koha::Virtualshelfcontents->search->count;
|
|
is( $number_of_contents, 3, 'Back to three entries' );
|
|
|
|
teardown();
|
|
};
|
|
|
|
subtest 'Shelf permissions' => sub {
|
|
|
|
plan tests => 175;
|
|
my $patron1 = $builder->build( { source => 'Borrower', value => { flags => '2096766' } } )
|
|
; # 2096766 is everything checked but not superlibrarian
|
|
my $patron2 = $builder->build( { source => 'Borrower', value => { flags => '1048190' } } )
|
|
; # 1048190 is everything checked but not superlibrarian and delete_public_lists
|
|
my $patron3 = $builder->build( { source => 'Borrower', value => { flags => '0' } } )
|
|
; # this is a patron with no special permissions
|
|
my $patron4 = $builder->build( { source => 'Borrower', value => { flags => '0' } } );
|
|
my $patron5 = $builder->build( { source => 'Borrower', value => { flags => '4' } } );
|
|
my $sth = $dbh->prepare("INSERT INTO user_permissions (borrowernumber, module_bit, code) VALUES (?,?,?)");
|
|
$sth->execute( $patron2->{borrowernumber}, 20, 'edit_public_list_contents' )
|
|
; # $patron2 has everything checked but not superlibrarian and delete_public_lists
|
|
$sth->execute( $patron4->{borrowernumber}, 20, 'edit_public_lists' )
|
|
; # $patron4 only has the edit_public_lists sub-permission checked
|
|
$sth->execute( $patron5->{borrowernumber}, 20, 'edit_public_list_contents' )
|
|
; # $patron5 has the 'catalogue' permission and edit_public_list_contents sub-permission checked
|
|
|
|
my $biblio1 = $builder->build_sample_biblio;
|
|
my $biblio2 = $builder->build_sample_biblio;
|
|
my $biblio3 = $builder->build_sample_biblio;
|
|
my $biblio4 = $builder->build_sample_biblio;
|
|
my $biblio5 = $builder->build_sample_biblio;
|
|
my $biblio6 = $builder->build_sample_biblio;
|
|
|
|
my $public_shelf = Koha::Virtualshelf->new(
|
|
{
|
|
shelfname => "my first shelf",
|
|
owner => $patron1->{borrowernumber},
|
|
public => 1,
|
|
allow_change_from_owner => 0,
|
|
allow_change_from_others => 0,
|
|
allow_change_from_staff => 0,
|
|
allow_change_from_permitted_staff => 0
|
|
}
|
|
)->store;
|
|
|
|
is(
|
|
$public_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to view their public list'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_viewed( $patron2->{borrowernumber} ), 1,
|
|
'Public list should be viewed by another staff member'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_viewed( $patron3->{borrowernumber} ), 1,
|
|
'Public list should be viewed by someone with no special permissions'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_viewed( $patron4->{borrowernumber} ), 1,
|
|
'Public list should be viewed by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_viewed( $patron5->{borrowernumber} ), 1,
|
|
'Public list should be viewed by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$public_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to delete their list'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0,
|
|
'Public list should not be deleted by another staff member'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0,
|
|
'Public list should not be deleted by someone with no special permissions'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_deleted( $patron4->{borrowernumber} ), 0,
|
|
'Public list should not be deleted by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_deleted( $patron5->{borrowernumber} ), 0,
|
|
'Public list should not be deleted by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$public_shelf->can_be_managed( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to manage their list'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_managed( $patron2->{borrowernumber} ), 0,
|
|
'Public list should not be managed by another staff member'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_managed( $patron3->{borrowernumber} ), 0,
|
|
'Public list should not be managed by someone with no special permissions'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_managed( $patron4->{borrowernumber} ), 1,
|
|
'Public list should be managed by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_managed( $patron5->{borrowernumber} ), 0,
|
|
'Public list should be managed by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$public_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 0,
|
|
'The owner should not be able to add biblios to their list'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 0,
|
|
'Public list should not be modified (add) by another staff member'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_added( $patron3->{borrowernumber} ), 0,
|
|
'Public list should not be modified (add) by someone with no special permissions'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_added( $patron4->{borrowernumber} ), 0,
|
|
'Public list should not be modified (add) by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_added( $patron5->{borrowernumber} ), 0,
|
|
'Public list should not be modified (add) by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$public_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 0,
|
|
'The owner should not be able to remove biblios to their list'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 0,
|
|
'Public list should not be modified (remove) by another staff member'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_removed( $patron3->{borrowernumber} ), 0,
|
|
'Public list should not be modified (removed) by someone with no special permissions'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_removed( $patron4->{borrowernumber} ), 0,
|
|
'Public list should not be modified (removed) by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_removed( $patron5->{borrowernumber} ), 0,
|
|
'Public list should not be modified (removed) by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
$public_shelf->allow_change_from_owner(1);
|
|
$public_shelf->store;
|
|
|
|
is(
|
|
$public_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to view their public list'
|
|
);
|
|
is( $public_shelf->can_be_viewed( $patron2->{borrowernumber} ), 1, 'Public list should be viewed by staff member' );
|
|
is(
|
|
$public_shelf->can_be_viewed( $patron3->{borrowernumber} ), 1,
|
|
'Public list should be viewed by someone with no special permissions'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_viewed( $patron4->{borrowernumber} ), 1,
|
|
'Public list should be viewable by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_viewed( $patron5->{borrowenumber} ), 1,
|
|
'Public list should be viewable by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$public_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to delete their list'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0,
|
|
'Public list should not be deleted by another staff member'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0,
|
|
'Public list should not be deleted by someone with no special permissions'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_deleted( $patron4->{borrowernumber} ), 0,
|
|
'Public list should not be deleted by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_deleted( $patron5->{borrowernumber} ), 0,
|
|
'Public list should not be deleted by someome with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$public_shelf->can_be_managed( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to manage their list'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_managed( $patron2->{borrowernumber} ), 0,
|
|
'Public list should not be managed by another staff member'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_managed( $patron3->{borrowernumber} ), 0,
|
|
'Public list should not be managed by someone with no special permissions'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_managed( $patron4->{borrowernumber} ), 1,
|
|
'Public list should be managed by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_managed( $patron5->{borrowernumber} ), 0,
|
|
'Public list should be managed by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$public_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to add biblios to their list'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 0,
|
|
'Public list should not be modified (add) by another staff member'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_added( $patron3->{borrowernumber} ), 0,
|
|
'Public list should not be modified (add) by someone with no special permissions'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_added( $patron4->{borrowernumber} ), 0,
|
|
'Public list should not be modified (add) by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_added( $patron5->{borrowernumber} ), 0,
|
|
'Public list should not be modified (add) by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$public_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to remove biblios to their list'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 0,
|
|
'Public list should not be modified (remove) by another staff member'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_removed( $patron3->{borrowernumber} ), 0,
|
|
'Public list should not be modified (remove) by someone with no special permissions'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_removed( $patron4->{borrowernumber} ), 0,
|
|
'Public list should not be modified (remove) by someone with the edit_public_list sub-permission checked'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_removed( $patron5->{borrowernumber} ), 0,
|
|
'Public list should not be modified (remove) by someome with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
$public_shelf->allow_change_from_staff(1);
|
|
$public_shelf->store;
|
|
|
|
is(
|
|
$public_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to view their public list'
|
|
);
|
|
is( $public_shelf->can_be_viewed( $patron2->{borrowernumber} ), 1, 'Public list should be viewed by staff member' );
|
|
is(
|
|
$public_shelf->can_be_viewed( $patron3->{borrowernumber} ), 1,
|
|
'Public list should be viewed by someone with no special permissions'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_viewed( $patron4->{borrowernumber} ), 1,
|
|
'Public list should be viewable by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_viewed( $patron5->{borrowernumber} ), 1,
|
|
'Public list should be viewable by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$public_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to delete their list'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0,
|
|
'Public list should not be deleted by another staff member'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0,
|
|
'Public list should not be deleted by someone with no special permissions'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_deleted( $patron4->{borrowernumber} ), 0,
|
|
'Public list should not be deleted by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_deleted( $patron5->{borrowernumber} ), 0,
|
|
'Public list should not be deleted by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$public_shelf->can_be_managed( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to manage their list'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_managed( $patron2->{borrowernumber} ), 0,
|
|
'Public list should not be managed by another staff member'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_managed( $patron3->{borrowernumber} ), 0,
|
|
'Public list should not be managed by someone with no special permissions'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_managed( $patron4->{borrowernumber} ), 1,
|
|
'Public list should be managed by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_managed( $patron5->{borrowernumber} ), 0,
|
|
'Public list should be managed by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$public_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to add biblios to their list'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 1,
|
|
'Public list should not be modified (add) by another staff member'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_added( $patron3->{borrowernumber} ), 0,
|
|
'Public list should not be modified (add) by someone with no special permissions'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_added( $patron4->{borrowernumber} ), 0,
|
|
'Public list should not be modified (add) by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_added( $patron5->{borrowernumber} ), 1,
|
|
'Public list should be modified (add) by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$public_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to remove biblios to their list'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 1,
|
|
'Public list should not be modified (remove) by another staff member'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_removed( $patron3->{borrowernumber} ), 0,
|
|
'Public list should not be modified (remove) by someone with no special permissions'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_removed( $patron4->{borrowernumber} ), 0,
|
|
'Public list should not be modified (remove) by someone with the edit_public_list sub-permission checked'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_removed( $patron5->{borrowernumber} ), 1,
|
|
'Public list should be modified (remove) by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
$public_shelf->allow_change_from_permitted_staff(1);
|
|
$public_shelf->store;
|
|
|
|
is(
|
|
$public_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to view their public list'
|
|
);
|
|
is( $public_shelf->can_be_viewed( $patron2->{borrowernumber} ), 1, 'Public list should be viewed by staff member' );
|
|
is(
|
|
$public_shelf->can_be_viewed( $patron3->{borrowernumber} ), 1,
|
|
'Public list should be viewed by someone with no special permissions'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_viewed( $patron4->{borrowernumber} ), 1,
|
|
'Public list should be viewable by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_viewed( $patron5->{borrowernumber} ), 1,
|
|
'Public list should be viewable by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$public_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to delete their list'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0,
|
|
'Public list should not be deleted by another staff member'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0,
|
|
'Public list should not be deleted by someone with no special permissions'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_deleted( $patron4->{borrowernumber} ), 0,
|
|
'Public list should not be deleted by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_deleted( $patron5->{borrowernumber} ), 0,
|
|
'Public list should not be deleted by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$public_shelf->can_be_managed( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to manage their list'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_managed( $patron2->{borrowernumber} ), 0,
|
|
'Public list should not be managed by another staff member'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_managed( $patron3->{borrowernumber} ), 0,
|
|
'Public list should not be managed by someone with no special permissions'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_managed( $patron4->{borrowernumber} ), 1,
|
|
'Public list should be managed by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$public_shelf->can_be_managed( $patron5->{borrowernumber} ), 0,
|
|
'Public list should be managed by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$public_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to add biblios to their list'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 1,
|
|
'Public list should be modified (add) by another staff member'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_added( $patron3->{borrowernumber} ), 0,
|
|
'Public list should not be modified (add) by someone with no special permissions'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_added( $patron4->{borrowernumber} ), 0,
|
|
'Public list should not be modified (add) by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_added( $patron5->{borrowernumber} ), 1,
|
|
'Public list should not be modified (add) by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$public_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to remove biblios to their list'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 1,
|
|
'Public list should be modified (remove) by another staff member'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_removed( $patron3->{borrowernumber} ), 0,
|
|
'Public list should not be modified (remove) by someone with no special permissions'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_removed( $patron4->{borrowernumber} ), 0,
|
|
'Public list should not be modified (remove) by someone with the edit_public_list sub-permission checked'
|
|
);
|
|
is(
|
|
$public_shelf->can_biblios_be_removed( $patron5->{borrowernumber} ), 1,
|
|
'Public list should be modified (remove) by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
my $private_shelf = Koha::Virtualshelf->new(
|
|
{
|
|
shelfname => "my first shelf",
|
|
owner => $patron1->{borrowernumber},
|
|
public => 0,
|
|
allow_change_from_owner => 0,
|
|
allow_change_from_others => 0,
|
|
allow_change_from_staff => 0,
|
|
allow_change_from_permitted_staff => 0
|
|
}
|
|
)->store;
|
|
|
|
is( $private_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1, 'The owner should be able to view their list' );
|
|
is(
|
|
$private_shelf->can_be_viewed( $patron2->{borrowernumber} ), 0,
|
|
'Private list should not be viewed by another staff member'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_viewed( $patron3->{borrowernumber} ), 0,
|
|
'Private list should not be viewed by someone with no special permissions'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_viewed( $patron4->{borrowernumber} ), 0,
|
|
'Private list should not be viewed by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_viewed( $patron5->{borrowernumber} ), 0,
|
|
'Private list should not be viewed by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$private_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to delete their list'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0,
|
|
'Private list should not be deleted by another staff member'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0,
|
|
'Private list should not be deleted by someone with no special permissions'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_deleted( $patron4->{borrowernumber} ), 0,
|
|
'Private list should not be deleted by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_deleted( $patron5->{borrowernumber} ), 0,
|
|
'Private list should not be deleted by someome with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$private_shelf->can_be_managed( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to manage their list'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_managed( $patron2->{borrowernumber} ), 0,
|
|
'Private list should not be managed by another staff member'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_managed( $patron3->{borrowernumber} ), 0,
|
|
'Private list should not be managed by someone with no special permissions'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_managed( $patron4->{borrowernumber} ), 0,
|
|
'Private list should not be managed by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_managed( $patron5->{borrowernumber} ), 0,
|
|
'Private list should not be managed by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$private_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 0,
|
|
'The owner should not be able to add biblios to their list'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 0,
|
|
'Private list should not be modified (add) by another staff member'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_added( $patron3->{borrowernumber} ), 0,
|
|
'Private list should not be modified (add) by someone with no special permissions'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_added( $patron4->{borrowernumber} ), 0,
|
|
'Private list should not be modified (add) by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_added( $patron5->{borrowernumber} ), 0,
|
|
'Private list should not be modified (add) by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$private_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 0,
|
|
'The owner should not be able to remove biblios to their list'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 0,
|
|
'Private list should not be modified (remove) by another staff member'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_removed( $patron3->{borrowernumber} ), 0,
|
|
'Private list should not be modified (remove) by someone with no special permissions'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_removed( $patron4->{borrowernumber} ), 0,
|
|
'Private list should not be modified (remove) by someone with the edit_public_lists sub-permissions'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_removed( $patron5->{borrowernumber} ), 0,
|
|
'Private list should not be modified (remove) by someone with the edit_public_list_contents sub-permissions'
|
|
);
|
|
|
|
$private_shelf->allow_change_from_owner(1);
|
|
$private_shelf->allow_change_from_staff(1);
|
|
$private_shelf->allow_change_from_others(0);
|
|
$private_shelf->allow_change_from_permitted_staff(0);
|
|
$private_shelf->store;
|
|
is( $private_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1, 'The owner should be able to view their list' );
|
|
is(
|
|
$private_shelf->can_be_viewed( $patron2->{borrowernumber} ), 0,
|
|
'Private list should not be viewed by another staff member'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_viewed( $patron3->{borrowernumber} ), 0,
|
|
'Private list should not be viewed by someone with no special permissions'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_viewed( $patron4->{borrowernumber} ), 0,
|
|
'Private list should not be viewed by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_viewed( $patron5->{borrowernumber} ), 0,
|
|
'Private list should not be viewed by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$private_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to delete their list'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0,
|
|
'Private list should not be deleted by another staff member'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0,
|
|
'Private list should not be deleted by someone with no special permissions'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_deleted( $patron4->{borrowernumber} ), 0,
|
|
'Private list should not be deleted by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_deleted( $patron5->{borrowernumber} ), 0,
|
|
'Private list should not be viewed by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$private_shelf->can_be_managed( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to manage their list'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_managed( $patron2->{borrowernumber} ), 0,
|
|
'Private list should not be managed by another staff member'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_managed( $patron3->{borrowernumber} ), 0,
|
|
'Private list should not be managed by someone with no special permissions'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_managed( $patron4->{borrowernumber} ), 0,
|
|
'Private list should not be managed by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_managed( $patron5->{borrowernumber} ), 0,
|
|
'Private list should not be managed by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$private_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to add biblios to their list'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 1,
|
|
'Private list should be modified (add) by another staff member # individual check done later'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_added( $patron3->{borrowernumber} ), 0,
|
|
'Private list should not be modified (add) by someone with no special permissions'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_added( $patron4->{borrowernumber} ), 0,
|
|
'Private list should not be modified (add) by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_added( $patron5->{borrowernumber} ), 1,
|
|
'Private list should be modififed (add) by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$private_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to remove biblios to their list'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 1,
|
|
'Private list should be modified (remove) by another staff member # individual check done later'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_removed( $patron3->{borrowernumber} ), 0,
|
|
'Private list should not be modified (remove) by someone with no special permissions'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_removed( $patron4->{borrowernumber} ), 0,
|
|
'Private list should not be modified (remove) by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_removed( $patron5->{borrowernumber} ), 1,
|
|
'Private list should be modified (remove) by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
$private_shelf->allow_change_from_owner(1);
|
|
$private_shelf->allow_change_from_others(1);
|
|
$private_shelf->store;
|
|
|
|
is( $private_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1, 'The owner should be able to view their list' );
|
|
is(
|
|
$private_shelf->can_be_viewed( $patron2->{borrowernumber} ), 0,
|
|
'Private list should not be viewed by another staff member'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_viewed( $patron3->{borrowernumber} ), 0,
|
|
'Private list should not be viewed by someone with no special permissions'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_viewed( $patron4->{borrowernumber} ), 0,
|
|
'Private list should not be viewed by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_viewed( $patron5->{borrowernumber} ), 0,
|
|
'Private list should not be viewed by someome with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$private_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to delete their list'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0,
|
|
'Private list should not be deleted by another staff member'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0,
|
|
'Private list should not be deleted by someone with no special permissions'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_deleted( $patron4->{borrowernumber} ), 0,
|
|
'Private list should not be deleted by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_deleted( $patron5->{borrowernumber} ), 0,
|
|
'Private list should not be deleted by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$private_shelf->can_be_managed( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to manage their list'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_managed( $patron2->{borrowernumber} ), 0,
|
|
'Private list should not be managed by another staff member'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_managed( $patron3->{borrowernumber} ), 0,
|
|
'Private list should not be managed by someone with no special permissions'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_managed( $patron4->{borrowernumber} ), 0,
|
|
'Private list should not be managed by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$private_shelf->can_be_managed( $patron5->{borrowernumber} ), 0,
|
|
'Private list should not be managed by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$private_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to add biblios to their list'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 1,
|
|
'Private list could be modified (add) by another staff member # individual check done later'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_added( $patron3->{borrowernumber} ), 1,
|
|
'Private list could be modified (add) by someone with no special permissions'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_added( $patron4->{borrowernumber} ), 1,
|
|
'Private list could be modified (add) by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_added( $patron5->{borrowernumber} ), 1,
|
|
'Private list could be modified (add) by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
is(
|
|
$private_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 1,
|
|
'The owner should be able to remove biblios to their list'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 1,
|
|
'Private list could be modified (remove) by another staff member # individual check done later'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_removed( $patron3->{borrowernumber} ), 1,
|
|
'Private list could be modified (remove) by someone with no special permissions'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_removed( $patron4->{borrowernumber} ), 1,
|
|
'Private list could be modified (remove) by someone with the edit_public_lists sub-permission checked'
|
|
);
|
|
is(
|
|
$private_shelf->can_biblios_be_removed( $patron5->{borrowernumber} ), 1,
|
|
'Private list could be modified (remove) by someone with the edit_public_list_contents sub-permission checked'
|
|
);
|
|
|
|
teardown();
|
|
};
|
|
|
|
subtest 'Get shelves' => sub {
|
|
plan tests => 13;
|
|
my $patron1 = $builder->build(
|
|
{
|
|
source => 'Borrower',
|
|
}
|
|
);
|
|
my $patron2 = $builder->build(
|
|
{
|
|
source => 'Borrower',
|
|
}
|
|
);
|
|
|
|
my $private_shelf1_1 = Koha::Virtualshelf->new(
|
|
{
|
|
shelfname => "private shelf 1 for patron 1",
|
|
owner => $patron1->{borrowernumber},
|
|
public => 0,
|
|
}
|
|
)->store;
|
|
my $private_shelf1_2 = Koha::Virtualshelf->new(
|
|
{
|
|
shelfname => "private shelf 2 for patron 1",
|
|
owner => $patron1->{borrowernumber},
|
|
public => 0,
|
|
}
|
|
)->store;
|
|
my $private_shelf2_1 = Koha::Virtualshelf->new(
|
|
{
|
|
shelfname => "private shelf 1 for patron 2",
|
|
owner => $patron2->{borrowernumber},
|
|
public => 0,
|
|
}
|
|
)->store;
|
|
my $public_shelf1_1 = Koha::Virtualshelf->new(
|
|
{
|
|
shelfname => "public shelf 1 for patron 1",
|
|
owner => $patron1->{borrowernumber},
|
|
public => 1,
|
|
}
|
|
)->store;
|
|
my $public_shelf1_2 = Koha::Virtualshelf->new(
|
|
{
|
|
shelfname => "public shelf 2 for patron 1",
|
|
owner => $patron1->{borrowernumber},
|
|
public => 1,
|
|
}
|
|
)->store;
|
|
my $shelf_to_share = Koha::Virtualshelf->new(
|
|
{
|
|
shelfname => "shared shelf",
|
|
owner => $patron1->{borrowernumber},
|
|
public => 0,
|
|
}
|
|
)->store;
|
|
|
|
my $private_shelves = Koha::Virtualshelves->get_private_shelves;
|
|
is( $private_shelves->count, 0, 'Without borrowernumber given, get_private_shelves should not return any shelf' );
|
|
$private_shelves = Koha::Virtualshelves->get_private_shelves( { borrowernumber => $patron1->{borrowernumber} } );
|
|
is( $private_shelves->count, 3, 'get_private_shelves should return all shelves for a given patron' );
|
|
|
|
$private_shelf2_1->share('a key')->accept( 'a key', $patron1->{borrowernumber} );
|
|
$private_shelves = Koha::Virtualshelves->get_private_shelves( { borrowernumber => $patron1->{borrowernumber} } );
|
|
is(
|
|
$private_shelves->count, 4,
|
|
'get_private_shelves should return all shelves for a given patron, even the shared ones'
|
|
);
|
|
|
|
my $private_shelves_all = $private_shelves->as_list;
|
|
is(
|
|
$private_shelves_all->[0]->shelfname, 'private shelf 1 for patron 1',
|
|
'First private shelf sorted correctly by default'
|
|
);
|
|
is( $private_shelves_all->[-1]->shelfname, 'shared shelf', 'Last private shelf sorted correctly by default' );
|
|
|
|
my $private_shelves_sort_desc = Koha::Virtualshelves->get_private_shelves(
|
|
{ borrowernumber => $patron1->{borrowernumber}, sort_by => { sortfield => 'shelfname', direction => 'desc' } }
|
|
);
|
|
my $private_shelves_sort_desc_all = $private_shelves_sort_desc->as_list;
|
|
is(
|
|
$private_shelves_sort_desc_all->[0]->shelfname, 'shared shelf',
|
|
'First private shelf sorted correctly by explicit desc name sort'
|
|
);
|
|
is(
|
|
$private_shelves_sort_desc_all->[-1]->shelfname, 'private shelf 1 for patron 1',
|
|
'Last private shelf sorted correctly by explicit desc name sort'
|
|
);
|
|
|
|
my $public_shelves = Koha::Virtualshelves->get_public_shelves;
|
|
is( $public_shelves->count, 2, 'get_public_shelves should return all public shelves, no matter who is the owner' );
|
|
my $public_shelves_all = $public_shelves->as_list;
|
|
is( $public_shelves_all->[0]->shelfname, 'public shelf 1 for patron 1', 'First shelf sorted correctly by default' );
|
|
is(
|
|
$public_shelves_all->[1]->shelfname, 'public shelf 2 for patron 1',
|
|
'Second shelf sorted correctly by default'
|
|
);
|
|
my $public_shelves_sort_desc =
|
|
Koha::Virtualshelves->get_public_shelves( { sort_by => { sortfield => 'shelfname', direction => 'desc' } } );
|
|
my $public_shelves_sort_desc_all = $public_shelves_sort_desc->as_list;
|
|
is(
|
|
$public_shelves_sort_desc_all->[0]->shelfname, 'public shelf 2 for patron 1',
|
|
'First shelf sorted correctly by explicit desc name sort'
|
|
);
|
|
is(
|
|
$public_shelves_sort_desc_all->[1]->shelfname, 'public shelf 1 for patron 1',
|
|
'Second shelf sorted correctly by explicit desc name sort'
|
|
);
|
|
|
|
my $shared_shelf = eval { $shelf_to_share->share("valid key") };
|
|
my $shared_shelves = Koha::Virtualshelfshares->search( { borrowernumber => $patron1->{borrowernumber} } );
|
|
is( $shared_shelves->count, 1, 'Found the share for patron1' );
|
|
|
|
teardown();
|
|
};
|
|
|
|
subtest 'Get shelves containing biblios' => sub {
|
|
|
|
plan tests => 9;
|
|
my $patron1 = $builder->build( { source => 'Borrower', } );
|
|
my $patron2 = $builder->build( { source => 'Borrower', } );
|
|
my $biblio1 = $builder->build_sample_biblio;
|
|
my $biblio2 = $builder->build_sample_biblio;
|
|
my $biblio3 = $builder->build_sample_biblio;
|
|
my $biblio4 = $builder->build_sample_biblio;
|
|
|
|
my $shelf1 = Koha::Virtualshelf->new(
|
|
{
|
|
shelfname => "my first shelf",
|
|
owner => $patron1->{borrowernumber},
|
|
public => 0,
|
|
}
|
|
)->store;
|
|
my $shelf2 = Koha::Virtualshelf->new(
|
|
{
|
|
shelfname => "my x second shelf", # 'x' to make it sorted after 'third'
|
|
owner => $patron2->{borrowernumber},
|
|
public => 0,
|
|
}
|
|
)->store;
|
|
my $shelf3 = Koha::Virtualshelf->new(
|
|
{
|
|
shelfname => "my third shelf",
|
|
owner => $patron1->{borrowernumber},
|
|
public => 1,
|
|
}
|
|
)->store;
|
|
|
|
my $content1 = $shelf1->add_biblio( $biblio1->biblionumber, $patron1->{borrowernumber} );
|
|
my $content2 = $shelf1->add_biblio( $biblio2->biblionumber, $patron1->{borrowernumber} );
|
|
my $content3 = $shelf2->add_biblio( $biblio2->biblionumber, $patron2->{borrowernumber} );
|
|
my $content4 = $shelf2->add_biblio( $biblio3->biblionumber, $patron2->{borrowernumber} );
|
|
my $content5 = $shelf2->add_biblio( $biblio4->biblionumber, $patron2->{borrowernumber} );
|
|
my $content6 = $shelf3->add_biblio( $biblio4->biblionumber, $patron1->{borrowernumber} );
|
|
|
|
my $shelves_with_biblio1_for_any_patrons = Koha::Virtualshelves->get_shelves_containing_record(
|
|
{
|
|
biblionumber => $biblio1->biblionumber,
|
|
}
|
|
);
|
|
is(
|
|
$shelves_with_biblio1_for_any_patrons->count, 0,
|
|
'shelf1 is private and should not be displayed if patron is not logged in'
|
|
);
|
|
|
|
my $shelves_with_biblio4_for_any_patrons = Koha::Virtualshelves->get_shelves_containing_record(
|
|
{
|
|
biblionumber => $biblio4->biblionumber,
|
|
}
|
|
);
|
|
is( $shelves_with_biblio4_for_any_patrons->count, 1, 'shelf3 is public and should be displayed for any patrons' );
|
|
is(
|
|
$shelves_with_biblio4_for_any_patrons->next->shelfname, $shelf3->shelfname,
|
|
'The correct shelf (3) should be displayed'
|
|
);
|
|
|
|
my $shelves_with_biblio1_for_other_patrons = Koha::Virtualshelves->get_shelves_containing_record(
|
|
{
|
|
biblionumber => $biblio1->biblionumber,
|
|
borrowernumber => $patron2->{borrowernumber},
|
|
}
|
|
);
|
|
is(
|
|
$shelves_with_biblio1_for_other_patrons->count, 0,
|
|
'shelf1 is private and should not be displayed for other patrons'
|
|
);
|
|
|
|
my $shelves_with_biblio1_for_owner = Koha::Virtualshelves->get_shelves_containing_record(
|
|
{
|
|
biblionumber => $biblio1->biblionumber,
|
|
borrowernumber => $patron1->{borrowernumber},
|
|
}
|
|
);
|
|
is( $shelves_with_biblio1_for_owner->count, 1, 'shelf1 is private and should be displayed for the owner' );
|
|
|
|
my $shelves_with_biblio2_for_patron1 = Koha::Virtualshelves->get_shelves_containing_record(
|
|
{
|
|
biblionumber => $biblio2->biblionumber,
|
|
borrowernumber => $patron1->{borrowernumber},
|
|
}
|
|
);
|
|
is( $shelves_with_biblio2_for_patron1->count, 1, 'Only shelf1 should be displayed for patron 1 and biblio 1' );
|
|
is(
|
|
$shelves_with_biblio2_for_patron1->next->shelfname, $shelf1->shelfname,
|
|
'The correct shelf (1) should be displayed for patron 1'
|
|
);
|
|
|
|
my $shelves_with_biblio4_for_patron2 = Koha::Virtualshelves->get_shelves_containing_record(
|
|
{
|
|
biblionumber => $biblio4->biblionumber,
|
|
borrowernumber => $patron2->{borrowernumber},
|
|
}
|
|
);
|
|
is(
|
|
$shelves_with_biblio4_for_patron2->count, 2,
|
|
'Patron should shown private and public lists for a given biblio'
|
|
);
|
|
is(
|
|
$shelves_with_biblio4_for_patron2->next->shelfname, $shelf3->shelfname,
|
|
'The shelves should be sorted by shelfname'
|
|
);
|
|
|
|
teardown();
|
|
};
|
|
|
|
subtest 'cannot_be_transferred' => sub {
|
|
plan tests => 13;
|
|
|
|
# Three patrons and a deleted one
|
|
my $staff = $builder->build_object( { class => 'Koha::Patrons', value => { flags => undef } } );
|
|
my $listowner = $builder->build_object( { class => 'Koha::Patrons' } );
|
|
my $receiver = $builder->build_object( { class => 'Koha::Patrons' } );
|
|
my $removed_patron = $builder->build_object( { class => 'Koha::Patrons' } );
|
|
$removed_patron->delete;
|
|
|
|
# Create three lists
|
|
my $private_list = Koha::Virtualshelf->new( { shelfname => "A", owner => $listowner->id } )->store;
|
|
my $public_list = Koha::Virtualshelf->new( { shelfname => "B", public => 1, owner => $listowner->id } )->store;
|
|
my $shared_list = Koha::Virtualshelf->new( { shelfname => "C", owner => $listowner->id } )->store;
|
|
$shared_list->share("key")->accept( "key", $receiver->id );
|
|
|
|
# Test on private list
|
|
is( $private_list->cannot_be_transferred, 'unauthorized_transfer', 'Private list can never be transferred' );
|
|
|
|
# Test on public list
|
|
is( $public_list->cannot_be_transferred, 'missing_by_parameter', 'Public list, no parameters' );
|
|
is(
|
|
$public_list->cannot_be_transferred( { by => $staff->id, to => $receiver->id } ), 'unauthorized_transfer',
|
|
'Lacks permission'
|
|
);
|
|
|
|
# Give recipient MINIMUM permission
|
|
$builder->build(
|
|
{
|
|
source => 'UserPermission',
|
|
value => {
|
|
borrowernumber => $receiver->id,
|
|
module_bit => 20,
|
|
code => 'edit_public_list_contents',
|
|
}
|
|
}
|
|
);
|
|
is(
|
|
$public_list->cannot_be_transferred( { by => $staff->id, to => $receiver->id } ),
|
|
'unauthorized_transfer',
|
|
'Recipient lacks necessary permissions to own public list'
|
|
);
|
|
|
|
my $perms = $builder->build(
|
|
{
|
|
source => 'UserPermission',
|
|
value => {
|
|
borrowernumber => $staff->id, module_bit => 20, code => 'edit_public_lists',
|
|
}
|
|
}
|
|
);
|
|
|
|
is(
|
|
$public_list->cannot_be_transferred( { by => $staff->id, to => $receiver->id } ),
|
|
0,
|
|
'Recipient with minimum required permission can accept ownership'
|
|
);
|
|
$staff->flags(1)->store;
|
|
is(
|
|
$public_list->cannot_be_transferred( { by => $staff->id, to => $receiver->id } ), 0,
|
|
'Superlibrarian permission passes'
|
|
);
|
|
is(
|
|
$public_list->cannot_be_transferred( { by => $staff->id, to => $receiver->id, interface => 'opac' } ),
|
|
'unauthorized_transfer',
|
|
'Not supported on OPAC'
|
|
);
|
|
is(
|
|
$public_list->cannot_be_transferred( { by => $staff->id, to => $removed_patron->id } ), 'new_owner_not_found',
|
|
'Removed patron cannot own'
|
|
);
|
|
|
|
# Test on shared list
|
|
is(
|
|
$shared_list->cannot_be_transferred( { by => $staff->id } ), 'unauthorized_transfer',
|
|
'Shared list, transfer limited to owner'
|
|
);
|
|
is(
|
|
$shared_list->cannot_be_transferred( { by => $receiver->id } ), 'unauthorized_transfer',
|
|
'Shared list, transfer still limited to owner'
|
|
);
|
|
is(
|
|
$shared_list->cannot_be_transferred( { by => $listowner->id, to => $receiver->id } ), 0,
|
|
'sharee could become owner'
|
|
);
|
|
is(
|
|
$shared_list->cannot_be_transferred( { by => $listowner->id, to => $receiver->id, interface => 'intranet' } ),
|
|
'unauthorized_transfer',
|
|
'Intranet not supported'
|
|
);
|
|
is(
|
|
$shared_list->cannot_be_transferred( { by => $listowner->id, to => $staff->id } ), 'new_owner_has_no_share',
|
|
'staff has no share'
|
|
);
|
|
};
|
|
|
|
$schema->storage->txn_rollback;
|
|
|
|
subtest 'filter_by_public() tests' => sub {
|
|
|
|
plan tests => 4;
|
|
|
|
$schema->storage->txn_begin;
|
|
|
|
my $list_1 = $builder->build_object(
|
|
{
|
|
class => 'Koha::Virtualshelves',
|
|
value => { public => 0 }
|
|
}
|
|
);
|
|
my $list_2 = $builder->build_object(
|
|
{
|
|
class => 'Koha::Virtualshelves',
|
|
value => { public => 1 }
|
|
}
|
|
);
|
|
my $list_3 = $builder->build_object(
|
|
{
|
|
class => 'Koha::Virtualshelves',
|
|
value => { public => 1 }
|
|
}
|
|
);
|
|
|
|
my $lists = Koha::Virtualshelves->search( { shelfnumber => [ $list_1->id, $list_2->id, $list_3->id ] } );
|
|
|
|
is( $lists->count, 3, 'Our three lists are returned' );
|
|
$lists = $lists->filter_by_public;
|
|
|
|
is( $lists->count, 2, 'Our two public lists are returned' );
|
|
|
|
while ( my $list = $lists->next ) {
|
|
ok( $list->public, 'Only public lists in the resultset' );
|
|
}
|
|
|
|
$schema->storage->txn_rollback;
|
|
};
|
|
|
|
subtest 'filter_by_readable() tests' => sub {
|
|
|
|
plan tests => 6;
|
|
|
|
$schema->storage->txn_begin;
|
|
|
|
my $patron_1 = $builder->build_object( { class => 'Koha::Patrons' } );
|
|
my $patron_2 = $builder->build_object( { class => 'Koha::Patrons' } );
|
|
|
|
my $list_1 = $builder->build_object(
|
|
{
|
|
class => 'Koha::Virtualshelves',
|
|
value => {
|
|
public => 0,
|
|
owner => $patron_1->id,
|
|
}
|
|
}
|
|
);
|
|
my $list_2 = $builder->build_object(
|
|
{
|
|
class => 'Koha::Virtualshelves',
|
|
value => {
|
|
public => 1,
|
|
owner => $patron_1->id,
|
|
}
|
|
}
|
|
);
|
|
my $list_3 = $builder->build_object(
|
|
{
|
|
class => 'Koha::Virtualshelves',
|
|
value => {
|
|
public => 0,
|
|
owner => $patron_2->id,
|
|
}
|
|
}
|
|
);
|
|
my $list_4 = $builder->build_object(
|
|
{
|
|
class => 'Koha::Virtualshelves',
|
|
value => {
|
|
public => 1,
|
|
owner => $patron_2->id,
|
|
}
|
|
}
|
|
);
|
|
|
|
my $lists =
|
|
Koha::Virtualshelves->search( { shelfnumber => [ $list_1->id, $list_2->id, $list_3->id, $list_4->id ] } );
|
|
|
|
is( $lists->count, 4, 'Our four lists are returned' );
|
|
|
|
throws_ok { $lists->filter_by_readable; }
|
|
'Koha::Exceptions::MissingParameter',
|
|
'Exception thrown on missing';
|
|
|
|
$lists = $lists->filter_by_readable( { patron_id => $patron_1->id } );
|
|
|
|
is( $lists->count, 3, 'Three lists are returned' );
|
|
|
|
while ( my $list = $lists->next ) {
|
|
ok( $list->owner == $patron_1->id || $list->public, 'Only public or self lists in the resultset' );
|
|
}
|
|
|
|
$schema->storage->txn_rollback;
|
|
};
|
|
|
|
subtest 'filter_by_not_suppressed() tests' => sub {
|
|
|
|
plan tests => 3;
|
|
|
|
$schema->storage->txn_begin;
|
|
|
|
my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
|
|
|
|
my $biblio_visible = $builder->build_sample_biblio;
|
|
my $biblio_suppressed = $builder->build_sample_biblio;
|
|
$biblio_suppressed->opac_suppressed(1)->store;
|
|
|
|
my $shelf = Koha::Virtualshelf->new(
|
|
{
|
|
shelfname => 'test_suppression_shelf',
|
|
owner => $patron->borrowernumber,
|
|
public => 1,
|
|
}
|
|
)->store;
|
|
|
|
$shelf->add_biblio( $biblio_visible->biblionumber, $patron->borrowernumber );
|
|
$shelf->add_biblio( $biblio_suppressed->biblionumber, $patron->borrowernumber );
|
|
|
|
my $contents = $shelf->get_contents;
|
|
is( $contents->count, 2, 'Shelf has 2 entries' );
|
|
|
|
my $filtered = $shelf->get_contents->filter_by_not_suppressed;
|
|
is( $filtered->count, 1, 'filter_by_not_suppressed returns only non-suppressed records' );
|
|
|
|
is(
|
|
$filtered->next->biblionumber,
|
|
$biblio_visible->biblionumber,
|
|
'The returned content is the visible biblio'
|
|
);
|
|
|
|
$schema->storage->txn_rollback;
|
|
};
|
|
|
|
sub teardown {
|
|
$dbh->do(q|DELETE FROM virtualshelfshares|);
|
|
$dbh->do(q|DELETE FROM virtualshelfcontents|);
|
|
$dbh->do(q|DELETE FROM virtualshelves|);
|
|
}
|