gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/misc/cronjobs
History
Martin Renvoize 167622c08d
Bug 40934: (follow-up) Fix false positive on --code/--exclude-code mutual exclusivity 
The mutual-exclusivity check ran before the empty-element cleanup added
for bug 37075, so a bare -c (no value) left an empty string in
@letter_code, which the check saw as truthy and rejected even though
-c had effectively not been used. Move the cleanup above the check.

Also add the same mutual-exclusivity guard directly in
C4::Letters::SendQueuedMessages, since letter_code and
exclude_letter_code build the same search key and passing both would
otherwise let one silently clobber the other in the hashref passed to
->search - only the CLI script enforced this until now, so any other
caller could hit the silent-clobber bug.

Adds regression coverage: unit tests for the new exception in
SendQueuedMessages, and a script-level test reproducing the RM's
reported false positive.

Sponsored-by: OpenFifth <https://openfifth.co.uk/>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
 		2026-09-21 11:56:49 +00:00
..
holds Bug 42310: (follow-up) Move Koha::Calendar tree under Koha::Library::Calendar 2026-09-15 16:14:02 +00:00
recalls Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
rss Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
social_data Bug 40748: Check for HTTP URLs and skip shell when using system() 2025-09-26 09:10:20 -06:00
thirdparty Bug 42310: (follow-up) Move Koha::Calendar tree under Koha::Library::Calendar 2026-09-15 16:14:02 +00:00
CONFIGURE.gmail Bug 40163: (follow-up) Fix wrong GNU links and update test 2025-09-24 09:25:04 -06:00
advance_notices.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
anonymize_last_borrowers.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
archive_purchase_suggestions.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
automatic_checkin.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
automatic_item_modification_by_age.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
automatic_renewals.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
backup.sh
…
batch_anonymise.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
build_browser_and_cloud.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
cart_to_shelf.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
check-url-quick.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
cleanup_database.pl Bug 42310: (QA follow-up) Clean up stale references to dropped calendar tables 2026-09-15 16:14:15 +00:00
cloud-kw.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
cloud-sample.conf
…
create_koc_db.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
crontab.example Bug 39250: Add archive_purchase_suggestions.pl to cron.daily commented 2025-03-07 15:41:17 +01:00
debar_patrons_with_fines.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
delete_items.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
delete_patrons.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
delete_records_via_leader.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
edi_cron.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
erm_run_harvester.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
fines.pl Bug 42310: (follow-up) Move Koha::Calendar tree under Koha::Library::Calendar 2026-09-15 16:14:02 +00:00
gather_print_notices.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
harvest_oai.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
import_webservice_batch.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
longoverdue.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
marc_ordering_process.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
membership_expiry.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
merge_authorities.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
notice_unprocessed_suggestions.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
overdue_notices.pl Bug 42310: (follow-up) Move Koha::Calendar tree under Koha::Library::Calendar 2026-09-15 16:14:02 +00:00
patron_emailer.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
plugins_nightly.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
printoverdues.sh Bug 39208: Remove xhtml2pdf from printoverdues.sh 2026-07-16 10:54:24 +00:00
process_message_queue.pl Bug 40934: (follow-up) Fix false positive on --code/--exclude-code mutual exclusivity 2026-09-21 11:56:49 +00:00
purge_suggestions.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
reconcile_balances.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
remove_temporary_edifiles.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
restrict_patrons_with_failed_notices.pl Bug 42714: Add missing use Koha::Script -cron to cron scripts 2026-07-28 14:32:34 +00:00
runreport.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
serialsUpdate.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
sftp_file.pl Bug 42714: Add missing use Koha::Script -cron to cron scripts 2026-07-28 14:32:34 +00:00
share_usage_with_koha_community.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
sitemap.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
staticfines.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
stockrotation.pl Bug 40225: Send stockrotation report even when all items are stationary 2026-06-18 16:02:08 +00:00
update_patrons_category.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
update_totalissues.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00
writeoff_debts.pl Bug 42714: Remove redundant manual cronlogaction calls from scripts 2026-07-28 14:32:32 +00:00