Koha-clms/C4
Galen Charlton 45aa375aae do some validation of the KohaOpacRecentSearches cookie
Add validation of the value of the KohaOpacRecentSearches.  In
particular, this patch avoids the generation of an internal server
error when the OPAC is presented with an old cookie that uses the
old Storable-based serialization.

This patch also moves parsing of the cookie value into a
new routine in C4::Auth, ParseSearchHistoryCookie, and adds
a test case.

To test (in conjunction with the previous patch):

Exercise the OPAC search history functionality, after
turning on the EnableOpacSearchHistory syspref:

- As an anonymous user, conduct a variety of searches,
  including ones that include non-ASCII characters
- Check the search history and verify that all searches
  are listed
- Apply this patch and the previous one.
- Do *not* clear the KohaOpacRecentSearches cookie
- Check the search history and verify that no searches
  are listed any more
- As an anonymous user, conduct a variety of searches,
  including ones that include non-ASCII characters
- Check the search history and verify that all searches
  are listed
- Log into the OPAC
- Verify that current and past searches are listed in
  search history.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2013-07-28 03:28:11 +00:00
..
AuthoritiesMarc Bug 5385: POD Cleanups (part 1) 2010-11-11 19:48:14 -05:00
Barcodes Bug 5385 - Fixing an error that crept in with the POD cleanup 2010-11-11 19:48:15 -05:00
Cache Bug 5385: POD Cleanups (part 1) 2010-11-11 19:48:14 -05:00
ClassSortRoutine Bug 4265: Fix padding of short callnumbers and Bib-1 attribute for sorting 2011-04-04 20:03:00 -04:00
Creators Bug 2246 - (Partial) Label printing doesn't work with Unicode characters 2011-06-13 20:47:21 -04:00
External Bug 5385: POD Cleanups (part 1) 2010-11-11 19:48:14 -05:00
Form Bug 5889: Messages name in english for notifications on public interface. 2011-03-23 12:27:17 -04:00
Heading Bug 5385: POD Cleanups (part 1) 2010-11-11 19:48:14 -05:00
ILSDI Bug 5450 Avoid a name clash in ILSDI modules 2010-11-30 16:24:42 -05:00
Installer Lower dependency on Storable to 2.20 in PerlDependencies.pm 2011-04-16 15:22:03 -04:00
Labels bug 5653: use itemcallnumber in bib label layouts 2011-06-13 20:59:55 -04:00
Members Bug 5595 : Fixing a security glitch (please always use placeholders or 2011-03-14 14:04:19 -04:00
Output Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Patroncards fixing various links to point to *.koha-community.org 2010-10-21 22:08:24 -04:00
Reports Bug 6024 : add "Run report" link on the new report creation success page 2011-04-16 14:44:04 -04:00
SIP Bug 5601 Fix processing of DueDate return 2011-01-12 13:42:20 -05:00
Search Bug 5385: POD Cleanups (part 1) 2010-11-11 19:48:14 -05:00
VirtualShelves Bug 6155 : Fixing bug with lists not showing 2011-04-16 14:57:47 -04:00
tests Bug 2505 - Add commented use warnings where missing in the C4/ directory 2010-04-21 20:25:32 +12:00
Accounts.pm fixing various links to point to *.koha-community.org 2010-10-21 22:08:24 -04:00
Acquisition.pm Bug 6062: ordering basketgroups 2011-04-16 13:41:11 -04:00
Auth.pm do some validation of the KohaOpacRecentSearches cookie 2013-07-28 03:28:11 +00:00
Auth_with_cas.pm MT3186: Remove warnings from Auth_with_cas 2010-04-23 06:55:13 -04:00
Auth_with_ldap.pm Bug 5094 auth_by_bind authentication can fail even if given a correct password and userid 2011-06-19 15:02:58 -04:00
AuthoritiesMarc.pm Bug 3072: Search for Heading-Main in authorities 2011-04-16 14:39:09 -04:00
BackgroundJob.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Barcodes.pm Bug 5681: Fixes leading zeroes in Add Mulpiple Copies 2011-02-02 17:10:05 -05:00
Biblio.pm Bug 6106: add item not respecting framework in acq The PrepareItemrecordDisplay sub builds an item framework for later use in ACQ Some cases were missing : item subfield connected to a plugin, hidden subfield, long size subfield. 2011-04-16 14:38:12 -04:00
Bookseller.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Boolean.pm Bug 5448: Refactor Boolean.pm 2010-12-01 16:54:52 -05:00
Branch.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Breeding.pm Fix for Bug 4290 - search for author in repository 2011-03-05 19:37:22 -05:00
Budgets.pm Bug 5962 : Budgets showing when they shouldn't (MT #4717) Bug in Koha 3.2 on acqui-home.pl 2011-04-11 15:45:07 -04:00
Cache.pm Bug 5363 - Removing unused module (C4::Cache::FastMemcached) 2010-11-04 19:17:19 -04:00
Calendar.pm Fix for Bug 4991, Overhaul of Calendar interface 2010-11-02 22:11:38 -04:00
Category.pm POD Cleanups 2010-06-09 08:38:59 -04:00
Charset.pm Bug 3644 Add support for NORMARC 2011-04-16 11:06:07 -04:00
Circulation.pm Fix for Reserves.t allow the tests to run without a logged in user 2011-04-16 15:18:25 -04:00
ClassSortRoutine.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
ClassSource.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Context.pm remove old revision history notes from a couple files 2010-06-25 05:18:44 -04:00
Contract.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Creators.pm Fix some compile time errors reported in test suite 2010-12-01 16:55:44 -05:00
Csv.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Dates.pm Dates : improvements string recognition 2010-01-28 15:11:47 +01:00
Debug.pm More POD cleanups 2010-06-09 08:38:58 -04:00
Heading.pm Bug 5410 : Adds "do-not-truncate" in the search queries of Heading.pm 2011-04-11 15:49:49 -04:00
ImportBatch.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Input.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Installer.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
ItemCirculationAlertPreference.pm POD Cleanups 2010-06-09 08:38:59 -04:00
ItemType.pm POD Cleanups 2010-06-09 08:38:59 -04:00
Items.pm Bug 5990: Lists and Cart show LOC code not Location Authorized value 2011-04-16 11:17:30 -04:00
Koha.pm Bug #6082 - On aqbudgets.pl bug on the Statistic's combobox 2011-04-16 14:38:27 -04:00
Labels.pm Bringing label, patroncard, and creator modules into conformity with the rest of C4 style. 2010-02-08 20:54:34 -05:00
Languages.pm bug 4188: move PDF templates for printed purchase orders 2010-07-02 08:49:44 -04:00
Letters.pm Bug #6130 - Letters: Fixing Subject encoding 2011-04-16 14:48:07 -04:00
Log.pm Bug 6014 : Removing a leftover warn 2011-04-16 13:15:23 -04:00
Maintainance.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Matcher.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Members.pm Bug 6218: patron gets dot added if no first name 2011-05-30 10:09:33 -04:00
Message.pm POD Cleanups 2010-06-09 08:38:59 -04:00
NewsChannels.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Output.pm Bug 6629 vulnerability fix 2011-12-03 21:16:34 -05:00
Overdues.pm Bug #6064 Improvement of default value usage in overdue 2011-04-16 13:41:25 -04:00
Patroncards.pm Fix some compile time errors reported in test suite 2010-12-01 16:55:44 -05:00
Print.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Record.pm remove two disused functions 2010-10-21 20:31:51 -04:00
Reports.pm More POD cleanups 2010-06-09 08:38:58 -04:00
Reserves.pm Bug 3595 (partial): Items seen at checkin are not filling holds well 2011-03-22 17:21:28 -04:00
Review.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Ris.pm remove a bunch of unconditional debug warns 2010-07-02 10:57:08 -04:00
RotatingCollections.pm Fix some compile time errors reported in test suite 2010-12-01 16:55:44 -05:00
SMS.pm More POD cleanups 2010-06-09 08:38:58 -04:00
SQLHelper.pm Bug 6017 : MT3157 : editing an attribute lead to Error500 2011-04-16 14:44:40 -04:00
Scheduler.pm POD Cleanups 2010-06-09 08:38:59 -04:00
Scrubber.pm Bug 5611: Simple typo fix in the comments 2011-01-12 15:43:05 -05:00
Search.pm Bug 6154: Default sorting by title doesn't work 2011-04-16 15:15:28 -04:00
Serials.pm Bug 6315: Fix depreciated constructions in C4::Serials 2011-05-30 10:10:04 -04:00
Service.pm POD Cleanups 2010-06-09 08:38:59 -04:00
Stats.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Suggestions.pm Bug 5947 Suggestions : add date to the search query 2011-04-16 12:13:06 -04:00
Tags.pm More POD cleanups 2010-06-09 08:38:58 -04:00
UploadedFile.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Utils.pm Big LDAP changes, module test for Context.pm, still more yet to come. 2007-12-04 17:27:06 -06:00
VirtualShelves.pm Bug 6096 Correctly return arrayref from GetAllShelves 2011-04-16 14:38:56 -04:00
XISBN.pm Fix for Bug 5570 - item types not showing on other editions 2011-01-10 14:42:15 -05:00
XSLT.pm Follow up for Bug 3326: previous fix broke searches when 2011-03-22 17:21:49 -04:00
Z3950.pm fixing various links to point to *.koha-community.org 2010-10-21 22:08:24 -04:00