Koha-clms/tools
Jonathan Druart 2e0d9f41bb Bug 20462: Ensure batch item deletion will not delete the same item twice
This has been done on bug 9509 when barcodes are scaned, but not when using a text file.

Test plan (stolen from Barton on the bug report):
1) Create a text file containing duplicate barcodes

Here's a quick way to do that, substitute INSTANCE for the instance name of your test server:

sudo koha-mysql INSTANCE <<< "select barcode from items where barcode is not null limit 3" | sed '1d;p' > /tmp/dup_barcodes.txt

2) Go to Home › Tools › Batch item deletion
3) Click 'Choose File', select the file you created in step 1.
4) Click 'Continue'
5) Note that duplicate items appear in the list of items to batch delete
6) Check 'Delete records if no items remain'
7) This will trigger a software error

Note that entering the barcodes via the 'scan items one by one' text box removes duplicates in the list, so this only causes problems when uploading a file.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 1f4baf31bb)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2018-05-22 11:57:04 +02:00
..
csv-profiles MT2116: Addons to the CSV export 2010-02-17 07:51:33 -05:00
quotes Bug 17411: Remove 3 other occurrences of exit 1 2016-10-21 15:08:54 +00:00
ajax-inventory.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
automatic_item_modification_by_age.pl Bug 16889: Remove C4::Items::biblioitems_columns and use Koha::Biblioitems->columns instead 2016-07-15 18:12:13 +00:00
background-job-progress.pl Bug 14589: Adjust authorities_merge_ajax and replace some indirect syntax 2015-11-02 12:49:13 -03:00
batchMod.pl Bug 20462: Ensure batch item deletion will not delete the same item twice 2018-05-22 11:57:04 +02:00
batch_delete_records.pl Bug 9988: Merge should have a parameter hash 2017-04-13 08:53:46 -04:00
batch_record_modification.pl Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00
batch_records_ajax.pl Bug 19937: Silence warnings t/db_dependent/www/batch.t 2018-01-31 08:26:34 +01:00
cleanborrowers.pl Bug 16966: move parameters to hashref 2017-03-03 17:20:05 +00:00
copy-holidays.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
csv-profiles.pl Bug 15451: Better error handling 2016-07-22 17:18:37 +00:00
exceptionHolidays.pl Bug 16154: Fix some other occurrences 2016-04-26 23:16:44 +00:00
export.pl Bug 18201: Export data -Fix "Remove non-local items" option and add "Removes non-local records" option for existing functionality 2018-01-15 16:44:37 +01:00
holidays.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
import_borrowers.pl Bug 18124: Change the calls to generate and check CSRF tokens 2017-03-30 09:07:09 +00:00
inventory.pl Bug 20098: Inventory tool: CVS export: fix itemlost column 2018-03-12 16:16:54 +01:00
koha-news.pl Bug 17960: Rename opac_news.new with opac_news.content 2017-02-06 17:42:12 +00:00
letter.pl Bug 17762: Update the letter form interface 2017-05-09 20:56:41 +00:00
manage-marc-import.pl Bug 18577 - Importing a batch using a framework not fully set up causes and endless loop 2017-07-18 14:06:47 +02:00
marc_modification_templates.pl Bug 16295: Fix access to MMT admin page 2017-05-28 22:09:35 -04:00
modborrowers.pl Bug 19673: Allow to set patron attributes to 0 with batch patron modification 2018-05-22 11:28:42 +02:00
newHolidays.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
overduerules.pl Bug 15758: Koha::Libraries - Move mybranch to C4::Context 2016-09-08 14:36:03 +00:00
picture-upload.pl Bug 18124: Change the calls to generate and check CSRF tokens 2017-03-30 09:07:09 +00:00
quotes-upload.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
quotes.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
scheduler.pl Bug 16154: Fix some other occurrences 2016-04-26 23:16:44 +00:00
showdiffmarc.pl Bug 17804: Remove some modules from showdiffmarc.pl 2016-12-23 11:26:36 +00:00
stage-marc-import.pl Bug 19163: Critical typo in stage-marc-import process 2017-09-12 16:06:02 +02:00
tools-home.pl Bug 15839: Koha::Reviews - Remove getnumberofreviews 2016-09-09 10:29:58 +00:00
upload-cover-image.pl Bug 17501: Remove Koha::Upload::get from Koha::Upload 2017-01-20 14:20:05 +00:00
upload-file.pl Bug 17501: Rename Upload to Uploader 2017-01-20 14:20:06 +00:00
upload.pl Bug 17501: [Follow-up] QA Requests 2017-01-20 14:20:07 +00:00
viewlog.pl Bug 19621: Use Koha.Preference on template side to display/hide "Routing lists" tab 2018-01-19 13:43:13 +01:00