Koha-clms/members
Jonathan Druart b7c622aef0 Bug 12346: Display the correct number of pending patron modifications on the patron module home page
Due to the way members-home.pl handles the variable $branch, the number
of patron modifications listed on members-home.pl may differ from the
number listed on mainpage.pl. When the librarian clicks this link, he or
she may see a different number than was listed, or none at all!

Test Plan:
0) Set IndependentBranchesPatronModifications = Yes
1) Create a number of modification request for BranchA
2) Log into the staff intranet with a patron without superlibrarian
permissions and set your branch to BranchB
3) Note the modifications alert to does not display on mainpage.pl
4) Click the "Patrons" link to take you to members-home.pl
5) Note the modifictions alert does display on this page
6) Apply this patch
7) Reload members-home.pl, note the alert no longer displays

QA notes: What was the point of the branch variable?

Followed test plan, patch worked as described. Also passed QA test tool
Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 4efe251f35)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 4f2dede23f)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
2017-10-29 18:46:48 +01:00
..
boraccount.pl Bug 18423 - Followup - enable Add child button for institutional borrowers 2017-04-22 00:37:58 +02:00
default_messageprefs.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
deletemem.pl Bug 18423 - Followup - enable Add child button for institutional borrowers 2017-04-22 00:37:58 +02:00
discharge.pl Bug 15823: Can still access patron discharge slip without having the syspref on 2016-05-06 04:20:48 +00:00
discharges.pl Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
files.pl Bug 18423 - Followup - enable Add child button for institutional borrowers 2017-04-22 00:37:58 +02:00
guarantor_search.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
housebound.pl Bug 18632: Remove 'CGI::param called in list context' warnings 2017-08-16 23:19:44 +02:00
mancredit.pl Bug 18423 - Followup - enable Add child button for institutional borrowers 2017-04-22 00:37:58 +02:00
maninvoice.pl Bug 18423 - Followup - enable Add child button for institutional borrowers 2017-04-22 00:37:58 +02:00
member-flags.pl Bug 18423 - Followup - enable Add child button for institutional borrowers 2017-04-22 00:37:58 +02:00
member-password.pl Bug 18423 - Followup - enable Add child button for institutional borrowers 2017-04-22 00:37:58 +02:00
member.pl Bug 17375: Search by dateofbirth - handle invalid dates 2016-10-27 13:18:32 +00:00
memberentry.pl Bug 18179: Update existing calls 2017-06-11 21:38:16 +02:00
members-home.pl Bug 12346: Display the correct number of pending patron modifications on the patron module home page 2017-10-29 18:46:48 +01:00
members-update-do.pl Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch 2016-09-08 14:36:04 +00:00
members-update.pl Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch 2016-09-08 14:36:04 +00:00
mod_debarment.pl Bug 18858: Prevent warn when deleting a borrower debarment 2017-07-19 23:15:32 +02:00
moremember.pl Bug 18469: QA Follow-up 2017-10-01 23:46:07 +02:00
nl-search.pl Bug 15407: Koha::Patron::Categories - replace C4::Category->all 2016-09-08 13:29:03 +00:00
notices.pl Bug 18423 - Followup - enable Add child button for institutional borrowers 2017-04-22 00:37:58 +02:00
patronimage.pl Bug 17423 - patronimage.pl permission is too restrictive 2016-10-17 23:44:25 +00:00
pay.pl Bug 18423 - Followup - enable Add child button for institutional borrowers 2017-04-22 00:37:58 +02:00
paycollect.pl Bug 19117: Add CSRF protection to paycollect.pl 2017-10-22 22:06:56 +00:00
print_overdues.pl Bug 12933: (QA followup) Rename GetOverdues to GetOverduesForPatron 2015-11-04 12:41:29 -03:00
printfeercpt.pl Bug 18423 - Followup - enable Add child button for institutional borrowers 2017-04-22 00:37:58 +02:00
printinvoice.pl Bug 18423 - Followup - enable Add child button for institutional borrowers 2017-04-22 00:37:58 +02:00
printslip.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
purchase-suggestions.pl Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch 2016-09-08 14:36:04 +00:00
readingrec.pl Bug 18423 - Followup - enable Add child button for institutional borrowers 2017-04-22 00:37:58 +02:00
routing-lists.pl Bug 18423 - Followup - enable Add child button for institutional borrowers 2017-04-22 00:37:58 +02:00
setstatus.pl Bug 16911: Rename extend_subscription with renew_account 2016-09-09 09:45:32 +00:00
statistics.pl Bug 18423 - Followup - enable Add child button for institutional borrowers 2017-04-22 00:37:58 +02:00
summary-print.pl Bug 17128: Make summary-print.pl plack safe 2016-09-02 14:23:16 +00:00
update-child.pl Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType 2016-09-08 13:29:22 +00:00